| 00:28:59
| * st_luke | quit (Remote host closed the connection) |
| 00:34:02
| * fallsemo | quit (Quit: Leaving.) |
| 00:35:24
| * julianduque | quit (Quit: leaving) |
| 00:36:41
| * st_luke | joined |
| 00:51:31
| * st_luke | quit (Remote host closed the connection) |
| 01:09:38
| * thlorenz | joined |
| 01:36:36
| <soldair> | dominictarr: i finally got time to trace my "uncatchable" error associated with my multilevel patch https://github.com/juliangruber/multilevel/blob/master/lib/client.js#L137 doesn't expose the actual rpc stream |
| 01:36:59
| <soldair> | to bind error to it |
| 01:37:37
| <dominictarr> | hmm, that link doesn't make sense |
| 01:37:47
| <dominictarr> | I just see setTimeout(function () { |
| 01:37:48
| <dominictarr> | self.emit('open'); |
| 01:37:49
| <dominictarr> | }); |
| 01:37:51
| <dominictarr> | at that line |
| 01:37:55
| <dominictarr> | is that correct? |
| 01:39:54
| <dominictarr> | soldair: ^ |
| 01:40:07
| <soldair> | dominictarr: sorry |
| 01:40:21
| <soldair> | dominictarr: one sec i must have miss clicked |
| 01:40:47
| <soldair> | dominictarr: line 137 |
| 01:41:34
| <soldair> | wird i clicked 137 but it highlights 141 |
| 01:42:20
| <soldair> | dominictarr: anyway. i can either bind error to ignore it an maintain existing expectaions or return the rpc client so i can bind error |
| 02:03:37
| * jmartins | joined |
| 02:03:42
| <dominictarr> | soldair: 141 is an empty line on that file |
| 02:04:04
| <soldair> | 137 |
| 02:05:07
| <soldair> | dominictarr: im gping to ignore errors on the stream created in that pipe chain. the error get emitted to any active streams which is exactly the intention of the patch |
| 02:06:50
| <dominictarr> | soldair: maybe you linked me to the wrong branch? |
| 02:06:57
| <dominictarr> | or the wrong fork? |
| 02:07:14
| <soldair> | dominictarr: that could be it. ill sen you my pull request link it will make sense there |
| 02:08:23
| <dominictarr> | cool |
| 02:16:19
| <soldair> | dominictarr: https://github.com/juliangruber/multilevel/pull/26 |
| 02:18:36
| <dominictarr> | soldair: I think you need to have the noop error listener on both rpc streams. |
| 02:20:03
| <soldair> | dominictarr: ok.ill fix that. |
| 02:30:38
| * ramitos | quit (Ping timeout: 246 seconds) |
| 02:36:44
| <soldair> | dominictarr: it doesnt throw if i don't bind error on client (rpc-stream) i'm not sure why |
| 02:37:19
| <dominictarr> | hmm. tht |
| 02:37:40
| <dominictarr> | hmm, I think it probably should... |
| 02:37:58
| <dominictarr> | it might be related to the way to are doing the fake connections... |
| 02:38:06
| <soldair> | dominictarr: did you mean on the server side? im not sure the server side of mdm should be error:true for any reason other than logging stream failures. |
| 02:38:19
| <soldair> | dominictarr: yeah. |
| 02:38:47
| <dominictarr> | hmm, well, mdm doesn't really know about servers or clients. |
| 02:39:15
| <dominictarr> | logging failures is enough… possibly also disposing of resources. |
| 02:39:55
| <soldair> | ok ill find a noop to add. right now if a client closes unexpectedly it crashes the server |
| 02:42:56
| <dominictarr> | hmm… or maybe the right anwser is to have an error: true option that is passed through to mux-demux? |
| 02:46:24
| <soldair> | dominictarr: im not sure. i would like the client by default to support errors. but its not really needed by default on the server unless you wanted to support server side resume logic |
| 02:50:38
| <dominictarr> | hmm... |
| 02:51:28
| <dominictarr> | that sounds reasonable… it should probably still be an option though. |
| 03:06:52
| <soldair> | dominictarr: server side errors are tricky in this case because there is no interface for binding events inless you are the db object. do you think we can get this without solving that quite yet? ill either ignore them or not pass error true on the server? |
| 03:10:28
| * thlorenz | quit (Remote host closed the connection) |
| 03:12:24
| * jmartins | quit (Quit: Leaving) |
| 03:20:43
| * soldair | quit (Quit: Page closed) |
| 03:22:43
| <dominictarr> | yeah, just don't pass error=true on server. |
| 03:28:14
| * ramitos | joined |
| 03:36:49
| * ralphtheninja | quit (Ping timeout: 246 seconds) |
| 03:47:13
| * dominictarr | quit (Quit: dominictarr) |
| 05:06:47
| * godoitis | joined |
| 05:37:59
| * ramitos | quit (Quit: Textual IRC Client: www.textualapp.com) |
| 05:46:38
| * godoitis | quit (Ping timeout: 240 seconds) |
| 06:09:48
| * soldair | joined |
| 06:10:46
| * jxson | joined |
| 06:12:00
| * godoitis | joined |
| 06:16:54
| * godoitis | quit (Quit: Bye) |
| 07:05:56
| * jxson | quit (Remote host closed the connection) |