00:00:01  * ircretaryquit (Remote host closed the connection)
00:00:10  * ircretaryjoined
00:00:10  <trevnorris>once you've done that you'll have to change the commit message.
00:00:24  <chrisdickinson>git commit --amend?
00:00:33  <trevnorris>yeah, since it's only one commit that'll work
00:01:00  <trevnorris>if it's more than one then I would have done `git rebase -i <upstream>/<branch>` then reword all commits
00:01:28  <chrisdickinson>do you usually squash multiple commits down, or leave history intact?
00:01:36  <trevnorris>at the bottom put "Reviewed-By: Chris Dickinson <[email protected]>"
00:01:47  <trevnorris>also add me: "Trevor Norris <[email protected]>"
00:01:51  <trevnorris>it depends on the PR
00:02:14  <trevnorris>If the commits are separated into logical and testable segments then we'll leave the history alone.
00:02:19  <chrisdickinson>two `reviewed-by` lines, or one comma separated?
00:02:24  <trevnorris>two lines
00:02:33  <trevnorris>if it's just a bunch of random commits then we'll squash them.
00:02:54  <chrisdickinson>cool
00:04:13  <trevnorris>even for simple changes I usually run tests one last time just to make sure.
00:04:32  <trevnorris>then if things pass I'll push upstream. :)
00:04:51  <trevnorris>then paste the commit hash to the PR and close it.
00:05:06  <chrisdickinson>rad :) running tests now
00:07:31  * c4miloquit (Remote host closed the connection)
00:11:37  <MI6>joyent/node: Jackson Tian v0.12 * 1781c8b : http: Improve _addHeaderLines method - http://git.io/oFYbLA
00:11:47  <trevnorris>coolio. thanks.
00:12:16  <chrisdickinson>thanks!
00:14:17  <trevnorris>yeah, np.
00:16:29  <trevnorris>chrisdickinson: if you don't mind, when I review PR's I'll just sign off and ping you to merge.
00:21:49  * trevnorris&
00:21:49  <LOUDBOT>FRIDAY NIGHT METAFILTER IRC WOOP WOOP
00:23:29  <chrisdickinson>sounds good!
00:23:52  * AlexisMochaquit (Ping timeout: 240 seconds)
00:24:12  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
00:26:54  * zz_karupachanged nick to karupa
00:39:24  * sh1mmerquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
00:40:03  * sh1mmerjoined
00:41:00  <chrisdickinson>hey folks, thoughts on splitting the "easy" label into "good-first-issue" and "mentor-available" labels?
00:44:52  * dsantiagojoined
00:49:27  * zcourtsquit (Quit: zcourts)
00:49:56  * avalanche123quit (Remote host closed the connection)
00:50:56  * avalanche123joined
00:52:09  * dap_1joined
00:53:30  * dap_quit (Ping timeout: 250 seconds)
00:55:20  * avalanche123quit (Ping timeout: 244 seconds)
01:02:46  * toothrotjoined
01:05:24  * c4milojoined
01:08:44  <jgi>chrisdickinson: yes, I was thinking about a similar distinction recently
01:09:41  <chrisdickinson>it seems like it might be a little disconcerting to newcomers to run into problems on an issue labeled "easy"
01:14:18  <jgi>chrisdickinson: also, it would help developers who are not core committers but who are able and willing to tackle more significant tasks to differentiate them from tasks that are less interesting to them
01:14:20  * kazuponjoined
01:17:20  <jgi>chrisdickinson: I have to run, thank you for bringing that up :)
01:17:41  <chrisdickinson>no problem, later!
01:17:58  * jgiquit (Quit: jgi)
01:24:28  * Ralithquit (Ping timeout: 260 seconds)
01:34:23  * sandr8joined
01:35:24  * c4miloquit (Read error: Connection reset by peer)
01:36:00  * c4milojoined
01:39:30  * sandr8quit (Ping timeout: 272 seconds)
01:40:54  * sh1mmerquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
01:50:02  * iarnajoined
01:54:01  * Ralithjoined
01:56:11  * rmgquit (Remote host closed the connection)
01:56:45  * rmgjoined
02:00:54  * rmgquit (Ping timeout: 246 seconds)
02:01:51  * rmgjoined
02:07:07  * rmgquit (Ping timeout: 272 seconds)
02:09:00  * toothrotquit (Quit: here we are)
02:14:43  * c4miloquit (Ping timeout: 272 seconds)
02:14:48  * c4milo_joined
02:17:31  * iarnaquit (Remote host closed the connection)
02:17:36  * pgicxplzsquit (Remote host closed the connection)
02:18:32  * brsonquit (Quit: leaving)
02:19:11  * iarnajoined
02:27:24  * rmgjoined
02:31:32  * AvianFlujoined
02:31:41  * iarnaquit (Remote host closed the connection)
02:32:59  * rmgquit (Ping timeout: 244 seconds)
02:35:24  * iarnajoined
02:46:17  * iarnaquit (Remote host closed the connection)
02:49:40  * iarnajoined
02:54:34  * kazuponquit (Remote host closed the connection)
02:55:04  * kazuponjoined
02:59:42  * kazuponquit (Ping timeout: 258 seconds)
03:06:54  * kazuponjoined
03:09:04  * abraxasjoined
03:11:20  * kazuponquit (Ping timeout: 260 seconds)
03:22:32  * janjongboomjoined
03:25:53  * kazuponjoined
03:26:27  * cjihrigquit (Quit: Leaving.)
03:27:51  * dap_joined
03:27:58  * thlorenzjoined
03:29:27  * dap_1quit (Ping timeout: 245 seconds)
03:30:22  * kazuponquit (Ping timeout: 258 seconds)
03:31:22  * rmgjoined
03:34:25  * thlorenzquit (Remote host closed the connection)
03:35:39  * sandr8joined
03:36:09  * rmgquit (Ping timeout: 260 seconds)
03:40:20  * sandr8quit (Ping timeout: 258 seconds)
03:45:23  * AvianFluquit (Ping timeout: 240 seconds)
04:13:47  * c4milo_quit (Remote host closed the connection)
04:17:20  * iarnaquit (Read error: Connection reset by peer)
04:17:49  * iarnajoined
04:21:47  <indutny>trevnorris: evening :)
04:21:56  <indutny>oh, you are not around anymore :(
04:25:03  * kazuponjoined
04:26:01  * janjongboomquit (Ping timeout: 260 seconds)
04:30:05  * iarnaquit (Read error: Connection reset by peer)
04:30:34  * iarnajoined
04:38:06  * abraxasquit (Remote host closed the connection)
04:38:59  * janjongboomjoined
05:03:57  <trevnorris>indutny: sup?
05:07:42  <indutny>hey man
05:07:44  <indutny>tjfontaine: all good
05:07:46  <indutny>oops
05:07:48  <indutny>trevnorris: all good
05:07:50  <indutny>how are you?
05:08:03  <trevnorris>well. just wrapping up a couple things before heading off to bed.
05:09:00  <trevnorris>indutny: can you explain why it's needed to use uv_loop_s in node.h?
05:09:10  <trevnorris>seems strange it can't just use uv_loop_t
05:09:14  <indutny>well
05:09:19  <indutny>no `uv.h` in `node.h`
05:09:30  <indutny>it doesn't know what `uv_loop_t*`
05:09:57  <trevnorris>ah, duh. so I assume the use of uv_loop_t in node.h is new.
05:10:52  <trevnorris>indutny: so why start passing the loop to CreateEnvironment()?
05:11:17  <indutny>yes, it is new
05:11:19  <indutny>ok
05:11:22  <indutny>so debugger-agent
05:11:27  <MI6>joyent/node: cjihrig master * 25702ab : net: remove use of arguments in Server constructor - http://git.io/bkA1_Q
05:11:29  <indutny>it is no longer a full C++ thing
05:11:35  <indutny>it is implemented as a node.js application
05:11:42  <indutny>and I'm spinning it off in another thread
05:11:44  <indutny>with another loop
05:11:53  <indutny>our code-base was almost ready for this
05:11:57  <indutny>thanks to bnoordhuis
05:12:04  <indutny>but the Environment always picked the default loop
05:12:07  <indutny>which is kind of not what I want
05:12:12  <indutny>so I made two version of it
05:12:14  <indutny>one for compatibility
05:12:18  <indutny>and extended version
05:12:20  <indutny>also
05:12:23  <indutny>split it up into two parts
05:12:29  <indutny>so the src/node.js won't be executed immediately
05:12:37  <indutny>and will be executed only in LoadEnvironment()
05:14:10  <trevnorris>so that's now part of the public api. doesn't that mean in a module I could spin off other threads with other event loops and create new environments?
05:20:31  <trevnorris>indutny: ^
05:20:34  <trevnorris>bbiab
05:20:56  * iarnaquit (Remote host closed the connection)
05:24:15  <indutny>yes
05:24:17  <indutny>trevnorris: you can
05:24:22  <indutny>sorry, was afk for a breakfast
05:30:41  <indutny>trevnorris: do you have any objections against using 3.29?
05:30:49  <indutny>it seems to be more dangerous
05:30:57  <indutny>but we could always revert to 3.28
05:31:06  <indutny>the API hasn't changed much AFAIK
05:33:46  <indutny>good thing is that we will receive backports for a long time
05:34:06  <indutny>and harmony iterators for sure
05:39:18  * sandr8joined
05:39:18  * sandr8quit (Remote host closed the connection)
05:39:19  * rendarjoined
05:39:36  * sandr8joined
05:43:35  <indutny>sorry
05:43:37  <indutny>going to groceries
05:43:40  <indutny>will return in like 2 hours
05:46:06  <trevnorris>chrisdickinson: ping
05:50:11  <indutny>trevnorris: temprorarily back
05:50:12  <indutny>:)
05:50:13  <indutny>for a few minutes
05:50:30  <trevnorris>indutny: cool. real quick, I'm going to land https://github.com/joyent/node/pull/7719 first.
05:50:38  <indutny>makes sense
05:50:39  <indutny>LGTM
05:50:45  <indutny>ok
05:50:48  <indutny>I'm off
05:50:51  <trevnorris>see ya
05:50:51  <indutny>see ya
05:51:00  * abraxasjoined
05:54:02  * iarnajoined
05:59:31  * c4milojoined
06:02:23  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
06:04:18  * c4miloquit (Ping timeout: 244 seconds)
06:05:22  * iarnaquit (Ping timeout: 240 seconds)
06:16:54  * AlexisMochajoined
06:39:42  * AlexisMochaquit (Ping timeout: 272 seconds)
06:55:06  * daviddiasjoined
07:01:42  * iarnajoined
07:05:53  * iarnaquit (Ping timeout: 240 seconds)
07:06:54  * saghuljoined
07:10:33  * janjongboomjoined
07:13:03  * abraxasquit (Remote host closed the connection)
07:23:57  <MI6>joyent/libuv: Saúl Ibarra Corretgé v1.x * e4dc4aa : doc: add documentation for missing functions and structures - http://git.io/eXK42Q
07:24:36  <saghul>creationix: https://github.com/joyent/libuv/commit/e4dc4aaac5964a0638198cd0907409e7a2a9a2f3
07:24:46  <indutny>trevnorris: back
07:25:00  <indutny>still around by any chance?
07:40:41  * kazupon_joined
07:42:42  * dsantiagoquit (Ping timeout: 245 seconds)
07:44:20  * kazuponquit (Ping timeout: 260 seconds)
07:47:54  * c4milojoined
07:48:32  * dsantiagojoined
07:49:28  * wolfeidauquit (Remote host closed the connection)
07:52:55  * c4miloquit (Ping timeout: 272 seconds)
07:53:12  * dsantiagoquit (Ping timeout: 260 seconds)
07:53:23  * dsantiag_joined
07:58:02  * dsantiag_changed nick to dsantiago
08:05:24  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
08:06:57  * abraxasjoined
08:06:59  * inolenquit (Quit: Leaving.)
08:13:04  * kazupon_quit (Remote host closed the connection)
08:13:31  * kazuponjoined
08:18:15  * kazuponquit (Ping timeout: 258 seconds)
08:18:53  * petka_joined
08:22:48  * janjongboomjoined
08:44:33  * janjongboomquit (Ping timeout: 260 seconds)
08:47:03  * wolfeidaujoined
08:50:49  * janjongboomjoined
08:54:50  * iarnajoined
08:58:53  * iarnaquit (Ping timeout: 240 seconds)
09:00:23  * AlexisMochajoined
09:01:42  <kkaefer>is there a way to find out whether a libuv loop is still running?
09:02:21  <kkaefer>there is uv_loop_alive(), but this just tells me whether there is something to do for the loop, not whether it is currently being run
09:04:27  * AlexisMochaquit (Ping timeout: 245 seconds)
09:09:02  * euoiaquit (Ping timeout: 260 seconds)
09:09:18  * kazuponjoined
09:09:51  * euoiajoined
09:12:58  * AlexisMochajoined
09:22:06  <indutny>kkaefer: you could track this information yourself
09:22:08  <indutny>just do
09:22:11  <indutny>running = 1
09:22:12  <indutny>uv_run()
09:22:13  <indutny>running = 0
09:22:14  <indutny>:)
09:22:16  <indutny>or something like this
09:24:45  * daviddiasquit (Quit: Textual IRC Client: www.textualapp.com)
09:25:53  * Left_Turnjoined
09:25:59  * janjongb_joined
09:27:56  * janjongboomquit (Ping timeout: 272 seconds)
09:28:57  * roxluquit (Remote host closed the connection)
09:36:03  * c4milojoined
09:37:02  * kellabytequit (Ping timeout: 272 seconds)
09:37:53  <saghul>kkaefer also, if you are running with UV_RUN_DEFAULT, if the loop it's not alive it won't run
09:38:38  * kellabytejoined
09:39:22  * Left_Turnquit (Ping timeout: 245 seconds)
09:41:14  * c4miloquit (Ping timeout: 272 seconds)
09:43:21  * AlexisMochaquit (Ping timeout: 258 seconds)
09:49:06  * wolfeidauquit (Remote host closed the connection)
09:53:38  * Left_Turnjoined
09:54:51  * karupachanged nick to zz_karupa
10:00:29  * kazuponquit (Remote host closed the connection)
10:00:58  * kazuponjoined
10:05:34  * kazuponquit (Ping timeout: 250 seconds)
10:05:45  * kazuponjoined
10:13:50  * kazuponquit (Remote host closed the connection)
10:14:19  * kazuponjoined
10:17:22  * vigithquit (Ping timeout: 245 seconds)
10:17:54  * kazupon_joined
10:18:23  * vigithjoined
10:18:49  * kazuponquit (Ping timeout: 260 seconds)
10:19:55  * wolfeidaujoined
10:22:02  * kazupon_quit (Ping timeout: 250 seconds)
10:26:23  * AlexisMochajoined
10:31:39  * abraxasquit (Remote host closed the connection)
10:42:09  * seishunjoined
10:55:49  * wolfeidauquit (Remote host closed the connection)
10:56:03  * iarnajoined
11:00:24  * iarnaquit (Ping timeout: 258 seconds)
11:00:46  * chris_99joined
11:00:58  * c4milojoined
11:15:45  * saghulquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
11:26:52  * no9quit (Ping timeout: 245 seconds)
11:32:27  * AlexisMochaquit (Ping timeout: 246 seconds)
11:41:57  * chris_99quit (Remote host closed the connection)
11:43:46  * icarotjoined
11:52:46  * AlexisMochajoined
11:53:59  * AvianFlujoined
11:54:18  * chris_99joined
12:05:40  * saghuljoined
12:06:59  * jas-joined
12:08:17  * prettyrobotsjoined
12:32:30  * abraxasjoined
12:36:52  * abraxasquit (Ping timeout: 240 seconds)
12:48:06  * cjihrigjoined
12:57:53  * iarnajoined
13:01:45  * ferossquit (Ping timeout: 260 seconds)
13:02:18  * iarnaquit (Ping timeout: 258 seconds)
13:05:12  * ferossjoined
13:10:49  * lance|afkchanged nick to lanceball
13:20:57  * cjihrigquit (Quit: Leaving.)
13:21:09  * icarotquit (Excess Flood)
13:38:17  * saghulquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
13:45:41  * jcrugzz_joined
13:45:48  * jcrugzz_changed nick to jcrugzz
13:51:40  * cjihrigjoined
13:55:32  * cjihrigquit (Read error: No route to host)
14:04:48  * thlorenzjoined
14:04:53  * cjihrigjoined
14:06:57  * thlorenzquit (Remote host closed the connection)
14:21:37  * KennethWilkejoined
14:33:45  * thlorenzjoined
14:40:22  * rmgjoined
14:45:28  * rmgquit (Ping timeout: 272 seconds)
14:59:12  * iarnajoined
15:02:42  * iarnaquit (Remote host closed the connection)
15:02:54  * iarnajoined
15:07:17  * benglquit (Ping timeout: 260 seconds)
15:19:36  * bengljoined
15:30:16  * chris_99quit (Remote host closed the connection)
15:32:49  <indutny>morning SF
15:33:16  <pquerna>indutny: good morning indutny
15:33:21  <indutny>oh Paul!
15:33:23  <indutny>long time
15:33:24  <indutny>how are you?
15:34:00  * chris_99joined
15:45:00  * janjongb_quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
15:48:27  * mikealjoined
15:51:44  * AvianFluquit (Ping timeout: 272 seconds)
15:55:39  * a_lequit (Remote host closed the connection)
16:00:35  * janjongboomjoined
16:01:36  * brsonjoined
16:02:28  * chris_99quit (Remote host closed the connection)
16:05:04  * chris_99joined
16:06:16  * mikealquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
16:10:39  * kenperkinsquit (Quit: Computer has gone to sleep.)