00:00:03  * ircretaryquit (Remote host closed the connection)
00:00:14  * ircretaryjoined
00:03:09  * chris_99quit (Quit: Ex-Chat)
00:06:57  * AlexisMochaquit (Ping timeout: 272 seconds)
00:07:39  * piscisaureusquit (Ping timeout: 246 seconds)
00:33:02  * EhevuTovquit (Quit: This computer has gone to sleep)
00:36:23  * toothrotjoined
00:43:34  * rmgquit (Remote host closed the connection)
01:05:32  * kazuponjoined
01:08:20  * avalanch_quit (Remote host closed the connection)
01:08:48  * avalanche123joined
01:10:22  * Ralithquit (Ping timeout: 240 seconds)
01:13:27  * avalanche123quit (Ping timeout: 256 seconds)
01:15:25  * kazuponquit (Remote host closed the connection)
01:29:02  * chris_99joined
01:37:50  * inolenquit (Read error: No route to host)
01:39:03  * Ralithjoined
01:41:35  * jgiquit (Quit: jgi)
01:44:06  * rmgjoined
01:48:26  * rmgquit (Ping timeout: 244 seconds)
02:09:19  * Left_Turnquit (Remote host closed the connection)
02:10:12  * avalanche123joined
02:14:14  * kazuponjoined
02:22:55  * avalanche123quit (Remote host closed the connection)
02:23:21  * avalanche123joined
02:24:55  * chris_99quit (Quit: Ex-Chat)
02:27:38  * avalanche123quit (Ping timeout: 250 seconds)
02:27:49  * kenperkinsquit (Quit: Computer has gone to sleep.)
02:31:53  * toothrotquit (Ping timeout: 240 seconds)
02:35:47  <a_le>can i brutally call uv_close on a tcp handle to drop the connection, no matter what I still have to read and what pending writes have still to be flushed?
02:46:44  * kenperkinsjoined
02:51:40  * iarnaquit (Remote host closed the connection)
02:54:13  * iarnajoined
03:00:24  * octetcloudjoined
03:00:55  * iarnaquit (Remote host closed the connection)
03:01:07  * iarnajoined
03:15:23  * cjihrigquit (Quit: Leaving.)
03:16:04  * thlorenzquit (Remote host closed the connection)
03:38:31  * kazuponquit (Remote host closed the connection)
03:40:18  * avalanche123joined
03:53:48  * avalanche123quit (Remote host closed the connection)
03:54:15  * avalanche123joined
03:58:58  * avalanche123quit (Ping timeout: 265 seconds)
04:02:12  * kazuponjoined
04:06:57  * kazuponquit (Ping timeout: 245 seconds)
04:35:27  * iarnaquit (Remote host closed the connection)
04:41:04  * avalanche123joined
04:57:48  * kazuponjoined
05:07:40  * kazuponquit (Ping timeout: 265 seconds)
05:15:49  * kenperkinsquit (Remote host closed the connection)
05:15:57  * iarnajoined
05:40:01  * octetcloudquit (Ping timeout: 260 seconds)
05:48:42  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
05:55:55  * ijrothjoined
06:05:31  * a_lequit (Remote host closed the connection)
06:08:50  * avalanche123quit (Remote host closed the connection)
06:09:16  * avalanche123joined
06:13:50  * avalanche123quit (Ping timeout: 250 seconds)
06:19:13  * kazuponjoined
06:23:35  * bajtosjoined
06:36:21  * rendarjoined
06:43:39  * Ldxngxjoined
06:47:36  * kkaeferquit (*.net *.split)
06:47:37  * nathan7quit (*.net *.split)
06:47:38  * mitsuhikoquit (*.net *.split)
06:47:38  * paulfryzelquit (*.net *.split)
06:47:39  * tjfontainequit (*.net *.split)
06:47:39  * kazuponquit (*.net *.split)
06:47:39  * ircretaryquit (*.net *.split)
06:47:39  * MI6quit (*.net *.split)
06:47:39  * Wraithanquit (*.net *.split)
06:47:40  * hollandaisquit (*.net *.split)
06:47:40  * brucemquit (*.net *.split)
06:47:40  * mmaleckiquit (*.net *.split)
06:51:06  * hayesquit (Ping timeout: 250 seconds)
06:56:18  * hayesjoined
06:59:54  * stagasjoined
07:00:36  * kazuponjoined
07:00:36  * ircretaryjoined
07:00:36  * MI6joined
07:00:36  * Wraithanjoined
07:00:36  * hollandaisjoined
07:00:36  * brucemjoined
07:00:36  * mitsuhikojoined
07:00:36  * paulfryzeljoined
07:00:36  * tjfontainejoined
07:00:36  * mmaleckijoined
07:06:03  * a_lejoined
07:09:55  * kkaeferjoined
07:09:55  * nathan7joined
07:12:23  * a_lequit (Ping timeout: 240 seconds)
07:28:59  * kkaeferquit (*.net *.split)
07:29:00  * nathan7quit (*.net *.split)
07:29:02  * mitsuhikoquit (*.net *.split)
07:29:02  * paulfryzelquit (*.net *.split)
07:29:02  * tjfontainequit (*.net *.split)
07:29:02  * kazuponquit (*.net *.split)
07:29:03  * ircretaryquit (*.net *.split)
07:29:03  * MI6quit (*.net *.split)
07:29:03  * Wraithanquit (*.net *.split)
07:29:03  * hollandaisquit (*.net *.split)
07:29:03  * brucemquit (*.net *.split)
07:29:03  * mmaleckiquit (*.net *.split)
07:32:22  * mmaleckijoined
07:32:22  * brucemjoined
07:32:22  * hollandaisjoined
07:32:22  * Wraithanjoined
07:32:22  * MI6joined
07:32:22  * ircretaryjoined
07:32:22  * kazuponjoined
07:32:22  * kkaeferjoined
07:32:22  * nathan7joined
07:36:45  * kazuponquit (*.net *.split)
07:36:45  * ircretaryquit (*.net *.split)
07:36:45  * MI6quit (*.net *.split)
07:36:46  * Wraithanquit (*.net *.split)
07:36:46  * hollandaisquit (*.net *.split)
07:36:46  * brucemquit (*.net *.split)
07:36:47  * mmaleckiquit (*.net *.split)
07:37:30  * mitsuhikojoined
07:37:30  * paulfryzeljoined
07:37:30  * tjfontainejoined
07:40:04  * kazuponjoined
07:40:04  * ircretaryjoined
07:40:04  * MI6joined
07:40:04  * Wraithanjoined
07:40:04  * hollandaisjoined
07:40:04  * brucemjoined
07:40:04  * mmaleckijoined
07:43:17  * janjongboomjoined
08:01:11  * Ralithquit (Ping timeout: 265 seconds)
08:06:32  * Ralithjoined
08:10:28  * ijrothquit (Quit: Leaving.)
08:44:38  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
08:45:48  * janjongboomjoined
08:51:33  * indexzerojoined
08:51:42  * indexzeroquit (Client Quit)
08:51:42  * indexzero_changed nick to indexzero
08:51:51  * Left_Turnjoined
08:53:31  * indexzeroquit
08:53:47  * indexzerojoined
09:15:55  * bajtosquit (Quit: bajtos)
09:16:29  * EhevuTovjoined
09:17:56  * bajtosjoined
09:25:55  * AlexisMochajoined
09:44:48  * iarnaquit (Remote host closed the connection)
09:51:42  * bajtosquit (Quit: bajtos)
09:53:24  * hayesquit (*.net *.split)
09:53:24  * rendarquit (*.net *.split)
09:53:24  * sblomquit (*.net *.split)
09:53:24  * hueniversequit (*.net *.split)
09:53:25  * jan____quit (*.net *.split)
09:53:46  * hayesjoined
09:53:46  * rendarjoined
09:53:46  * sblomjoined
09:53:46  * hueniversejoined
09:53:46  * jan____joined
09:55:22  * kazuponquit (*.net *.split)
09:55:22  * ircretaryquit (*.net *.split)
09:55:22  * MI6quit (*.net *.split)
09:55:22  * Wraithanquit (*.net *.split)
09:55:23  * hollandaisquit (*.net *.split)
09:55:23  * brucemquit (*.net *.split)
09:55:23  * mmaleckiquit (*.net *.split)
09:56:05  * kazuponjoined
09:56:05  * ircretaryjoined
09:56:05  * MI6joined
09:56:05  * Wraithanjoined
09:56:05  * hollandaisjoined
09:56:05  * brucemjoined
09:56:05  * mmaleckijoined
09:58:16  * mscdexquit (*.net *.split)
09:58:16  * CAPSLOCKBOTquit (*.net *.split)
09:58:17  * sandr8quit (*.net *.split)
09:58:17  * LinuxJediquit (*.net *.split)
09:58:17  * prettyrobotsquit (*.net *.split)
09:58:58  * mscdexjoined
09:58:58  * CAPSLOCKBOTjoined
09:58:58  * sandr8joined
09:58:58  * LinuxJedijoined
09:58:58  * prettyrobotsjoined
10:09:19  * rmgjoined
10:14:01  * seishunjoined
10:14:19  * rmgquit (Ping timeout: 272 seconds)
10:16:55  * bajtosjoined
10:22:02  * chris_99joined
10:28:27  * jas-joined
10:45:12  * iarnajoined
10:49:33  * iarnaquit (Ping timeout: 255 seconds)
10:54:27  * EhevuTovquit (Quit: This computer has gone to sleep)
10:58:05  * toothrotjoined
10:58:28  * warehouse13joined
11:01:05  * Left_Turnquit (Ping timeout: 260 seconds)
11:36:11  * AlexisMochaquit (Ping timeout: 244 seconds)
11:36:26  * kazuponquit (Remote host closed the connection)
11:47:24  * AlexisMochajoined
12:13:27  * avalanche123joined
12:18:15  * avalanche123quit (Ping timeout: 244 seconds)
12:22:03  * bajtosquit (Quit: bajtos)
12:26:56  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
12:31:42  * toothrotquit (Ping timeout: 250 seconds)
12:40:37  * cjihrigjoined
12:49:16  * Dijoined
12:54:26  * SergeiRNDjoined
12:57:59  * cjihrigquit (Quit: Leaving.)
13:02:26  * SergeiRNDpart
13:08:41  * kazuponjoined
13:08:46  * SergeiRNDjoined
13:11:07  * a_lejoined
13:11:27  * kazuponquit (Remote host closed the connection)
13:13:41  * SergeiRNDquit (Quit: Leaving.)
13:13:59  * SergeiRNDjoined
13:15:28  * a_lequit (Ping timeout: 250 seconds)
13:15:44  * SergeiRNDpart
13:16:14  * Dipart
13:18:31  * SergeiRNDjoined
13:18:32  * iarnajoined
13:18:34  * Dijoined
13:20:10  * SergeiRNDpart
13:20:13  * SergeiRNDjoined
13:22:51  * iarnaquit (Ping timeout: 246 seconds)
13:27:59  * AlexisMochaquit (Ping timeout: 258 seconds)
13:30:19  * davijoined
13:30:20  * daviquit (Changing host)
13:30:20  * davijoined
13:42:16  * SergeiRNDquit (Quit: Leaving.)
13:42:22  * AlexisMochajoined
13:44:25  * Diquit (Ping timeout: 260 seconds)
13:45:01  * cjihrigjoined
13:49:03  * thlorenzjoined
13:52:22  * kazuponjoined
13:54:52  * seishunquit (Ping timeout: 255 seconds)
14:00:03  * seishunjoined
14:00:58  * stagasquit (Ping timeout: 250 seconds)
14:04:16  * euoiaquit (*.net *.split)
14:12:36  * thlorenzquit (Remote host closed the connection)
14:14:55  * M28quit (Read error: Connection reset by peer)
14:15:01  * M28_joined
14:15:19  * avalanche123joined
14:18:07  * saghulquit (Quit: leaving)
14:19:44  * avalanche123quit (Ping timeout: 258 seconds)
14:22:15  * thlorenzjoined
14:22:38  * chris_99quit (Remote host closed the connection)
14:53:57  * importantshockjoined
15:15:02  * chris_99joined
15:22:54  * toothrotjoined
15:30:26  * yunongquit (Read error: Connection reset by peer)
15:31:02  * sblomquit (Read error: Connection reset by peer)
15:31:19  * yunongjoined
15:32:17  * jan____quit (Excess Flood)
15:33:09  * sblomjoined
15:33:22  * jan____joined
15:35:09  * a_lejoined
15:36:40  * jan____quit (Changing host)
15:36:40  * jan____joined
15:47:10  * kriskowaljoined
15:52:14  * rmgjoined
15:55:45  * toothrotquit (Ping timeout: 265 seconds)
15:57:53  * importantshockquit (Read error: Connection reset by peer)
15:57:56  * a_lequit (Read error: Connection reset by peer)
15:58:23  * SergeiRNDjoined
15:58:33  * importantshockjoined
15:58:38  * a_lejoined
16:02:35  * avalanche123joined
16:10:10  * cosnisjoined
16:12:22  * octetcloudjoined
16:13:36  * avalanche123quit (Remote host closed the connection)
16:14:03  * avalanche123joined
16:16:43  * cosnisquit (Quit: Textual IRC Client: www.textualapp.com)
16:17:25  * cosnisjoined
16:18:01  * cosnisquit (Client Quit)
16:18:23  * kazuponquit (Remote host closed the connection)
16:18:29  * avalanche123quit (Ping timeout: 255 seconds)
16:20:53  * SergeiRNDquit (Quit: Leaving.)
16:21:13  * SergeiRNDjoined
16:23:19  * kazuponjoined
16:23:27  * dap_joined
16:25:47  * stagasjoined
16:36:11  * Ldxngxquit (Quit: http://www.kiwiirc.com/ - A hand crafted IRC client)
16:39:16  * iarnajoined
16:40:32  * jgijoined
16:40:39  * bajtosjoined
16:41:23  * c4milojoined
16:42:04  * cjihrigquit (Quit: Leaving.)
16:42:45  * cjihrigjoined
16:45:02  * lanceballchanged nick to lance|afk
16:45:02  * SergeiRNDquit (Quit: Leaving.)
16:49:35  * thlorenzquit (Remote host closed the connection)
17:10:41  * kazuponquit (Remote host closed the connection)
17:23:37  * janjongboomjoined
17:23:53  * lance|afkchanged nick to lanceball
17:28:16  * avalanche123joined
17:29:54  * avalanche123quit (Remote host closed the connection)
17:30:19  * avalanche123joined
17:33:52  * jgiquit (Quit: jgi)
17:34:25  * cosnisjoined
17:38:46  * janjongboomquit (Quit: My MacBook has gone to sleep. ZZZzzz…)
17:46:25  * inolenjoined
17:47:19  * dap_quit (Quit: Leaving.)
17:51:21  * daviquit (Ping timeout: 256 seconds)
17:54:12  <trevnorris>tjfontaine: ping
17:54:17  * jgijoined
17:58:31  <creationix>a_le: I don’t think so, but you could easily add one using the libuv thread apis
17:58:58  <a_le>creationix: in reply to the thread-local uv_loop pointer?
17:59:26  <a_le>my most recent question was: can i brutally call uv_close on a tcp handle to drop the connection, no matter what I still have to read and what pending writes have still to be flushed?
18:00:04  <creationix>a_le: sorry, my history seems to be missing some data (I swicth between machines and it confuses my irc bouncer)
18:00:17  <creationix>I’m not sure about stream semantics
18:01:24  * dap_joined
18:01:42  <a_le>creationix: i see
18:02:18  <trevnorris>tjfontaine: I'll be in and out today (wireless card on my laptop died so I'm tethering through my phone). Send me an email of when you'd like to chat online about the AL patch.
18:11:42  * jgiquit (Quit: jgi)
18:13:22  * wolfeidau_joined
18:14:37  * jgijoined
18:16:01  * wolfeidauquit (Ping timeout: 260 seconds)
18:17:28  * thlorenzjoined
18:19:27  * thlorenz_joined
18:20:11  * thlorenzquit (Read error: Connection reset by peer)
18:21:14  * cndjoined
18:25:19  * bajtosquit (Quit: bajtos)
18:25:37  <tjfontaine>trevnorris: ok, just was walking through jgi with some priorities, I have a few tasks to finish up, and then will be doing that after 1pm
18:25:57  * rendarquit (Ping timeout: 246 seconds)
18:27:22  * importantshockquit (Remote host closed the connection)
18:27:56  * importantshockjoined
18:29:54  * cosnisquit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
18:32:22  * importantshockquit (Ping timeout: 245 seconds)
18:32:45  * rendarjoined
18:40:29  * importantshockjoined
18:44:34  * SergeiRNDjoined
18:47:51  * dap_quit (Quit: Leaving.)
18:56:16  * Dijoined
18:57:52  * M28_changed nick to M28
18:58:52  * dap_joined
19:17:34  * avalanche123quit (Remote host closed the connection)
19:18:07  * avalanche123joined
19:19:29  * SergeiRNDquit (Quit: Leaving.)
19:22:41  * avalanche123quit (Ping timeout: 265 seconds)
19:33:00  * kriskowalquit (Quit: kriskowal)
19:34:05  * dap_quit (Quit: Leaving.)
19:36:16  * avalanche123joined
20:02:49  * brsonjoined
20:04:51  * Ldxngxjoined
20:06:05  * avalanche123quit (Remote host closed the connection)
20:06:38  * avalanche123joined
20:06:47  * avalanche123quit (Remote host closed the connection)
20:07:00  * avalanche123joined
20:07:50  * M28quit (Read error: Connection reset by peer)
20:07:59  <tjfontaine>trevnorris: I'm here just finishing up my lunch
20:16:45  * Ldxngxquit (Ping timeout: 265 seconds)
20:22:16  * Ldxngxjoined
20:25:17  * iarnaquit (Remote host closed the connection)
20:31:43  * dap_joined
20:31:44  * Ralithquit (Ping timeout: 265 seconds)
20:35:32  * thlorenz_quit (Remote host closed the connection)
20:40:14  * kriskowaljoined
20:46:40  * dap_quit (Quit: Leaving.)
20:54:57  * AlexisMochaquit (Ping timeout: 256 seconds)
21:01:17  * EhevuTovjoined
21:22:11  * c4miloquit (Remote host closed the connection)
21:25:15  * wolfeidau_changed nick to wolfeidau
21:31:29  * lanceballchanged nick to lance|afk
21:34:14  * dap_joined
21:35:16  * avalanche123quit (Remote host closed the connection)
21:35:50  * avalanche123joined
21:36:02  * avalanche123quit (Remote host closed the connection)
21:36:17  * avalanche123joined
21:39:10  * c4milojoined
21:41:53  * rendarquit
21:47:50  * cjihrigquit (Quit: Leaving.)
21:52:30  * c4miloquit (Remote host closed the connection)
21:52:49  <MI6>joyent/node: Timothy J Fontaine node-review * 54206e3 : Revert "gyp: fix solaris builds, probably?!" - http://git.io/uGjkzw
21:57:03  * stagasquit (Ping timeout: 258 seconds)
21:57:17  * Ralithjoined
22:01:55  <jgi>indutny: Hi!
22:01:59  <jgi>indutny: regarding https://github.com/joyent/node/issues/8615
22:02:06  <indutny>hi
22:02:07  <jgi>indutny: have you tried the reprod?
22:02:10  <jgi>repro
22:02:11  * c4milojoined
22:02:18  <indutny>of course no
22:02:19  <indutny>not yet
22:02:21  <jgi>ok
22:02:24  <indutny>just wanted to get some info first
22:02:31  <indutny>sorry, I'm in the middle of other thing right now
22:02:37  <indutny>so I only did a quick question
22:02:46  <jgi>indutny: sure no problem!
22:04:44  <jgi>indutny: basically, instead of the socket being closed and the client exiting right away, the client hangs for approximately 20 seconds while the connection is not closed, and then exits eventually
22:05:41  <indutny>hm...
22:05:47  <indutny>interesting
22:05:57  <indutny>just a quick check
22:05:58  <indutny>if you have time
22:06:04  <indutny>could you please try this test with this patch https://gist.github.com/indutny/159a035e3cdeb9dcab2e
22:06:18  <indutny>nah
22:06:19  <indutny>it won't help
22:06:23  <jgi>indutny: I updated the issue’s description to hopefully make it clearer
22:06:36  <indutny>so I guess that your test case is somehow closing the original socket
22:06:44  <indutny>not the TLSWrapped one
22:07:23  <tjfontaine>well close/destroy is never hit in the path
22:07:29  <tjfontaine>so neither seems to be finished
22:08:50  <indutny>ah
22:08:55  <indutny>ok
22:08:57  <indutny>different story then
22:09:00  <indutny>I'll look into it later
22:10:25  * sblomquit (Read error: Connection reset by peer)
22:10:53  <tjfontaine>I think I'm going to update configure to only support gcc 4.7 since v8 also only works with vs 2k13
22:11:00  <trevnorris>tjfontaine: sorry about the delay. you still good?
22:11:06  <tjfontaine>at least it's not gcc 4.8
22:11:18  <tjfontaine>trevnorris: I am I did go through in review your patch, did you see the emails?
22:12:33  <trevnorris>tjfontaine: the one where I scared the shit out of you, or another one?
22:18:12  * janjongboomjoined
22:18:52  * brsonquit (Quit: leaving)
22:23:01  <tjfontaine>trevnorris: haha, that one was scary shit -- but I mean the inline commit emails from github
22:23:06  <jgi>indutny: thanks!
22:24:16  <trevnorris>tjfontaine: i'm looking now.
22:24:38  <indutny>jgi: for what? :)
22:25:29  <trevnorris>tjfontaine: ah, ok.
22:25:47  <trevnorris>tjfontaine: as for the commits, it's a total mess. Expect those to be cleaned up. Like, heavily cleaned up.
22:25:51  <jgi>indutny: the fact that you’ll look into the tls issue later
22:25:59  <indutny>ah
22:25:59  <indutny>ok
22:26:04  <tjfontaine>trevnorris: ok
22:26:35  <trevnorris>tjfontaine: re: uint32_t/callback, you mean have the user pass in a JS function and allow them to generate the id?
22:26:46  <tjfontaine>yes
22:27:19  <tjfontaine>I know that some people have expressed (granted painful timing wise) to use a uuid since it's more unique across environments
22:28:06  <trevnorris>since all the id's are generated from C++ it would add an additional 120ns for every instantiation.
22:28:21  <trevnorris>I can think of a few work arounds.
22:29:04  <tjfontaine>the default implementation can stay around, but if they need a way to define their ids and are willing to take that hit
22:29:09  <trevnorris>tjfontaine: well, one more question though. that would only accept a single function right?
22:29:37  <tjfontaine>you mean per node process?
22:29:41  <trevnorris>also, we can change the uint32_t to a int64_t.
22:29:49  <trevnorris>yeah, per Isolate.
22:30:40  <tjfontaine>ya it can only be one per environment, and it's not as much about the potential overflow, it's about the uniqueness of the id
22:31:14  <trevnorris>ok, here are potential solutions:
22:31:52  <trevnorris>1) also allow the user to register a C++ callback, so if they want they can implement it at a lower level. I can then register the default functionality and the user can override that if they want.
22:33:59  <trevnorris>actually. my #2 isn't a good solution. was going to say they can set a value in external memory and we increment off that. but if the user doesn't want to linearly increment it doesn't help.
22:35:22  <tjfontaine>well, 120ns is very small compared to the rest of the async event that's about to take place, and it's completely opt in, and they can use a function pointer wrapped in a js function if that's what they needed to do -- but doing it the other way people who want a pure JS solution aren't able to do that
22:35:33  <trevnorris>tjfontaine: okay, then I can implement both the C++ and JS callbacks. A JS callback will take priority, but if one isn't provided then the C++ one will.
22:35:53  <tjfontaine>what's the straw man for a C++ cb in this mechanism?
22:36:01  <tjfontaine>as instantiated from the Environment?
22:36:52  * kriskowalquit (Ping timeout: 255 seconds)
22:37:43  <trevnorris>yeah. add env->{set_}async_wrap_uid()
22:38:16  <trevnorris>(we can name it whatever. I really don't care.)
22:39:08  * avalanche123quit (Remote host closed the connection)
22:39:52  * rmgquit (Remote host closed the connection)
22:39:55  <trevnorris>additional APIs would be env->has_async_wrap_uid_js_callback() (wow that's long), env->set_async_wrap_uid_js_callback(Local<Function>)
22:40:18  <trevnorris>then the call to async_wrap_uid() would transparently call either the JS or C++ callback, depending on what the user has set.
22:42:14  * avalanche123joined
22:42:17  <trevnorris>tjfontaine: that sound okay?
22:42:27  * avalanch_joined
22:43:22  * Ralithquit (*.net *.split)
22:43:23  * importantshockquit (*.net *.split)
22:43:23  * hayesquit (*.net *.split)
22:43:23  * hueniversequit (*.net *.split)
22:43:51  * Ralithjoined
22:44:07  * importantshockjoined
22:46:02  * hueniversejoined
22:46:35  * avalanche123quit (Ping timeout: 256 seconds)
22:46:39  * chris_99quit (Ping timeout: 265 seconds)
22:51:51  * hayesjoined
22:54:06  * M28joined
22:54:28  * swajjoined
22:54:50  <tjfontaine>trevnorris: yes, that's along the lines of what I was thinking
22:55:05  * octetcloudquit (Ping timeout: 244 seconds)
22:55:13  <trevnorris>tjfontaine: awesome. then I'll get to work on that.
22:56:02  <tjfontaine>thanks
22:57:11  <trevnorris>tjfontaine: one more thing, i'd like to add asyncId() to timers. it can be done at practically zero additional cost (minus execution time of the users callback). that cool w/ you?
22:57:14  <MI6>joyent/node: Timothy J Fontaine node-review * f7147bc : configure: require > 4.7.0 if using GCC - http://git.io/0lV87A
22:57:49  <tjfontaine>trevnorris: well, I'm not sure what storage looks like there, or the interface really
22:58:24  <trevnorris>it would just be part of the return object (since we return the request object anyways). so it'd be like setTimeout(function() { }).asyncId();
22:58:51  <tjfontaine>a getter is too expensive I suppose
22:59:17  <tjfontaine>is that only bringing back the asyncId for the base TimerWrap?
22:59:31  <tjfontaine>I guess make a commit with that change so I can review it more concretely
23:00:00  <trevnorris>ok
23:00:51  <trevnorris>since timer object have no C++ counterpart it'd just have to be stored like _asyncId.
23:01:07  <trevnorris>just realized that.
23:01:29  <tjfontaine>right that's my point, also the callbacks etc have to be managed by the external module
23:01:34  <tjfontaine>since we're removing the js api
23:01:49  <tjfontaine>so I would advocate a getter off process.binding('async_listener') that lets you get the next id
23:02:19  <tjfontaine>then someone who adds AL JS api externally can get the next id and attach it how they need to
23:02:26  <tjfontaine>same for nextTick's
23:02:29  <tjfontaine>etc etc
23:02:49  <trevnorris>yeah, that sounds about right.
23:03:33  <trevnorris>the default implementation would just use the external memory on object trick to make the call practically free, then if the user defines a callback they're already okay w/ a perf hit.
23:04:00  <trevnorris>and, _if_ it needs to call into C++, the overhead is less than 20ns. so that doesn't worry me much.
23:04:09  * seishunquit (Ping timeout: 256 seconds)
23:04:33  <trevnorris>the JS calls are what I'd worry most about. especially for nextTick().
23:06:37  * toothrotjoined
23:07:24  * petka_joined
23:08:03  <trevnorris>tjfontaine: one final thing, this is already happening in most places, but i'd like to standardize that the context for all callbacks is the request/handle object created.
23:09:54  <tjfontaine>trevnorris: ya I commented on that makeCallback for fs, right?
23:11:18  <trevnorris>tjfontaine: ah freak. you left a lot more comments then what github is showing me...
23:11:22  <trevnorris>ok, reading over all those now.
23:12:53  <tjfontaine>I was reading the commits in order, so some of them are superceded
23:13:03  * tarrudajoined
23:14:26  <trevnorris>got it
23:15:43  * chris_99joined
23:16:51  * pgicxplzsjoined
23:19:14  <MI6>joyent/node: Timothy J Fontaine node-review * 293f036 : configure: require > 4.7.0 if using GCC - http://git.io/ZkfsGA
23:19:49  * warehouse13quit (Ping timeout: 260 seconds)
23:19:50  <tjfontaine>bah
23:20:21  * c4miloquit (Remote host closed the connection)
23:23:09  * kriskowaljoined
23:29:20  * EhevuTovquit (Quit: This computer has gone to sleep)
23:31:43  <trevnorris>tjfontaine: thanks for the review. i'm just going to continue piling on the commits until everyone is okay on the changes.
23:31:58  <trevnorris>then i'll cleanup the commits and have you check those out.
23:40:21  * rmgjoined
23:40:42  <tjfontaine>trevnorris: thanks, send me an out of band email when that happens
23:40:52  <trevnorris>tjfontaine: will do.
23:46:06  * rmgquit (Ping timeout: 265 seconds)