00:00:00  * ircretaryquit (Remote host closed the connection)
00:00:08  * ircretaryjoined
00:00:34  * jonaslundpart
00:02:47  * inolenquit (Ping timeout: 244 seconds)
00:09:57  * brsonquit (Ping timeout: 246 seconds)
00:10:34  * brsonjoined
00:11:48  * benjamingrjoined
00:11:53  * warehouse13joined
00:14:24  * Left_Turnquit (Ping timeout: 256 seconds)
00:22:12  * stagasjoined
00:34:31  * brsonquit (Quit: leaving)
00:35:14  * qardquit (Quit: leaving)
00:36:44  * brsonjoined
00:40:41  * thlorenz_joined
00:45:09  * thlorenz_quit (Ping timeout: 244 seconds)
00:46:02  * stagasquit (Ping timeout: 246 seconds)
00:48:09  * pgicxplzsjoined
00:50:58  * warehouse13quit (Ping timeout: 255 seconds)
00:59:32  * pgicxplzsquit (Remote host closed the connection)
00:59:54  * brsonquit (Quit: leaving)
01:13:13  * jgijoined
01:20:06  * Left_Turnjoined
01:25:31  * brsonjoined
01:34:43  * Jacob8432joined
01:38:16  * Jacob843quit (Ping timeout: 256 seconds)
01:41:29  * thlorenz_joined
01:46:12  * thlorenz_quit (Ping timeout: 256 seconds)
02:14:13  * jgiquit (Quit: jgi)
02:14:39  * jgijoined
02:15:47  * jgiquit (Client Quit)
02:30:14  * jgijoined
02:35:10  * jgiquit (Quit: jgi)
02:40:55  * jgijoined
02:42:17  * thlorenz_joined
02:42:32  * rmgjoined
02:46:47  * jgiquit (Quit: jgi)
02:46:59  * thlorenz_quit (Ping timeout: 256 seconds)
02:47:12  * Jacob8432quit (Quit: Leaving)
02:47:28  * rmgquit (Ping timeout: 272 seconds)
02:47:30  * Jacob843joined
02:55:40  * brsonquit (Quit: leaving)
02:56:09  * inolenjoined
02:58:12  * Left_Turnquit (Remote host closed the connection)
03:21:34  * jgijoined
03:21:52  * WalrusPonyquit (Ping timeout: 240 seconds)
03:22:29  * WalrusPonyjoined
03:28:50  * jgiquit (Quit: jgi)
03:29:15  * jgijoined
03:32:51  * jgiquit (Client Quit)
03:33:37  * jgijoined
03:43:06  * thlorenz_joined
03:47:20  * thlorenz_quit (Ping timeout: 246 seconds)
04:13:22  * SplinterOfChaosquit (Ping timeout: 240 seconds)
04:17:19  * jgiquit (Quit: jgi)
04:28:09  * jgijoined
04:40:41  * jgiquit (Quit: jgi)
04:41:47  * petka__quit (Quit: Connection closed for inactivity)
04:43:57  * thlorenz_joined
04:45:23  * avalanche123joined
04:45:25  * inolenquit (Ping timeout: 265 seconds)
04:46:57  * jgijoined
04:48:48  * thlorenz_quit (Ping timeout: 265 seconds)
05:00:06  * jgiquit (Quit: jgi)
05:02:49  * jgijoined
05:03:01  * SplinterOfChaosjoined
05:10:07  * AvianFluquit (Remote host closed the connection)
05:10:40  * jgiquit (Quit: jgi)
05:14:36  * jgijoined
05:16:33  * jgiquit (Client Quit)
05:39:30  * avalanche123quit (Remote host closed the connection)
05:39:40  * avalanche123joined
05:44:44  * thlorenz_joined
05:49:40  * avalanche123quit (Remote host closed the connection)
05:49:52  * thlorenz_quit (Ping timeout: 272 seconds)
05:58:35  * jgijoined
06:10:42  * inolenjoined
06:20:50  * seishunjoined
06:42:27  * bajtosjoined
06:44:56  * stagasjoined
06:45:37  * thlorenz_joined
06:50:24  * thlorenz_quit (Ping timeout: 264 seconds)
06:56:12  * jgiquit (Quit: jgi)
07:09:16  * bajtosquit (Quit: bajtos)
07:11:11  * a3fjoined
07:11:33  * jgijoined
07:23:36  * jgiquit (Quit: jgi)
07:29:35  * seishunquit (Ping timeout: 246 seconds)
07:39:17  * bajtosjoined
07:46:26  * thlorenz_joined
07:49:06  * rmgjoined
07:51:28  * thlorenz_quit (Ping timeout: 272 seconds)
08:23:03  * bajtosquit (Quit: bajtos)
08:25:00  * bajtosjoined
08:25:46  * stagasquit (Ping timeout: 250 seconds)
08:34:06  * a3fquit (Ping timeout: 252 seconds)
08:47:12  * thlorenz_joined
08:51:26  * thlorenz_quit (Ping timeout: 246 seconds)
08:53:13  * imzyxwvujoined
08:56:28  * bajtosquit (Ping timeout: 252 seconds)
09:12:38  * bajtosjoined
09:24:17  * kellabytequit (Quit: Connection closed for inactivity)
09:29:56  * imzyxwvuquit (Ping timeout: 246 seconds)
09:31:12  * imzyxwvujoined
09:34:50  * chris_99joined
09:48:03  * thlorenz_joined
09:49:53  * Left_Turnjoined
09:52:18  * thlorenz_quit (Ping timeout: 244 seconds)
09:52:30  * bajtosquit (Quit: bajtos)
09:58:44  * bajtosjoined
10:01:31  * bajtosquit (Client Quit)
10:10:39  * a3fjoined
10:40:07  * WalrusPony1joined
10:40:59  * imzyxwvuquit (Ping timeout: 246 seconds)
10:42:16  * WalrusPonyquit (Ping timeout: 250 seconds)
10:48:51  * thlorenz_joined
10:53:17  * thlorenz_quit (Ping timeout: 252 seconds)
10:57:32  * rmgquit (Remote host closed the connection)
11:35:29  * bajtosjoined
11:37:32  * saghul_joined
11:49:37  * thlorenz_joined
11:52:42  * SergeiRNDjoined
11:53:50  * thlorenz_quit (Ping timeout: 246 seconds)
11:58:30  * rmgjoined
12:00:11  * SergeiRNDquit (Quit: Leaving.)
12:03:01  * rmgquit (Ping timeout: 244 seconds)
12:06:23  * kellabytejoined
12:17:17  * AlexisMochajoined
12:18:20  * bajtosquit (Quit: bajtos)
12:19:15  * bajtosjoined
12:20:43  * a3f_joined
12:22:48  * a3fquit (Ping timeout: 250 seconds)
12:32:02  * chris_99quit (Quit: Ex-Chat)
12:32:50  * SergeiRNDjoined
12:37:48  * chris_99joined
12:45:20  * AnxiousGarlicjoined
12:45:21  * AnxiousGarlicpart
12:47:22  * a3f_changed nick to a3f
12:50:01  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
12:50:25  * thlorenz_joined
12:54:52  * thlorenz_quit (Ping timeout: 245 seconds)
12:56:43  * bajtosquit (Quit: bajtos)
12:58:55  * bajtosjoined
12:59:10  * bajtosquit (Client Quit)
13:13:06  * imzyxwvujoined
13:19:36  * AlexisMochaquit (Read error: Connection reset by peer)
13:22:38  * rjequit (Ping timeout: 256 seconds)
13:28:01  * rjejoined
13:38:24  * saghul_joined
13:51:14  * thlorenz_joined
13:55:48  * thlorenz_quit (Ping timeout: 264 seconds)
14:08:25  * AvianFlujoined
14:14:55  * rmgjoined
14:19:23  * rmgquit (Ping timeout: 246 seconds)
14:40:54  * SergeiRNDquit (Quit: Leaving.)
14:42:32  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
14:52:04  * thlorenz_joined
14:54:17  * kellabytequit (Quit: Connection closed for inactivity)
14:56:29  * thlorenz_quit (Ping timeout: 246 seconds)
15:10:51  * petka__joined
15:11:29  * saghul_joined
15:13:39  * imzyxwvuquit (Ping timeout: 246 seconds)
15:16:25  * bajtosjoined
15:29:16  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
15:32:05  * dan336joined
15:34:12  * Fishrock123joined
15:52:06  * kellabytejoined
15:52:54  * thlorenz_joined
15:54:46  * bajtosquit (Quit: bajtos)
15:56:22  * bajtosjoined
15:57:22  * thlorenz_quit (Ping timeout: 245 seconds)
16:11:27  * rmgjoined
16:13:08  * bajtosquit (Quit: bajtos)
16:13:24  * bajtosjoined
16:18:46  * bajtosquit (Ping timeout: 272 seconds)
16:33:46  * seishunjoined
16:33:51  * bajtosjoined
16:35:11  * brsonjoined
16:35:33  * reqsharkjoined
16:51:42  * lanceballchanged nick to lance|afk
16:53:43  * thlorenz_joined
16:55:52  * inolenquit (Quit: Leaving.)
16:58:22  * thlorenz_quit (Ping timeout: 240 seconds)
17:17:15  * benjamingrquit (Quit: Connection closed for inactivity)
17:19:46  * jgijoined
17:22:26  * octetclo1joined
17:25:44  * dap_joined
17:25:54  * gnosticationjoined
17:26:25  * bajtosquit (Quit: bajtos)
17:29:48  * zju4quit (Read error: Connection reset by peer)
17:31:25  <jgi>robertkowalski: hi!
17:32:34  * lance|afkchanged nick to lanceball
17:36:16  * Ralithquit (Ping timeout: 255 seconds)
17:42:22  * dan336part
17:54:42  * thlorenz_joined
17:59:02  * thlorenz_quit (Ping timeout: 245 seconds)
18:02:07  * inolenjoined
18:07:51  * avalanche123joined
18:17:09  * zju4joined
18:17:56  * SergeiRNDjoined
18:22:10  <jgi>cjihrig: hello!
18:22:37  <cjihrig>jgi: hi
18:24:05  <jgi>cjihrig: regarding https://github.com/joyent/node/pull/9268, I’m wondering if we should first test for the accepted types (undefined, string and number) here: https://github.com/joyent/node/pull/9268/files#diff-e6ef024c3775d787c38487a6309e491dR914 and throw a TypeError, and only then test for the non-negativity and <= 65535 and throw a RangeError
18:24:17  <jgi>cjihrig: otherwise we may throw a TypeError when it’s really a RangeError
18:25:29  <jgi>cjihrig: and the error messages for each error would be clearer too
18:26:33  <cjihrig>jgi: yea. the only problem with that would be negative hex strings again :-)
18:26:53  <trevnorris>morngin
18:27:10  <cjihrig>morning trevnorris
18:27:48  <jgi>cjihrig: in the case of a negative hex string, the first type check would pass (it’s a string), but the range check would fail, and thus a RangeError would be thrown
18:27:56  <jgi>cjihrig: I think that makes sense
18:28:01  <jgi>trevnorris: good morning!
18:28:07  <cjihrig>jgi: ok. i'll update again
18:28:32  <cjihrig>jgi: wait
18:28:45  <jgi>cjihrig: it’s just a suggestion though, I haven’t written the corresponding code or ran tests
18:29:17  <jgi>cjihrig: and I think we may want to add a test for the negative hex string case
18:34:54  * a3fquit (Ping timeout: 246 seconds)
18:38:48  * Ralithjoined
18:49:29  <cjihrig>jgi: updated the PR. i didn't add a test for negative hex strings because they throw the incorrect error. i'm willing to take a TypeError instead of a RangeError in that case because 1 - it still throws and 2 - no one is going to pass in a negative hex string
18:55:19  * thlorenz_joined
18:59:51  * thlorenz_quit (Ping timeout: 252 seconds)
19:03:49  <jgi>cjihrig: thanks! I’ll take a look shortly.
19:08:22  * benjamingrjoined
19:23:27  * othiym42joined
19:28:14  * hueniversejoined
19:38:00  * SergeiRNDquit (Quit: Leaving.)
19:56:05  * thlorenz_joined
20:00:43  * thlorenz_quit (Ping timeout: 255 seconds)
20:12:27  * stagasjoined
20:21:30  * inolenquit (Quit: Leaving.)
20:25:14  * inolenjoined
20:33:36  * saghul_joined
20:33:36  * a3fjoined
20:37:16  * reqsharkquit (Ping timeout: 256 seconds)
20:38:56  * inolenquit (Quit: Leaving.)
20:39:34  * inolenjoined
20:56:58  * thlorenz_joined
21:01:32  * thlorenz_quit (Ping timeout: 245 seconds)
21:11:26  * jgiquit (Quit: jgi)
21:14:56  * reqsharkjoined
21:17:28  * reqsharkquit (Client Quit)
21:28:55  * chris_99quit (Remote host closed the connection)
21:29:36  * chris_99joined
21:33:19  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
21:35:32  * lanceballchanged nick to lance|afk
21:36:42  * ijrothjoined
21:37:25  * ijrothquit (Client Quit)
21:41:37  * jgijoined
21:42:22  * seishunquit (Ping timeout: 240 seconds)
21:43:36  * stagas_joined
21:45:18  * stagasquit (Ping timeout: 246 seconds)
21:45:31  * stagas_changed nick to stagas
21:50:11  * qardjoined
21:52:01  * Tux64_joined
21:52:58  * avalanche123quit (Remote host closed the connection)
21:53:32  * chris_99quit (Quit: Ex-Chat)
21:57:46  * thlorenz_joined
22:02:13  * thlorenz_quit (Ping timeout: 255 seconds)
22:02:56  * avalanche123joined
22:14:26  * avalanche123quit (Remote host closed the connection)
22:19:28  <robertkowalski>jgi: tjfontaine i would deploy a new nginx config in a few minutes, is that ok?
22:20:12  <robertkowalski>change is https://github.com/joyent/node-website/pull/83/files
22:25:20  <jgi>robertkowalski: looks good to me, although I don’t have much experience with nginx configuration files
22:25:36  <jgi>robertkowalski: also, I guess that if anything goes wrong, it’s easy to roll back
22:26:40  <jgi>robertkowalski: I see you ran tests with curl, is it possible to make nvm point to your dev environment to test that nvm is not broken?
22:31:46  * avalanche123joined
22:31:54  <robertkowalski>jgi: probably, but i am not really hosting anything there, just testing if nginx sends me location-headers or not
22:36:10  <jgi>robertkowalski: right, it would help to have an actual dev environment to test that type of changes
22:37:15  <jgi>robertkowalski: I don’t know in details how nvm, node-gyp and travis work. Are you confident that these tools would not be broken?
22:38:22  * stagasquit (Ping timeout: 240 seconds)
22:40:56  <robertkowalski>nvm already uses the https site: https://github.com/creationix/nvm/blob/ceb66d13560cb222751747d887ccc48700275cc1/nvm.sh#L80 and node-gyp is using the old http website: https://github.com/TooTallNate/node-gyp/blob/ccf27bf13cf53973034af6002edcb76ede0bc7ec/lib/install.js#L42
22:41:50  <robertkowalski>i am quite confident they won't break as i did not change anything for /dist
22:42:34  <robertkowalski>i can try to build a dev environment and test node-gyp
22:42:38  <jgi>robertkowalski: ok, then please deploy, but it would be great to have tests for nvm, node-gyp and travis prepared to be run right after the deployement is done
22:43:02  <jgi>robertkowalski: yes, ideally, we would setup a dev environment
22:44:08  <jgi>robertkowalski: how much work do you think would be needed to setup a dev environment?
22:44:54  <jgi>cjihrig: did you see this comment: https://github.com/joyent/node/pull/9268#discussion_r25538397?
22:45:14  <robertkowalski>i have to scp the contents of dist and make them available via nginx, then starting pass the new address to node-gyp
22:45:58  <robertkowalski>jgi: in general, the easiest way for all contributors would be to have a staging which is a mirror of the production env
22:46:20  <cjihrig>jgi: i don't think it makes a lot of sense to specify that something optional can be undefined
22:46:26  <robertkowalski>e.g. staging.nodejs.org
22:46:59  <jgi>robertkowalski: yes, that seems like it would be handy
22:48:16  <robertkowalski>i'm not going to deploy today then, don't know when i have time to run all those tests
22:48:21  <jgi>cjihrig: yes, mentioning that it can be undefined is probably not very useful, but mentioning that it must _represent_ a number, as opposed to only be of type number is useful in my opinion
22:49:00  <jgi>cjihrig: otherwise the message is not consistent with what is supported by the API
22:49:55  <jgi>robertkowalski: I would rather deploy later but be confident that it won’t break anything than deploy now and take the risk of breaking a lot of users
22:52:33  * Jacob8432joined
22:53:04  <robertkowalski>jgi i am quite sure nothing breaks as my curl tests did not return a 302 redirect for /dist but i can't prove it using node-gyp
22:53:42  * Tux64_changed nick to Tux64
22:56:18  * Jacob843quit (Ping timeout: 265 seconds)
22:58:33  * thlorenz_joined
22:58:57  <jgi>robertkowalski: do we have a test (even a manual one) that we can run right after deploying this change to check that node-gyp and travis are not broken?
22:59:34  <jgi>robertkowalski: it can be a command line that installs (and builds) a native module via npm and a dummy project that uses travis ci to run one test
23:02:41  * thlorenz_quit (Ping timeout: 246 seconds)
23:20:49  * Jacob8432quit (Quit: Leaving)
23:21:13  * Jacob843joined
23:28:44  * avalanche123quit (Remote host closed the connection)
23:31:03  * avalanche123joined
23:35:37  <cjihrig>jgi: i'd be more comfortable saying a number or numeric string
23:35:52  <jgi>cjihrig: yes, that works for me too :)
23:38:15  <jgi>cjihrig: another concern I had is that actually parseFloat doesn’t handle hexadecimal strings at all, for instance parseFloat(‘0xff’) === 0. In the current state of the PR, it works out correctly, but because we’re lucky.
23:38:55  <jgi>cjihrig: it seems to me that your original method (comparing coercion to int’s result with parseInt’s output) would be more robust and consistent
23:39:19  <jgi>cjihrig: something closer to what I had in this gist: https://gist.github.com/misterdjules/741cb578638b18f139ef
23:39:25  <jgi>cjihrig: what do you think?
23:46:36  * avalanch_joined
23:49:18  * avalanche123quit (Ping timeout: 252 seconds)
23:59:22  * thlorenz_joined