00:00:00  * ircretaryquit (Remote host closed the connection)
00:00:08  * ircretaryjoined
01:17:33  * jgijoined
01:35:59  * tylerantonjoined
01:36:42  <tyleranton>jgi: I squashed those two commits, is there any other step I need to take before creating a PR?
01:37:45  <jgi>tyleranton: no, you should be good to go. If there’s anything that we need to change after the review (e.g the commit message or the changes themselves) you’ll be able to do that in the same PR.
01:38:21  <tyleranton>jgi: Alright, great. I’ll create it then.
01:39:50  <tyleranton>jgi: The commits aren’t squashed on GitHub
01:40:23  <jgi>tyleranton: let me take a look
01:40:48  <jgi>tyleranton: did you push after squashing them?
01:42:02  <tyleranton>jgi: Ah, I didn’t since there weren’t any changes to commit. I’m assuming I need to do so regardless?
01:43:01  <jgi>tyleranton: yes, you need to push the new tree to your remote so that github gets the tree with the one squashed commit
01:44:36  <jgi>tyleranton: you’ll need to force push too, by using git push -f your_remote fix-issue-9313
01:44:50  <tyleranton>jgi: Alright, my bad. Pushing without changes didn’t register in my head ha. I’ll do it real quick.
01:44:58  <jgi>tyleranton: no worries :)
01:45:29  <tyleranton>jgi: and it’s done!
01:46:27  <jgi>tyleranton: great, thank you! I’ll review it soon and it should land tonight or tomorrow.
01:46:37  <jgi>tyleranton: if I have any question I’ll comment in the pull request.
01:47:12  <tyleranton>jgi: awesome, thanks! happy to contribute. see ya o/
01:47:13  <jgi>tyleranton: if you’re interested in picking up other bugs/issues to fix, let me know and I can probably find a few :)
01:47:19  <tyleranton>jgi: yea for sure
01:48:24  <tyleranton>jgi: I’ve been super interested in contributing to open source and finally decided to do it with node since I’ve been using/learning it.
01:48:54  <jgi>tyleranton: that’s great, and we are certainly happy to have you contribute to the project :)
01:49:29  <jgi>tyleranton: there are some issues in the issues tracker labeled with the “easy” label (which really means “great-for-first-contributions”)
01:50:10  <jgi>tyleranton: they’re not all up to date, but this one could be a good candidate: https://github.com/joyent/node/issues/8776
01:50:47  <jgi>tyleranton: still in the documentation, I’ll find you some others that involve bug fixes in the implementation of node itself
01:50:48  <tyleranton>jgi: Awesome! I’ll take a look.
01:51:37  <jgi>tyleranton: if/when you find something you’d like to work on, mention @joyent/node-core-team and/or @misterdjules, and say that you’d like to pick this issue
01:51:50  <jgi>tyleranton: and we’ll be able to provide you with some guidance
01:51:55  <tyleranton>jgi: Looks like this one has a PR already attached to it.
01:52:06  <tyleranton>jgi: Will do! Definitely looking forward to contributing more
01:52:28  <jgi>tyleranton: ah you’re right for 8776!
01:52:59  <jgi>I need to tag more issues :)
01:53:46  <tyleranton>jgi: All good :)
02:12:57  * jasnelljoined
02:37:06  * avalanche123joined
02:42:34  * avalanche123quit (Ping timeout: 255 seconds)
02:47:37  * jgiquit (Quit: jgi)
02:50:26  * wolfeidaujoined
02:54:44  * tylerantonquit (Quit: tyleranton)
02:58:37  * jasnellquit (Remote host closed the connection)
03:28:28  * inolenquit (Ping timeout: 255 seconds)
03:37:20  * Left_Turnquit (Remote host closed the connection)
03:40:07  * avalanche123joined
03:45:47  * avalanche123quit (Ping timeout: 252 seconds)
04:10:17  * avalanche123joined
04:26:39  * rmgjoined
04:29:31  * toothrotquit (Ping timeout: 264 seconds)
04:31:28  * rmgquit (Ping timeout: 272 seconds)
04:34:03  * AvianFluquit (Remote host closed the connection)
04:43:29  * avalanche123quit (Remote host closed the connection)
04:48:08  * jgijoined
04:57:17  * Ralithquit (Ping timeout: 252 seconds)
04:58:04  * avalanche123joined
05:02:34  * avalanche123quit (Ping timeout: 252 seconds)
05:18:15  * Ralithjoined
05:20:31  * felipealmeidaquit (Ping timeout: 255 seconds)
05:26:31  * felipealmeidajoined
06:39:50  * isaacsquit (Remote host closed the connection)
06:59:30  * jgiquit (Quit: jgi)
07:21:00  * importantshockquit (Remote host closed the connection)
07:21:33  * importantshockjoined
07:26:31  * importantshockquit (Ping timeout: 264 seconds)
07:49:50  * avalanche123joined
07:54:58  * avalanche123quit (Ping timeout: 256 seconds)
08:16:34  * roxlujoined
08:25:39  * saghuljoined
08:26:08  <saghul>creationix: can you point me to the issue again, I just remember it vaguely
09:00:26  * jasnelljoined
09:04:02  * niskaquit (*.net *.split)
09:04:53  * jasnellquit (Ping timeout: 265 seconds)
09:05:06  * niskajoined
10:08:58  * benjamingrjoined
10:41:23  * chris_99joined
10:45:50  * Jacob843quit (Read error: Connection reset by peer)
10:46:12  * Jacob843joined
10:50:21  * zjujoined
10:51:11  * zju3joined
10:52:19  * zju4quit (Ping timeout: 245 seconds)
10:53:29  * zju1quit (Ping timeout: 250 seconds)
11:08:36  * rmgjoined
11:12:53  * rmgquit (Ping timeout: 246 seconds)
11:13:11  * Left_Turnjoined
11:28:12  * avalanche123joined
11:32:29  * avalanche123quit (Ping timeout: 246 seconds)
11:43:52  * Left_Turnquit (Ping timeout: 240 seconds)
12:16:09  * tarrudajoined
12:19:39  * zju4joined
12:23:32  * zjuquit (Ping timeout: 264 seconds)
12:44:26  * mohammed__joined
12:47:08  * mohammed__part ("Leaving")
12:47:38  * Left_Turnjoined
13:08:15  * roxluquit (Quit: My Mac has gone to sleep. ZZZzzz…)
13:10:05  * roxlujoined
13:12:17  * lance|afkchanged nick to lanceball
13:32:38  * reqsharkquit (Quit: Be back later ...)
13:37:17  * benjamingrquit (Quit: Connection closed for inactivity)
13:40:08  * thlorenz_joined
13:45:05  * thlorenz_quit (Ping timeout: 250 seconds)
14:05:49  * thlorenz_joined
14:09:02  * felipealmeidaquit (Ping timeout: 245 seconds)
14:18:37  * Fishrock123joined
14:21:48  * reqsharkjoined
14:31:56  * tarrudaquit (Ping timeout: 264 seconds)
14:47:06  * felipealmeidajoined
14:48:46  * tarrudajoined
14:49:00  * tarrudachanged nick to Guest7713
14:49:04  * Guest7713quit (Client Quit)
15:05:16  * avalanche123joined
15:08:31  * brsonjoined
15:09:34  * avalanche123quit (Ping timeout: 255 seconds)
16:00:50  * octetcloudjoined
16:04:57  * seishunjoined
16:05:48  * rmgjoined
16:10:10  * jgijoined
16:19:59  * jgiquit (Quit: jgi)
16:52:12  * jgijoined
16:54:32  * bajtosjoined
17:01:49  * rendarjoined
17:05:12  * AvianFlujoined
17:05:45  * avalanche123joined
17:06:32  * saghul_joined
17:26:27  * thlorenz_quit (Remote host closed the connection)
17:32:27  * roxluquit (Quit: My Mac has gone to sleep. ZZZzzz…)
17:44:30  * roxlujoined
17:51:42  * olfoxjoined
17:55:48  * avalanche123quit (Remote host closed the connection)
17:59:44  * avalanche123joined
18:05:17  * thlorenz_joined
18:18:31  * inolenjoined
18:19:07  * roxluquit (Quit: My Mac has gone to sleep. ZZZzzz…)
18:32:49  * SergeiRNDjoined
18:38:04  * lanceballchanged nick to lance|afk
18:43:19  * dap_joined
18:43:25  * saghul_quit (Quit: My MacBook Pro has gone to sleep. ZZZzzz…)
18:51:26  * SergeiRND1joined
18:51:42  * SergeiRNDquit (Read error: Connection reset by peer)
18:57:14  * octetcloudquit (Ping timeout: 272 seconds)
19:05:47  * octetcloudjoined
19:06:13  * roxlujoined
19:10:53  * felipealmeidaquit (Ping timeout: 252 seconds)
19:11:35  * bajtosquit (Quit: bajtos)
19:17:00  * felipealmeidajoined
19:17:42  * lance|afkquit (Ping timeout: 240 seconds)
19:20:35  * lanceballjoined
19:35:58  * brsonquit (Ping timeout: 252 seconds)
19:38:51  * avalanche123quit (Remote host closed the connection)
19:40:56  * avalanche123joined
19:56:05  * jgiquit (Quit: jgi)
19:56:25  * SergeiRND1quit (Read error: Connection reset by peer)
19:57:01  * SergeiRNDjoined
19:57:48  * brsonjoined
20:01:16  * Damn3dquit (Ping timeout: 252 seconds)
20:02:02  * Damn3djoined
20:09:34  * jgijoined
20:19:16  * jgiquit (Quit: jgi)
20:19:24  * avalanche123quit (Remote host closed the connection)
20:20:47  * avalanche123joined
20:25:17  * lanceballquit (Changing host)
20:25:17  * lanceballjoined
20:30:35  * avalanche123quit (Remote host closed the connection)
20:41:07  * jgijoined
20:41:34  * avalanche123joined
20:44:48  * SergeiRNDquit (Read error: Connection reset by peer)
20:44:58  * SergeiRNDjoined
20:53:13  * SergeiRNDquit (Quit: Leaving.)
21:02:04  * rendarquit (Ping timeout: 256 seconds)
21:07:40  * rendarjoined
21:17:54  * seishunquit (Ping timeout: 252 seconds)
21:22:42  <MI6>joyent/node: Julien Gilli refs/tags/jenkins-accept-pull-request-temp * 3c830c8 : deps: fix libuv build on SmartOS - http://git.io/xSy7
21:23:18  <MI6>joyent/node: Julien Gilli refs/tags/jenkins-accept-commit-temp * f57e413 : deps: fix libuv build on SmartOS (+4 more commits) - http://git.io/pWMa
21:35:46  * thlorenz_quit (Remote host closed the connection)
21:39:09  * reqsharkquit (Ping timeout: 250 seconds)
21:51:11  * piscisaureusjoined
22:08:03  * lanceballchanged nick to lance|afk
22:21:36  * Fishrock123quit (Quit: Leaving...)
22:36:32  * thlorenz_joined
22:40:56  * thlorenz_quit (Ping timeout: 246 seconds)
22:42:59  * chris_99quit (Quit: Ex-Chat)
22:56:44  * roxluquit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:57:58  * avalanche123quit
23:00:03  * avalanche123joined
23:11:04  * yunong_quit
23:13:19  * yunongjoined
23:28:17  * toothrotjoined
23:38:10  * jgiquit (Quit: jgi)
23:44:24  * jgijoined
23:55:25  * octetcloudquit (Ping timeout: 252 seconds)