00:00:00  * ircretaryquit (Remote host closed the connection)
00:00:08  * ircretaryjoined
00:07:57  * chris_99quit (Remote host closed the connection)
00:29:17  * qardquit (Quit: (ノಠ益ಠ)ノ彡┻━┻)
00:47:10  * alexforsterquit
00:59:36  * dap_quit (Quit: Leaving.)
01:01:22  * abraxas_joined
01:03:37  * benjamingrquit (Quit: Connection closed for inactivity)
01:06:08  * abraxas_quit (Ping timeout: 252 seconds)
01:14:17  * jasnelljoined
01:27:28  * jgiquit (Quit: jgi)
01:41:55  * tarrudajoined
01:43:10  * dsantiagoquit (Quit: Computer has gone to sleep.)
01:44:50  * rmgquit (Remote host closed the connection)
01:50:38  * tunniclmquit (Ping timeout: 264 seconds)
01:52:20  * normanmquit (Ping timeout: 252 seconds)
01:55:11  * jasnellquit (Remote host closed the connection)
01:55:44  * jasnelljoined
01:56:04  * abraxas_joined
01:58:36  * normanmjoined
02:00:25  * jasnellquit (Ping timeout: 264 seconds)
02:04:10  * dsantiagojoined
02:08:43  * alexforsterjoined
02:25:30  * alexforsterquit
02:31:37  * abraxas_quit (Remote host closed the connection)
03:01:17  * abraxas_joined
03:05:30  * jasnelljoined
03:19:58  * kevinswiberquit (Ping timeout: 276 seconds)
03:38:21  * reqsharkjoined
03:45:01  * jasnellquit (Remote host closed the connection)
03:45:45  * jasnelljoined
04:12:50  * jasnellquit (Remote host closed the connection)
04:13:23  * jasnelljoined
04:17:58  * jasnellquit (Ping timeout: 272 seconds)
04:25:33  * s3shsjoined
05:05:40  * jgijoined
05:15:52  * seishunjoined
05:18:28  * jgiquit (Quit: jgi)
05:20:07  * jgijoined
06:08:29  * jgiquit (Quit: jgi)
06:18:36  * rendarjoined
06:37:39  * seishunquit (Ping timeout: 246 seconds)
06:37:59  * inolenquit (Ping timeout: 265 seconds)
07:24:21  * rmgjoined
07:25:37  * warehouse13joined
07:28:15  * Left_Turnquit (Ping timeout: 248 seconds)
07:29:13  * rmgquit (Ping timeout: 264 seconds)
07:30:36  * Ralithquit (Ping timeout: 252 seconds)
07:32:36  * Ralithjoined
07:50:08  * inolenjoined
08:21:44  * brrtjoined
08:30:43  * SergeiRNDjoined
08:47:22  * benjamingrjoined
09:15:36  * joaocgreisjoined
09:26:54  * AlexisMochajoined
09:33:03  * brrtpart ("Good Bye")
10:15:47  * zju4joined
10:17:55  * zju1joined
10:18:00  * zjuquit (Ping timeout: 244 seconds)
10:18:05  * zju3quit (Ping timeout: 250 seconds)
11:13:07  * SergeiRNDquit (Quit: Leaving.)
11:19:38  * SergeiRNDjoined
11:22:01  * SergeiRNDquit (Client Quit)
11:31:37  * SergeiRNDjoined
11:33:38  * chris_99joined
11:33:44  * chris_99quit (Changing host)
11:33:44  * chris_99joined
11:35:53  * SergeiRNDquit (Ping timeout: 246 seconds)
12:02:40  * abraxas_quit (Remote host closed the connection)
12:40:15  * dsantiagoquit (Ping timeout: 252 seconds)
12:42:16  * dsantiagojoined
12:50:28  * rmgjoined
12:55:01  * rmgquit (Ping timeout: 264 seconds)
13:24:39  * lance|afkchanged nick to lanceball
13:31:17  * SergeiRNDjoined
14:17:24  * alexforsterjoined
14:25:28  * davijoined
14:33:39  * benjamingrquit (Quit: Connection closed for inactivity)
14:36:48  * AlexisMochaquit (Ping timeout: 246 seconds)
14:41:46  * Ralith_joined
14:44:22  * Ralithquit (Ping timeout: 255 seconds)
14:45:12  * daviquit (Ping timeout: 246 seconds)
15:03:58  * seishunjoined
15:11:06  * SergeiRNDquit (Quit: Leaving.)
15:19:23  * jasnelljoined
15:20:24  * avalanche123joined
15:28:17  * rmgjoined
15:41:04  <jeremyw>While working on #175, I created a Vagrantfile to ease setting up different VMs for OS tests. Would this be useful for anyone else?
15:47:21  * jgijoined
15:50:43  <jeremyw>Hello jgi.
15:51:12  <jgi>jeremyw: hey!
15:51:37  <jeremyw>I've got a useful Vagrantfile and I was able to reproduce the failure on Linux.
15:51:45  <jeremyw>But...there were also 4 other failures as well.
15:51:49  <jeremyw>Do you see those too?
15:52:47  * alexforsterquit
15:53:47  <jeremyw>I'm trying this time without using Vagrant's shared folder to see if that remedies the issue as it could had been an fs issue due to VirtualBox/Vagrant interacting with the host FS.
15:54:22  <jeremyw>That was it. Now that I'm on Linux without a shared FS, no tests are failing again. *sigh*
15:55:11  * reqsharkquit (Quit: Be back later ...)
15:55:47  * avalanche123quit (Remote host closed the connection)
15:56:37  <jeremyw>jgi: Any chance you were compiling/testing/libuv on a VM where the libuv sources were hosted on the host FS and shared/synced to your guest?
15:58:03  <jgi>jeremyw: what are those 4 other failures?
15:58:18  <jgi>jeremyw: ah ok (sorry, catching up)
15:58:38  <jgi>jeremyw: I’m checking if I’m using a shared FS
16:00:17  <jeremyw>jgi: When I stopped using the shared/synced FS, all failures stopped but they were all FS related.
16:08:26  <jgi>jeremyw: heading to the office now, see you in 30 minutes :)
16:08:32  * jgiquit (Quit: jgi)
16:10:34  * SergeiRNDjoined
16:12:55  * Fishrock123joined
16:13:56  * dsantiagoquit (Quit: Leaving...)
16:20:55  * lanceballchanged nick to lance|afk
16:24:53  * dap_joined
16:26:30  * qardjoined
16:26:56  * AlexisMochajoined
16:30:00  * Ralith_quit (Ping timeout: 244 seconds)
16:31:36  * SergeiRNDquit (Quit: Leaving.)
16:40:20  * alexforsterjoined
16:41:33  * jgijoined
16:45:30  * dsantiagojoined
16:46:22  <jgi>jeremyw: I’m not using shared FS/folders
16:46:38  <MI6>joyent/node: [email protected] refs/tags/jenkins-accept-pull-request-temp * 6e3c916 : V8: remove V8_HOST_CAN_READ_UNALIGNED and its uses (+1 more commits) - http://git.io/vtD5W
16:47:07  <MI6>joyent/node: [email protected] refs/tags/jenkins-accept-commit-temp * 10ad89f : V8: remove V8_HOST_CAN_READ_UNALIGNED and its uses (+1 more commits) - http://git.io/vtD5u
16:47:20  <jgi>jeremyw: so you’re saying that on Linux, (while true; do ./test/run-tests fs_readdir_non_empty_dir; done) never fails?
16:56:13  <jeremyw>Nope...let me try once more.
16:57:30  <jeremyw>I let it run for at least a minute without failure.
16:57:59  <jgi>jeremyw: interesting
16:58:10  <jgi>jeremyw: what distribution are you using?
16:58:15  <jeremyw>Ubuntu 12.04
16:58:34  <jgi>jeremyw: 64 bits?
17:01:13  * benjamingrjoined
17:03:31  <jeremyw>32
17:03:41  <jeremyw>I can do 64...just realized that vagrant box used 32 bits
17:03:52  * Ralithjoined
17:07:11  <jgi>jeremyw: I’m reproducing on 64 bits, I haven’t tried 32. But it could make a difference
17:08:32  <jeremyw>Working on it now. 32-bit definitely did not error when running a constant loop of tests for over a minute.
17:16:16  <jeremyw>jgi: Still cannot reproduce it. Ubuntu 12.04 (64-bit) with the same build/test process.
17:16:41  <jgi>jeremyw: interesting, thank you very much for doing all that :)
17:16:50  <jeremyw>No sweat.
17:16:59  <jeremyw>Mind me reporting this to the issue?
17:17:15  <jeremyw>I can document the full process and Vagrantfile I used.
17:17:27  <jgi>jeremyw: yes, that would be great!
17:17:43  <jeremyw>You got it.
17:18:22  <jgi>jeremyw: another question: did you pull my branch (misterdjules/libuv:fix-issue-170) and use that directly, or did you merge the changes in the PR into the current libuv v1.x branch?
17:18:41  <jgi>I did the former, but if you did the latter that might explain the differences we’re seeing
17:26:44  <jeremyw>I pulled the PR.
17:27:29  <jeremyw>jgi: Per https://gist.github.com/piscisaureus/3342247, I update my .git/config, fetched the PRs and checked out the PR directly.
17:27:50  <jeremyw>I could rerun the 64-bit test pulling your branch changes.
17:28:40  <jgi>jeremyw: pulling my branch changes into current v1.x?
17:29:01  <jeremyw>Should had been master.
17:29:22  * lance|afkchanged nick to lanceball
17:29:31  * abraxas_joined
17:29:48  <jeremyw>Wait...your PR uses v1.x.
17:29:51  <jeremyw>So yes, v1.x.
17:30:04  <jeremyw>"misterdjules wants to merge 1 commit into libuv:v1.x from misterdjules:fix-issue-170"
17:30:41  <jeremyw>I can update the issue with my steps, it might help.
17:30:56  <jeremyw>And if I've done something wrong or you'd like to test a different way/scenario, we can do that. How's that sound?
17:31:11  <jgi>jeremyw: sounds good
17:32:06  <jeremyw>https://github.com/libuv/libuv/pull/175#issuecomment-117272115
17:32:10  <jeremyw>For those following along at home.
17:32:13  * jeremywlaughs
17:32:22  <jgi>jeremyw: what I meant with my question “pulling my branch changes into current v1.x?” was: do you mean pulling my changes in *current* v1.x? That would mean solving conflicts and could take time if you’re not familiar with my changes yet.
17:32:55  <jeremyw>Oh no, I didn't do that.
17:33:02  <jeremyw>I pulled the PR as it exists.
17:33:15  <jeremyw>Since the PR doesn't include any conflict resolution, neither did my tests.
17:34:05  <jeremyw>I definitely could pull the PR and merged latest v1.x into it if need be. I guess someone will need to do this at some point.
17:34:14  <jeremyw>But in the comment, you have my full set of steps.
17:34:25  <jeremyw>Let me know if you see anything wrong or something you'd like to try or be different.
17:34:34  <jgi>jeremyw: yep, that looks great
17:34:37  * abraxas_quit (Ping timeout: 264 seconds)
17:34:51  <jgi>jeremyw: and thank you again for doing that :)
17:34:55  <jeremyw>No problem.
17:34:59  <jeremyw>I just want to help. :)
17:35:16  <jeremyw>And learn of course.
17:35:28  <jgi>I’m trying to think of a way to determine the cause of the failures I’m seeing
17:35:55  <jgi>or actually just to determine if it’s due to my setup, or if it’s an actual genuine test failure
17:36:29  <jgi>jeremyw: in the meantime I think the next step for you would be to merge my changes into current *master*
17:36:35  <jgi>jeremyw: as indicated by saghul
17:36:44  <jeremyw>Makes sense.
17:36:52  <jgi>jeremyw: it could be a bit painful, so feel free to ask for support here :)
17:37:02  <jeremyw>So to do that, I'd branch master and merge your changes into it. Sound right?
17:37:18  <jeremyw>Resolve conflicts, ...
17:37:40  <jgi>jeremyw: yes, I would suggest merging my changes by applying them, not merging them (in the git sense)
17:37:50  <jgi>jeremyw: someting like curl -L pr-url.patch | git am -
17:39:05  <jeremyw>Makes sense.
17:40:10  <jgi>jeremyw: you might want to mention that in the PR’s comments too, just to make sure that anyone who might have a different opinion about how to proceed raise their concerns sooner rather than later :)
17:40:20  <jeremyw>Will do.
17:43:47  <MI6>joyent/node: [email protected] refs/tags/jenkins-accept-commit-temp * 681cf86 : V8: remove V8_HOST_CAN_READ_UNALIGNED and its uses (+1 more commits) - http://git.io/vty8R
17:44:24  <jeremyw>jgi: I have to get some Apigee work done for a few hours but I'll get back on this in a bit.
17:45:13  <jgi>jeremyw: great, thank you!
17:45:32  <jeremyw>You got it.
17:45:42  * reqsharkjoined
17:47:15  * dap_part
17:47:15  * dap_joined
17:55:43  * Fishrock123quit (Quit: Leaving...)
17:57:21  * avalanche123joined
17:59:25  * AlexisMochaquit (Ping timeout: 276 seconds)
18:02:04  * avalanche123quit (Remote host closed the connection)
18:15:29  * Fishrock123joined
18:24:08  * alexforsterquit (Ping timeout: 265 seconds)
18:25:28  * AlexisMochajoined
18:27:49  * SergeiRNDjoined
18:29:19  * joaocgreisquit (Quit: Leaving)
18:41:57  * SergeiRNDquit (Quit: Leaving.)
19:03:25  * SergeiRNDjoined
19:04:29  * tunniclmjoined
19:07:40  <jgi>jeremyw: grabbing lunch
19:08:03  * reqsharkquit (Ping timeout: 250 seconds)
19:17:41  * jgiquit (Quit: jgi)
19:18:46  * reqsharkjoined
19:25:56  * reqsharkquit (Read error: Connection reset by peer)
19:26:40  * reqsharkjoined
19:31:09  * avalanche123joined
19:35:37  * s3shsquit (Ping timeout: 276 seconds)
19:40:09  * SergeiRNDquit (Quit: Leaving.)
19:41:40  * avalanche123quit (Remote host closed the connection)
19:44:42  * avalanche123joined
19:45:42  * s3shsjoined
19:52:37  * jgijoined
19:55:41  * avalanche123quit (Remote host closed the connection)
19:59:08  * s3shsquit (Quit: Computer has gone to sleep.)
20:07:02  * s3shsjoined
20:29:15  * alexforsterjoined
20:34:20  * seishunquit (Ping timeout: 256 seconds)
20:34:58  * lanceballquit (Quit: Bye bye)
20:36:13  * s3shsquit (Quit: Computer has gone to sleep.)
20:38:55  * lanceballjoined
20:39:09  * s3shsjoined
20:42:50  * lanceballquit (Changing host)
20:42:50  * lanceballjoined
20:43:03  * lanceballquit (Client Quit)
20:43:46  * lanceballjoined
20:44:00  * lanceballquit (Changing host)
20:44:00  * lanceballjoined
20:49:24  * Fishrock123quit (Remote host closed the connection)
20:50:41  <jeremyw>jgi: Wish me luck...work has started. ;)
20:51:27  <jgi>jeremyw: hehehe :) it will be painful, but that should help you get familiar with how requests work in libuv, which is one of the main primitives/concepts of this library
20:52:22  <jeremyw>Works for me.
20:52:46  * s3shsquit (Quit: Computer has gone to sleep.)
21:19:01  <saghul>jeremyw: ohai! master hasn't diverged from v1.x yet, so the merge should be straightforward
21:19:28  <saghul>feel free to ask questions over here, I try to keep an eye... but timezones! :-)
21:19:32  * s3shsjoined
21:20:11  <jgi>jeremyw, saghul: one area where the merge might be slightly involved is in the win32 implementation, I seem to remember that the scandir implementation on win32 had changed significantly
21:20:47  * s3shsquit (Client Quit)
21:33:37  <jeremyw>I'm all ears.
21:35:17  <jgi>jeremyw: I don’t have time to fill you in with all the details right now, but if you’re hitting some specific problems with the merge, please let us know in comments in the PR on GitHub so that anyone can help you
21:36:04  <jeremyw>jgi: I'm good for now. Anything I have I'll bring up here.
21:36:51  * alexforsterquit
21:37:36  * AlexisMochaquit (Ping timeout: 252 seconds)
21:41:49  <saghul>jgi: ah, true that!
21:42:34  <jeremyw>saghul: If you have any suggestions about updating PR 175 for Windows and scandir...let me know. Update the PR I guess.
21:43:59  * lanceballchanged nick to lance|afk
21:44:05  * rendarquit (Quit: Leaving)
21:46:29  * s3shsjoined
21:46:54  * jgiquit (Quit: jgi)
21:50:14  * Fishrock123joined
21:54:14  * jgijoined
21:55:31  * Fishrock123quit (Ping timeout: 256 seconds)
21:56:55  * saghul_joined
21:56:55  * saghulquit (Read error: Connection reset by peer)
21:57:01  * s3shsquit (Quit: Computer has gone to sleep.)
21:58:04  * s3shsjoined
22:02:41  * s3shsquit (Quit: Computer has gone to sleep.)
22:10:41  <jeremyw>I think it's done. Patch applied cleanly except for one conflict in include/uv-win.h. Fixed it and now I'm testing that things are working as expected.
22:13:13  * reqsharkquit (Quit: Be back later ...)
22:16:31  <jgi>jeremyw: that’s great!
22:18:58  <jeremyw>Yeah. Testing the PR on Linux now. OS X was fine.
22:19:20  <jeremyw>If saghul_ wants me to update the PR for the new scandir, I'm up for it but I didn't hear anything yet.
22:20:18  * tunniclm_joined
22:21:20  <jeremyw>What's the next step? Would you like me to commit this to my fork and reference it in 175?
22:22:15  * avalanche123joined
22:22:49  <jeremyw>Tests are passing once again on Ubuntu 64-bit.
22:23:04  <jeremyw>I destroyed the VM and recreated it just to be sure I didn't do anything to help them pass. ;)
22:23:29  * tunniclmquit (Ping timeout: 250 seconds)
22:25:00  <jeremyw>Yup...OS X and Ubuntu 12.04 (32-bit and 64-bit) all run fine with your PR applied to master.
22:25:08  <jeremyw>Same results as current PR on v1.x.
22:25:33  * avalanche123quit (Remote host closed the connection)
22:29:04  * chris_99quit (Quit: Ex-Chat)
22:29:42  * chris_99joined
22:31:44  * jasnellquit (Remote host closed the connection)
22:31:57  * jasnelljoined
22:35:15  * Fishrock123joined
22:36:19  * dsantiagoquit (Quit: Computer has gone to sleep.)
22:37:11  <jeremyw>jgi: I'm headed to the gym. Here is the branch in my fork of libuv for the application of pr/175 to master => https://github.com/whitlockjc/libuv/tree/pr-175-to-master
22:37:30  <jgi>jeremyw: can you submit a new PR to libuv/libuv and I’ll close mine in favor of yours
22:37:34  <jeremyw>I'm going to mention this in the issue and await the next steps there.
22:37:37  <jeremyw>Oh, okay. :)
22:37:44  <jgi>excellent, thank you very much!
22:37:50  <jeremyw>np
22:38:24  <jeremyw>Should I add any notes to the PR message or leave it as-is?
22:38:45  <jeremyw>GitHub picked up your previous PR message.
22:40:00  <jeremyw>To me it would make sense to update the PR message for my PR to incidate that I've taken the work you've done for 175 and applied it to master.
22:40:59  <jeremyw>Then 175 would get a reference (paper trail) and we can see that this PR is really just my help in applying to master.
22:41:53  <jeremyw>This is what I'd propose: This PR is for taking the efforts by @misterdjules in #175 and applying those changes to `master` instead of `v1.x` per @saghul's suggestion.
22:42:24  <jgi>jeremyw: sounds good!
22:43:07  <jeremyw>Done.
22:43:08  <jeremyw>https://github.com/libuv/libuv/pull/416
22:43:15  <jeremyw>And on that note, I'm headed to the gym.
22:56:05  * abraxas_joined
22:59:04  * alexforsterjoined
23:00:39  * abraxas_quit (Ping timeout: 252 seconds)
23:00:59  <jgi>jeremyw: awesome :) You will probably want to /cc @saghul @piscisaureus @bnoordhuis in a commnt of this PR
23:02:46  * Ralithquit (Ping timeout: 272 seconds)
23:09:02  * dsantiagojoined
23:12:10  * EhevuTovjoined
23:14:11  * chris_99quit (Remote host closed the connection)
23:25:41  * alexforsterquit
23:28:26  * qardquit (Quit: (ノಠ益ಠ)ノ彡┻━┻)
23:41:27  * Fishrock123quit (Quit: Leaving...)
23:43:35  * avalanche123joined