21:21:57  <jeremyw>Done.
21:28:22  * bradleymeckquit (Quit: bradleymeck)
21:32:35  <jgi>jeremyw: thanks, I updated the original description of the PR to reflect the new commit message too
21:32:51  <jgi>jeremyw: github doesn’t do that automatically unfortunately :(
21:33:15  <jgi>or maybe not unfotunately, because that’s actually difficult to do it right, anyway that’s a bit off topic :)
21:34:11  * inolenjoined
21:35:26  <jgi>jeremyw: also make sure to run make jslint on your updated code to make sure that newly added comments are < 80 columns
21:35:45  <jgi>that’s usually run at the end of make test
21:39:14  <jeremyw>It is.
21:39:34  <jeremyw>I ran into that yesterday when toying with the idea of printing the remaining time in debug.
21:40:53  <jeremyw>jgi: make test came back fine and I know it's runing jslint so we should be good from that perspective.
21:41:05  <jeremyw>I had to alter your suggested code comment to pass jslint.
21:41:12  <jgi>jeremyw: excellent, thank you!
21:41:21  <jeremyw>np
21:41:32  <jeremyw>Just trying to put your mind at ease. ;)
21:41:47  <jgi>jeremyw: almost there, I’m gonna add another comment in a few minutes about adding some test(s)
21:41:52  <jgi>jeremyw: and then we should be done :)
21:41:54  <jeremyw>No sweat.
21:42:28  <jeremyw>I figured since this was to fix a flaky test, when the flaky test was fixed it would be good but I'm up for new tests if you want.
21:42:32  <jeremyw>I'm a team player.
21:43:05  <jeremyw>I guess since that flaky test isn't in this code base, it doesn't help.
21:43:10  <jeremyw>I'll await your comment.
21:43:11  * alexforsterquit
21:44:13  * seishunquit (Ping timeout: 255 seconds)
21:45:40  * abraxas_joined
21:49:51  * abraxas_quit (Ping timeout: 240 seconds)
21:50:09  <jgi>jeremyw: https://github.com/joyent/node/pull/25763#issuecomment-124736263
21:51:00  <jeremyw>I'll get to it.
22:01:38  * a3fquit (Quit: Zzzzz..)
22:05:16  * a3fjoined
22:07:22  * avalanche123quit (Remote host closed the connection)
22:12:05  * kaftzquit (Quit: WeeChat 1.2)
22:15:40  * rendarquit
22:17:25  * yunongjoined
22:18:27  * yunongquit (Remote host closed the connection)
22:29:32  <jeremyw>jgi: Any suggestion on test names? Just trying to avoid extra cycles in the PR review process when possible.
22:32:10  * jgiquit (Quit: jgi)
22:33:05  * jgijoined
22:39:35  <jgi>jeremyw: maybe test-timers-nested.js?
22:40:13  <jgi>jeremyw: also, in the test, make sure you reference the issue numbers of bugs fixed, and make sure you provide some explanation of what it’s testing and how
22:45:01  * s3shsjoined
22:46:52  * qard_joined
22:59:30  <jeremyw>You got it.
22:59:32  * a3fquit (Quit: Zzzzz..)
23:00:00  <jeremyw>jgi: I won't get to this by EOD as I have a softball game tonight. I *might* do it over the weekend but it will likely be Monday. I hope that's alright.
23:01:05  <jgi>jeremyw: of course!
23:02:09  * a3fjoined
23:02:19  <jeremyw>Have a good weekend all, I'll get this stuff sorted.
23:02:30  <jeremyw>Thanks a lot for your mentoring me and helping me get this PR ready.
23:04:05  * bradleymeckjoined
23:05:23  * bradleymeckquit (Client Quit)
23:07:48  * avalanche123joined
23:23:33  * jgi_joined
23:24:08  * jgiquit (Ping timeout: 244 seconds)
23:24:09  * jgi_changed nick to jgi
23:24:26  * qard_quit (Quit: (ノಠ益ಠ)ノ彡┻━┻)
23:43:44  <jgi>jeremyw: have a great week-end, and thank you for your contributions!
23:51:32  * coderkevin_joined
23:51:44  * ckross01_joined
23:51:45  * petka___joined
23:54:01  * petka__quit (Ping timeout: 240 seconds)
23:54:01  * coderkevinquit (Ping timeout: 240 seconds)
23:54:02  * ckross01quit (Ping timeout: 240 seconds)
23:54:03  * a3fquit (Ping timeout: 240 seconds)
23:54:28  * petka___changed nick to petka__
23:54:35  * coderkevin_changed nick to coderkevin
23:55:02  * ckross01_changed nick to ckross01
23:56:51  * ncthom91joined
23:59:19  * importantshockquit (Remote host closed the connection)
23:59:51  * importantshockjoined