00:21:16  * Akagi201joined
01:01:30  * Akagi201quit
01:10:18  * piernovquit (Ping timeout: 252 seconds)
01:18:35  * DarkGodquit (Ping timeout: 246 seconds)
03:08:34  * squeeekquit
03:39:41  * squeekjoined
03:43:54  * SkyRocknRolljoined
04:48:20  * SkyRocknRollquit (Remote host closed the connection)
05:21:45  * SkyRocknRolljoined
06:18:04  * SkyRocknRollquit (Ping timeout: 256 seconds)
06:34:30  * SkyRocknRolljoined
07:22:59  * DarkGodjoined
09:20:10  * sousouxquit (Ping timeout: 252 seconds)
09:20:31  * sousouxjoined
11:46:53  * piernovjoined
12:33:06  <sousoux>creationix: are you there?
12:54:25  <rphillips>sousoux: you will want this https://github.com/luvit/luvit/pull/762/files#diff-d7d74284e2e39f6c06d199c8e2bedbd0R39
12:54:51  <rphillips>I should close my PR
12:56:21  <sousoux>Ah!
12:57:01  <rphillips>sousoux: https://github.com/luvit/luvit/commit/3256bbf07985f25ea651cdfb5d764b1114b7fd11
12:57:05  <rphillips>and probably tim's patch
12:57:29  <sousoux>rphillips: can you look at my PR? I did a little more to close the socket directly when ssl indicates that it is finished
12:58:06  <sousoux>If necessary I can cancel it and resubmit without the TLS stuff
12:58:30  <sousoux>Since there is also http connection keep alive and a small addition to childprocess
12:59:07  <rphillips>this patch looks good
12:59:15  <rphillips>if you add the sigpipe handler in
12:59:17  <rphillips>everything should pass
13:03:02  <sousoux>ok. I will pull the init from the master and add that in
13:17:53  * sousoux2joined
13:20:22  * sousouxquit (Ping timeout: 276 seconds)
13:23:44  * endou___________quit
13:24:00  * endou___________joined
13:29:34  <sousoux2>The tim patch does not resolve the holes in handlers issue that I raised
13:30:29  * sousoux2quit
13:30:46  * sousouxjoined
13:31:07  <sousoux>rphillips: passes finally
13:43:18  <rphillips>hmm
13:44:05  <rphillips>sousoux: we may need to use table.remove
13:46:40  <sousoux>Trying to generate a test that makes it fail but not succeeding
13:46:58  <sousoux>it is definitely to do with the remove order
13:48:39  <sousoux>got you
13:49:34  <sousoux>I have a test that fails.
13:50:20  <sousoux>I'll email it. I also have a patch but I'll wait until my last pull makes it in.
13:54:29  <sousoux>rphillips: it is in your email.
13:54:42  <rphillips>sousoux: can you PR the patch
13:54:56  <rphillips>i think the SSL patch looks really good
14:01:28  * SkyRocknRollquit (Remote host closed the connection)
14:07:38  <sousoux>rphillips: I pushed under the same PR. Sorry. It wasn't on a branch.
14:07:46  <rphillips>not a problem
14:08:21  <sousoux>only nasty thing is listener count. Don't see any other way
14:08:39  <sousoux>unless there is a separate count stored and updated
14:09:06  <sousoux>not a feature I use much but I don't know about others
14:10:34  <rphillips>sousoux: https://github.com/luvitred/luvit/blob/3bf8ed570f0e631a5ee51e2acd5950d3394a90f6/deps/core.lua#L259
14:10:44  <rphillips>we should be able to use table.remove
14:10:58  <rphillips>it'll keep the ordered list
14:12:22  <creationix>sousoux: rphillips: mornin
14:12:28  <sousoux>That doesn't work well with a listener removed in an on I think. There is definitely a corner case that I saw where that caused issues
14:12:37  <rphillips>ah
14:12:39  <sousoux>creationix: good morning
14:14:57  <creationix>where do we need table.remove?
14:15:18  <creationix>sousoux: is this not enough? https://github.com/luvit/luvit/commit/3256bbf07985f25ea651cdfb5d764b1114b7fd11
14:15:38  <sousoux>try out my test
14:15:50  <creationix>link
14:17:04  <sousoux>https://github.com/luvitred/luvit/blob/3bf8ed570f0e631a5ee51e2acd5950d3394a90f6/tests/test-emitter.lua#L37
14:18:07  <creationix>so the issue is listenerCount is off?
14:18:35  <sousoux>The issue is that you don't get both callbacks called
14:18:36  <rphillips>there are holes in the list by setting the entry to 'false'
14:18:54  <rphillips>lua's length operator does not return the right value
14:18:59  <sousoux>false ~= nil so the array is not sparse and # works
14:19:02  <rphillips>well, 'right' is subjective
14:19:23  <creationix>ahh, right
14:19:26  <creationix>silly lua
14:19:31  <sousoux>yup
14:19:38  <creationix>so we should set the holes to false instead of nil
14:19:47  <sousoux>that is what my patch does
14:20:05  <sousoux>still to get listener count correct you have to iterate which is ugly
14:20:49  <sousoux>you could have a cleaned variable set when the holes are eliminated I guess
14:21:13  <creationix>I don't think listener count is used enough to justify keeping a count around
14:21:19  <creationix>I'm fine with iterating
14:21:22  <sousoux>agreed
14:21:36  <creationix>+1 to setting false instead of nil and iterating for count
14:25:13  <creationix>sousoux: if you want I can cherry-pick your emitter commit so it's not mixed with the rest
14:26:40  <creationix>https://github.com/luvitred/luvit/commit/3bf8ed570f0e631a5ee51e2acd5950d3394a90f6
14:27:00  <creationix>err, I mean https://github.com/luvit/luvit/commit/3edc192c695de051a750e9ed7b4c79ba13052965
14:27:41  * travis-cijoined
14:27:42  <travis-ci>luvit/luvit#2307 (master - 3edc192 : Martin Croome): The build passed.
14:27:42  <travis-ci>Change view : https://github.com/luvit/luvit/compare/3256bbf07985...3edc192c695d
14:27:42  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69739468
14:27:42  * travis-cipart
14:32:33  <sousoux>great. thanks.
14:36:06  <creationix>rphillips: are we ready for another luvi release yet?
14:36:15  <rphillips>+1
14:38:58  <creationix>rphillips: is this accurate? https://github.com/luvit/luvi/commit/ea52dde94cf8dd46c015f10883459fff51435762
14:39:13  <creationix>"openaal" :/
14:39:26  <rphillips>heh, yeah.
14:39:53  <creationix>try again https://github.com/luvit/luvi/commit/c3b1b3fce883f24af7a039c6b1c026fb8879cfe1
14:42:39  * travis-cijoined
14:42:40  <travis-ci>luvit/luvi#622 (master - ea52dde : Tim Caswell): The build has errored.
14:42:41  <travis-ci>Change view : https://github.com/luvit/luvi/compare/c9db6bf9768c...ea52dde94cf8
14:42:41  <travis-ci>Build details : https://travis-ci.org/luvit/luvi/builds/69741513
14:42:41  * travis-cipart
14:48:45  * travis-cijoined
14:48:46  <travis-ci>luvit/luvi#623 (master - c3b1b3f : Tim Caswell): The build passed.
14:48:46  <travis-ci>Change view : https://github.com/luvit/luvi/compare/ea52dde94cf8...c3b1b3fce883
14:48:46  <travis-ci>Build details : https://travis-ci.org/luvit/luvi/builds/69741583
14:48:46  * travis-cipart
14:53:25  * dan336joined
15:02:41  * SkyRocknRolljoined
15:11:16  * travis-cijoined
15:11:17  <travis-ci>luvit/luvi#624 (v2.1.4 - c3b1b3f : Tim Caswell): The build passed.
15:11:17  <travis-ci>Change view : https://github.com/luvit/luvi/compare/v2.1.4
15:11:17  <travis-ci>Build details : https://travis-ci.org/luvit/luvi/builds/69745349
15:11:17  * travis-cipart
15:34:18  <creationix>rphillips: ok, all binaries except armv6-regular are done
15:34:44  <creationix>https://github.com/luvit/luvi/releases/tag/v2.1.4
15:35:45  <rphillips>nice
15:37:03  <creationix>and this time I was smart enough to run the armv6 build in a tmux session so it doesn't crash when my laptop falls asleep
15:41:17  <creationix>ok, and updated the release branch in luvi
15:41:33  <creationix>lit update with new luvi published
15:45:09  <creationix>sousoux: I also cherry-picked your uid/gid changes. I'm not sure what needs to be done with the rest.
15:46:08  <rphillips>i think the rest should be merged
15:46:13  <rphillips>sousoux: think it's ready?
15:49:21  * Michalikquit
15:49:30  * Michalikjoined
15:53:34  * travis-cijoined
15:53:35  <travis-ci>luvit/luvit#2308 (master - 5127424 : Martin Croome): The build passed.
15:53:35  <travis-ci>Change view : https://github.com/luvit/luvit/compare/3edc192c695d...51274247faf9
15:53:35  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69753439
15:53:35  * travis-cipart
15:54:22  <creationix>rphillips: shall we merge george's patch too?
15:57:14  <rphillips>creationix: +1
16:03:24  <creationix>ok, bumped luvi/lit and merged the tls PR
16:03:30  * travis-cijoined
16:03:31  <travis-ci>luvit/luvit#2310 (master - ea0377a : Tim Caswell): The build passed.
16:03:31  <travis-ci>Change view : https://github.com/luvit/luvit/compare/8b29da0fbbfd...ea0377a6a11b
16:03:31  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69754907
16:03:31  * travis-cipart
16:03:38  <creationix>I got a segfault on linux, but after trying the tests again, it passed
16:04:18  <creationix>hmm, might have been a bad build. I didn't do make clean before the first try
16:04:46  <rphillips>hmm. it might be the same segfault we sometimes see on travis
16:05:41  <creationix>I can't scroll back far enough to see it. I think it was around test 21 something with a callback
16:06:21  <creationix>maybe #66 scandir callback
16:07:02  <creationix>I ran the suite 10 more times, it won't reproduce
16:10:38  <creationix>rphillips: shall we close your tls PR? https://github.com/luvit/luvit/pull/758
16:11:00  <rphillips>ah yes
16:11:02  <rphillips>thanks
16:14:58  * travis-cijoined
16:14:59  <travis-ci>luvit/luvi#625 (release - c3b1b3f : Tim Caswell): The build passed.
16:14:59  <travis-ci>Change view : https://github.com/luvit/luvi/compare/b90d183b11de...c3b1b3fce883
16:14:59  <travis-ci>Build details : https://travis-ci.org/luvit/luvi/builds/69751762
16:14:59  * travis-cipart
16:15:40  <creationix>ok, Everything is merged and updated except for https://github.com/luvit/luvit/pull/763, but I'm not convinced that is a good idea
16:15:55  <creationix>I think the existing `module:action(path, cb)` API is exactly what he needs.
16:17:06  * travis-cijoined
16:17:07  <travis-ci>luvit/luvit#2312 (master - d828d04 : Tim Caswell): The build passed.
16:17:07  <travis-ci>Change view : https://github.com/luvit/luvit/compare/1f69e99f56d7...d828d0461042
16:17:07  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69756838
16:17:07  * travis-cipart
16:26:35  * travis-cijoined
16:26:36  <travis-ci>luvit/luvit#2313 (master - b5fa615 : Tim Caswell): The build was broken.
16:26:36  <travis-ci>Change view : https://github.com/luvit/luvit/compare/d828d0461042...b5fa6152ed36
16:26:36  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69758095
16:26:36  * travis-cipart
16:29:23  <creationix>Luvit 2.2.4 published
16:29:30  * hdmsjoined
16:29:32  <creationix>I guess I should publish to lit before pushing to github.
16:29:41  <creationix>travis tries to install packages from lit that aren't there yet
16:30:13  * travis-cijoined
16:30:14  <travis-ci>luvit/luvit#2314 (master - 0a20dd3 : Tim Caswell): The build was fixed.
16:30:14  <travis-ci>Change view : https://github.com/luvit/luvit/compare/b5fa6152ed36...0a20dd3acc0e
16:30:14  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69758565
16:30:14  * travis-cipart
16:32:16  * travis-cijoined
16:32:17  <travis-ci>luvit/luvit#2313 (master - b5fa615 : Tim Caswell): The build passed.
16:32:18  <travis-ci>Change view : https://github.com/luvit/luvit/compare/d828d0461042...b5fa6152ed36
16:32:18  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/69758095
16:32:18  * travis-cipart
16:33:17  <creationix>sousoux: I manually merged the rest of your PR. It's all published to latest luvit now. Thanks for all the fixes
17:07:23  * SkyRocknRollquit (Remote host closed the connection)
17:17:24  <rphillips>https://mta.openssl.org/pipermail/openssl-announce/2015-July/000037.html
17:17:29  <rphillips>another openssl update
17:17:37  <rphillips>looks like a thursday release
20:58:08  <rphillips>rje: thinking about merging the luvi-up branches to master
20:58:23  <rphillips>within the agent and virgo-base
20:59:33  <rje>rphillips, sounds like a good time to do it. branch master to a new legacy branch jic
20:59:41  <rje>?
21:00:15  <rphillips>right
21:00:26  <rje>+1
21:31:33  <creationix>+1
21:54:11  <rphillips>ok done
21:54:29  <rphillips>i reset the master branch to point to the hash for luvi-up
22:39:47  * travis-cijoined
22:39:48  <travis-ci>brimworks/luvi#29 (master - 07635d7 : Brian Maher): The build passed.
22:39:48  <travis-ci>Change view : https://github.com/brimworks/luvi/compare/76224e054f5c...07635d7e0329
22:39:48  <travis-ci>Build details : https://travis-ci.org/brimworks/luvi/builds/69805531
22:39:48  * travis-cipart
23:00:17  * hdmsquit (Quit: hdms)
23:06:50  * dan336quit (Quit: Leaving.)