00:05:43  * creationixquit (Remote host closed the connection)
00:35:49  * DarkGodquit (Ping timeout: 255 seconds)
00:55:01  * creationixjoined
02:14:18  * travis-cijoined
02:14:19  <travis-ci>zhaozg/luvit#17 (master - 0f9b8db : zhaozg): The build passed.
02:14:19  <travis-ci>Change view : https://github.com/zhaozg/luvit/compare/80157e3a3ecd...0f9b8db97e31
02:14:19  <travis-ci>Build details : https://travis-ci.org/zhaozg/luvit/builds/242666394
02:14:19  * travis-cipart
02:21:05  * SkyRocknRollquit (Ping timeout: 240 seconds)
04:30:43  * Xequit (Ping timeout: 260 seconds)
04:36:57  * Xejoined
05:08:40  * ryan_fordjoined
05:51:08  * SinisterRectusquit (Ping timeout: 240 seconds)
05:58:17  * SinisterRectusjoined
06:37:42  * rendarjoined
07:51:27  * ryan_fordquit (Ping timeout: 240 seconds)
08:05:15  * ryan_fordjoined
08:56:47  * SkyRocknRolljoined
10:12:05  * CapsAdminquit (Ping timeout: 246 seconds)
10:12:42  * CapsAdminjoined
10:28:24  * creationixquit (Remote host closed the connection)
13:04:38  * creationixjoined
16:52:02  * travis-cijoined
16:52:03  <travis-ci>luvit/luvit#2980 (fixes/release_data - db2c4b8 : Ryan Phillips): The build has errored.
16:52:03  <travis-ci>Change view : https://github.com/luvit/luvit/compare/3cb446885ee1...db2c4b8d7d9a
16:52:03  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/242893273
16:52:03  * travis-cipart
17:31:33  * travis-cijoined
17:31:34  <travis-ci>luvit/luvit#2978 (master - 02f6234 : Ryan Phillips): The build has errored.
17:31:34  <travis-ci>Change view : https://github.com/luvit/luvit/compare/9b147e220d4e...02f6234baf00
17:31:34  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/242890337
17:31:34  * travis-cipart
17:32:40  * travis-cijoined
17:32:41  <travis-ci>luvit/luvit#2979 (master - 84d32a2 : SinisterRectus): The build has errored.
17:32:41  <travis-ci>Change view : https://github.com/luvit/luvit/compare/02f6234baf00...84d32a2b7da0
17:32:41  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/242890502
17:32:41  * travis-cipart
17:55:19  <SinisterRectus>its failing because https://luvit.io is down
18:09:07  <creationix>sigh
18:10:05  <creationix>ok, just started a `apt update && apt dist-upgrade -y && reboot`
18:11:11  <creationix>SinisterRectus, ok, it's up again
18:13:53  <creationix>SinisterRectus, also on the TLS SNI PR, I think I would prefer the version that is not a breaking change
18:14:01  <creationix>less stuff will break that way
18:14:12  <SinisterRectus>sounds good to me, i'll adjust it
18:14:15  <creationix>thanks
18:14:32  <creationix>since I don't have time to react to breakage as fast as I'd like, I should avoid it where possible
18:14:38  <SinisterRectus>aye
18:14:52  <creationix>but I am glad to see support for SNI added. I use it a *lot* at my startup on the server side
18:15:06  <creationix>I'd love to add it to the server-side as well somehow
18:15:58  <creationix>see `SNICallback` here https://nodejs.org/dist/latest-v8.x/docs/api/tls.html#tls_tls_createserver_options_secureconnectionlistener
18:16:37  <creationix>SNI support in luvit's TLS server is one of the main blockers keeping me from using luvit
18:16:48  <creationix>(or lack of SNI support rather)
18:17:45  <creationix>the other two major missing piece is libsodium bindings. I might add it to luvi as a flavor instead of openssl
18:17:59  <creationix>(or in addition, the feature sets don't actually overlap that much)
18:18:33  <creationix>then UTP transport would be neat, but that might be possible now, I'd have to check
18:18:46  <creationix>(UTP is a TCP-like transport on top of UDP, it's great for P2P stuff)
18:20:20  <creationix>https://en.wikipedia.org/wiki/Micro_Transport_Protocol
18:22:00  <SinisterRectus>local protocol, host, hostname, port, path = url:match("^(https?:)//(([^/:]+):?([0-9]*))(/?.*)$")
18:22:24  <SinisterRectus>it looks like host includes the port while hostname excludes it
18:22:39  <SinisterRectus>do you know which should be set to hostname
18:23:12  <creationix>it should match node.js, just a sec
18:24:04  <creationix>> The key difference between url.host and url.hostname is that url.hostname does not include the port
18:24:41  <SinisterRectus>ugh, overloaded variable names
18:24:53  <SinisterRectus>i meant which one should go to ssl:set('hostname', servername) as servername
18:25:04  <creationix>without the port
18:25:22  <creationix>host with port is meaningful only to browsers for security considerations
18:26:03  <creationix>at least that's what I think, I can double check SNI's spec
18:26:26  <SinisterRectus>hmm
18:26:32  <SinisterRectus>luvit is using hostname = options.host or options.servername
18:27:10  <SinisterRectus>when it comes time to call ssl:set
18:27:22  <creationix>yeah, that's probably a bad idea
18:27:29  <creationix>is there an options.hostname?
18:27:38  <SinisterRectus>yes, https://github.com/luvit/luvit/blob/master/deps/url.lua#L82
18:28:13  <SinisterRectus>different algorithm than what lit uses, but the logic looks the same
18:28:25  <creationix>but yeah, I'm pretty sure it should not include the port
18:28:41  <creationix>SNI is a transport level thing and could care less about http domain semantics
18:29:10  <creationix>let me test it real quick with node and a browser and see what comed out
18:29:13  <SinisterRectus>sure
18:30:37  <creationix>server.js: `require('https').createServer({SNICallback: console.log}).listen(7000)`
18:30:51  <creationix>client: curl https://localhost:7000/
18:31:05  <creationix>name is just `localhost`
18:31:12  <SinisterRectus>alright
18:31:42  <creationix>same from chrome
18:32:09  * SkyRocknRollquit (Remote host closed the connection)
18:36:13  <SinisterRectus>ugh
18:36:25  <SinisterRectus>oh nevermind
18:38:29  <SinisterRectus>in coro-http.request, you have getConnection(uri.hostname, uri.port, uri.tls) but the variable name hostname gets changes to host. changing it would technically break compatability so i'll leave it as is
18:38:48  <SinisterRectus>s/changes/changed
18:39:20  <SinisterRectus>i'll just comment it
18:40:08  * rendarquit (Ping timeout: 240 seconds)
18:46:08  <creationix>:(
18:55:18  <SinisterRectus>actually, it depends on where the data is coming from... parseUrl generates a table with host and hostname. getConnection consumes hostname, but passes it to coro-net as host, which is what coro-net uses as the variable name.
18:55:33  <SinisterRectus>so if you're using coro-net directly, there is no distinction between host and hostname
18:56:12  <SinisterRectus>that's unfortunate
19:09:41  * rendarjoined
19:09:41  * rendarquit (Changing host)
19:09:41  * rendarjoined
19:16:09  <SinisterRectus>we could put a filter on it with ssl:set('hostname', servername:match("^([^:/]+)"))
19:16:26  <SinisterRectus>but it's a fix for an edge case imo
19:29:27  * ryan_fordquit (Ping timeout: 268 seconds)
20:01:31  * travis-cijoined
20:01:32  <travis-ci>luvit/luvit#2982 (fixes/release_data - 64ec081 : Ryan Phillips): The build has errored.
20:01:32  <travis-ci>Change view : https://github.com/luvit/luvit/compare/db2c4b8d7d9a...64ec081349fe
20:01:32  <travis-ci>Build details : https://travis-ci.org/luvit/luvit/builds/242969250
20:01:32  * travis-cipart
20:27:05  * rendarquit (Ping timeout: 240 seconds)
22:39:16  * creationixquit (Remote host closed the connection)