00:21:14  * pfrazeejoined
01:03:44  * pfrazeequit (Remote host closed the connection)
02:30:57  * pfrazeejoined
02:45:58  * pfrazeequit (Remote host closed the connection)
03:09:39  * DTrejojoined
04:09:57  * DTrejoquit (Ping timeout: 252 seconds)
05:14:30  * DTrejojoined
05:15:30  * DTrejoquit (Client Quit)
06:23:08  <emilbayes>can anyone confirm that I'm not crazy and that this is a bug in ferros/buffer? https://gist.github.com/emilbayes/f93cc288cca2458f76708874c6b1701f
06:46:23  <feross>emilbayes: if you confirm it's a bug, please make an issue here https://github.com/feross/buffer
06:47:55  <emilbayes>feross: I think I've tracked it down to a bug in utf8slice, but I'm still not sure. Trying to dig up the C++ impl from Node, but it's hard to find
06:52:54  <emilbayes>feross: Do you know where you got the implementation from? Or did you write it from scratch?
06:54:13  <feross>emilbayes: both
06:54:49  <feross>emilbayes: feross/buffer passes all the node.js core buffer tests, so this must be a tricky one
06:54:57  <feross>thanks for digging into it
06:56:00  <emilbayes>feross: Yeah, spent amount of time so far :p I'll send a PR when I find the source, or leave a issue if I fail
06:59:03  <emilbayes>feross: It's as soon as it encounters a byte > 127
07:27:18  <emilbayes>feross: https://github.com/feross/buffer/pull/149
07:27:47  <emilbayes>feross: Also, the directions on browser testing in the readme are out of date. Can do another PR if you can't/don't want to update right now
07:39:57  <feross>emilbayes: pr looks good, except for one comment
07:40:10  <feross>emilbayes: what's wrong with browser testing instructions?
07:40:10  <emilbayes>feross: checking now
07:40:58  <emilbayes>feross: The npm script doesn't exists anymore :) My guess is that it has been superseded by *-es5-* and *-es6-* scripts?
07:41:29  <feross>emilbayes: oh, that's right
07:41:39  <emilbayes>feross: To fix the test, can I just do another commit and you squash or?
07:41:45  <feross>yes, you can fix that too if you want :)
07:42:01  <feross>extra commits for both the test and readme are fine
07:42:03  <feross>thanks :)
07:47:26  <emilbayes>feross: Done
07:57:50  <feross>emilbayes: publishing 5.0.1 now
07:58:03  <emilbayes>feross: :party:
07:58:08  <emilbayes>🎉
08:37:52  * fotoveritequit (Quit: fotoverite)
09:05:26  <emilbayes>feross: Can you update browserify too? Or should I send a PR?
09:11:27  <emilbayes>feross: Or maybe it's not that simple since it would be a semver major change?
09:13:56  * fotoveritejoined
09:51:03  * fotoveritequit (Quit: fotoverite)
10:10:03  * fotoveritejoined
10:19:36  * gausbyquit (Ping timeout: 250 seconds)
10:24:01  * gausbyjoined
10:48:43  <mafintosh>emilbayes: nice catch!
10:49:09  <emilbayes>mafintosh: Do you have authority to update browserify? :p
10:49:35  <emilbayes>mafintosh: Or should I do a PR? I was concerned that it might get drowned out by all the open PRs on browserify
10:50:18  <mafintosh>emilbayes: is browserify depending on an old version?
10:50:42  <emilbayes>mafintosh: Yeah, [email protected]^4.1.0, but buffer is currently at 5.0.1
10:51:01  <mafintosh>whats the breaking change?
10:51:33  <emilbayes>mafintosh: Not exactly sure. Read the commit log, but its something to do with Buffers being backed by objects at some point?
10:51:42  <emilbayes>mafintosh: Is that anything you know of?
10:52:31  <mafintosh>emilbayes: hmm yea don't know anything about that
10:52:41  <mafintosh>emilbayes: i'm sure feross does though.
10:53:07  <emilbayes>mafintosh: Yeah, I'll wait until we can have an adult help out
10:53:08  <mafintosh>if feross okays it i'm okay with updating as well.
10:53:20  <mafintosh>i think we both have commit rights
10:53:34  <emilbayes>Yeah, you both have publish rights too
10:53:58  <emilbayes>mafintosh: Do you know if I can swap out the implementation used for now? I tried using the browser field but with no luck
10:54:27  <mafintosh>oh it removed support for browsers that don't support uint8arrays
10:54:38  <feross>I can publish a new major version of browserify tomorrow with buffer v5
10:54:48  <mafintosh>cool
10:55:09  <emilbayes>feross: thanks! :)
10:55:12  <feross>yeah, the only browsers that don't support uint8arrays are super ancient
10:55:38  <feross>made the implementation a lot simpler and reduce a few hundred lines of code
10:55:59  <mafintosh>i trust your judgement
10:56:24  <feross><3
10:57:03  <emilbayes>feross: Awesome! is the size in the readme up to date?
10:57:27  <feross>yeah, I think so
10:57:46  <feross>but you can confirm with "npm run size"
10:59:02  <emilbayes>feross: Yeah, it's still good!
11:50:04  * domanicjoined
11:51:49  * thealphanerdquit (Quit: farewell for now)
11:52:20  * thealphanerdjoined
11:53:53  * lmatteisjoined
12:29:10  * pspijoined
12:44:04  * dominic_joined
12:45:38  * domanicquit (Ping timeout: 250 seconds)
12:46:30  * lmatteisquit (Ping timeout: 250 seconds)
12:46:50  * domanicjoined
12:46:52  * brianloveswordsquit (Ping timeout: 260 seconds)
12:47:04  * dominic_quit (Read error: Connection reset by peer)
12:48:19  * brianloveswordsjoined
12:48:39  * lmatteisjoined
12:59:28  * domanicquit (Ping timeout: 260 seconds)
13:03:25  * domanicjoined
15:41:35  * karissaquit (Ping timeout: 250 seconds)
15:41:52  * brycebaril_joined
15:42:01  * lmatteisquit (Ping timeout: 250 seconds)
15:42:01  * emilbayesquit (Ping timeout: 250 seconds)
15:42:01  * mafintoshquit (Ping timeout: 250 seconds)
15:42:01  * daviddiasquit (Ping timeout: 250 seconds)
15:42:02  * juliangruber_joined
15:42:27  * xipliasquit (Ping timeout: 250 seconds)
15:42:28  * mathisonian_quit (Ping timeout: 250 seconds)
15:42:28  * NeoTeoquit (Ping timeout: 250 seconds)
15:42:29  * rvaggquit (Ping timeout: 250 seconds)
15:42:29  * jbenetquit (Ping timeout: 250 seconds)
15:42:29  * tanepiperquit (Ping timeout: 250 seconds)
15:42:29  * HannahWolfequit (Ping timeout: 250 seconds)
15:42:29  * jcrugzzquit (Ping timeout: 250 seconds)
15:42:29  * kep___quit (Ping timeout: 250 seconds)
15:42:29  * parshapquit (Ping timeout: 250 seconds)
15:42:29  * Guest22330quit (Ping timeout: 250 seconds)
15:42:30  * beaugunderson_quit (Ping timeout: 250 seconds)
15:42:30  * brycebarilquit (Ping timeout: 250 seconds)
15:42:30  * hughskquit (Ping timeout: 250 seconds)
15:42:30  * freeman-labquit (Ping timeout: 250 seconds)
15:42:30  * mmckeggquit (Ping timeout: 250 seconds)
15:42:30  * jhieseyquit (Ping timeout: 250 seconds)
15:42:30  * tmpvarquit (Ping timeout: 250 seconds)
15:42:31  * dubroy__________quit (Ping timeout: 250 seconds)
15:42:31  * sorribasquit (Ping timeout: 250 seconds)
15:42:53  * juliangruberquit (Ping timeout: 250 seconds)
15:43:04  * brycebaril_changed nick to brycebaril
15:43:19  * rom1504quit (Ping timeout: 250 seconds)
15:43:20  * addisonjquit (Ping timeout: 250 seconds)
15:43:20  * montesluquit (Ping timeout: 250 seconds)
15:43:22  * lmatteisjoined
15:44:07  * beaugunderson_joined
15:44:28  * mathisonian_joined
15:44:31  * dubroy__________joined
15:45:32  * jhieseyjoined
15:45:33  * NeoTeojoined
15:45:42  * Guest22330joined
15:45:48  * mafintoshjoined
15:45:54  * rvaggjoined
15:46:10  * freeman-labjoined
15:46:14  * jcrugzzjoined
15:46:28  * xipliasjoined
15:46:32  * parshapjoined
15:46:38  * karissajoined
15:46:58  * jbenetjoined
15:47:28  * HannahWolfejoined
15:47:42  * tanepiperjoined
15:47:42  * addisonjjoined
15:47:42  * mmckeggjoined
15:48:13  * daviddiasjoined
15:48:59  * tmpvarjoined
15:49:15  * emilbayesjoined
15:50:34  * sorribasjoined
15:51:26  * kep___joined
15:52:09  * hughskjoined
15:52:40  * monteslujoined
15:54:01  * rom1504joined
15:58:29  * rvaggquit (Ping timeout: 260 seconds)
15:58:29  * dubroy__________quit (Ping timeout: 260 seconds)
16:01:22  * dubroy__________joined
16:02:32  * rvaggjoined
16:05:01  * NeoTeoquit (Ping timeout: 260 seconds)
16:06:58  * NeoTeojoined
16:13:25  * mmckeggquit (Ping timeout: 260 seconds)
16:13:25  * brianloveswordsquit (Ping timeout: 260 seconds)
16:14:49  * mmckeggjoined
16:14:49  * brianloveswordsjoined
16:15:31  * sorribasquit (Read error: Connection reset by peer)
16:15:49  * sorribasjoined
16:20:25  * daviddiasquit (Ping timeout: 260 seconds)
16:24:33  * daviddiasjoined
16:27:25  * mathisonian_quit (Ping timeout: 260 seconds)
16:30:53  * mathisonian_joined
16:55:16  * ekristenjoined
17:29:42  * pfrazeejoined
17:53:46  * contrahaxjoined
18:01:24  * pfrazeequit (Remote host closed the connection)
18:49:17  * NeoTeoquit (Ping timeout: 260 seconds)
18:52:48  * NeoTeojoined
19:49:33  * lmatteisquit (Read error: Connection reset by peer)
20:54:23  * therealkoopajoined
21:02:14  * contrahaxquit (Quit: Sleeping)
21:43:15  * contrahaxjoined
21:46:35  * phatedjoined
22:47:10  <emilbayes>feross: Do you still have time today to look into browserify? I guess you're on Cali TZ?
22:59:44  * contrahaxquit (Quit: Sleeping)
23:08:40  * contrahaxjoined
23:32:25  * contrahaxquit (Quit: Sleeping)