00:11:28  * plutoniixjoined
00:21:04  * jugglinmikequit (Ping timeout: 272 seconds)
00:21:25  * bnoordhuisjoined
00:25:38  * bnoordhuisquit (Ping timeout: 246 seconds)
01:20:48  * esasjoined
01:58:49  * phpnodequit (Ping timeout: 258 seconds)
01:59:16  * SuperHeroINTJjoined
01:59:19  <SuperHeroINTJ>Hello.
01:59:49  <SuperHeroINTJ>Is "v8 people" happy about node.js fadding in favor of io.js?
02:07:45  <caitp->io.js is node.js
02:12:06  * phpnodejoined
02:20:32  * SuperHeroINTJquit (Quit: Leaving)
02:23:41  * enaqxjoined
02:31:39  * caitp-quit (Ping timeout: 244 seconds)
03:49:30  * caitp-joined
03:57:56  * caitp-quit (Ping timeout: 244 seconds)
04:37:06  * enaqxquit (Remote host closed the connection)
04:39:02  * enaqxjoined
04:54:24  * caitp-joined
04:58:54  * caitp-quit (Ping timeout: 244 seconds)
05:27:13  * mostynbjoined
06:43:21  * caitp-joined
06:47:55  * caitp-quit (Ping timeout: 244 seconds)
07:12:20  * enaqxquit (Remote host closed the connection)
07:19:24  * enaqxjoined
07:29:33  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check,OptimizeForSize" on http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/3790 "V8 Linux" from 5cb925e448e3646f6f3aa1e6baf9344846a750d8: [email protected])
07:36:38  <trungl-bot>Tree closed by [email protected]: Tree is closed. Fix coming up!
07:54:33  * Bob_Gneuquit (Ping timeout: 258 seconds)
07:54:45  <trungl-bot>Tree opened by [email protected]: Tree is open
08:08:10  * bnoordhuisjoined
08:29:58  * esasquit
08:31:56  * caitp-joined
08:36:25  * caitp-quit (Ping timeout: 244 seconds)
08:52:08  <trungl-bot>Tree closed by [email protected]: Tree is closed (yang looking into layout tests)
09:06:15  <trungl-bot>Tree opened by [email protected]: Tree is open (Rebaseline for layout tests is in flight)
09:08:26  * etnbrdjoined
09:11:42  * enaqxquit (Remote host closed the connection)
09:15:05  * enaqxjoined
09:18:51  * enaqxquit (Remote host closed the connection)
09:20:03  * enaqxjoined
09:33:01  * caitp-joined
09:37:23  * caitp-quit (Ping timeout: 244 seconds)
10:21:47  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/3127 "V8 Linux - nosnap" from 62b56507cce3c57a2e1aebce6d34f29b3b64e762: [email protected])
10:30:50  <trungl-bot>Tree opened by [email protected]: Tree is open
10:48:27  * caitp-joined
10:53:20  * caitp-quit (Ping timeout: 244 seconds)
10:54:32  * plutoniixquit (Quit: จรลี จรลา)
10:59:02  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/510 "V8 Linux - nosnap - debug - 2" from 629e9e4117494cc50b442378286befeef1225f15: [email protected],[email protected])
11:04:26  * enaqxquit (Remote host closed the connection)
11:16:31  * enaqxjoined
11:21:28  * enaqxquit (Remote host closed the connection)
11:23:12  <trungl-bot>Tree opened by [email protected]: Tree is open
11:24:35  * enaqxjoined
11:34:16  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2419 "V8 Linux - arm64 - sim - MSAN" from b53c35a797a37345a1f912ecd51baa651be911c6: [email protected],[email protected])
11:51:22  <trungl-bot>Tree opened by [email protected]: Tree is open
11:53:56  * etnbrdquit (Quit: etnbrd)
11:58:18  * bnoordhuisquit (Ping timeout: 265 seconds)
12:15:03  * C-Manjoined
12:19:21  * caitp-joined
12:23:45  * caitp-quit (Ping timeout: 244 seconds)
12:35:43  <trungl-bot>Tree closed by [email protected]: Tree is closed (infra problem)
12:47:03  * C-Manquit (Quit: Connection reset by beer)
12:56:55  <trungl-bot>Tree opened by [email protected]: Tree is open (reverted infra change)
13:05:07  * bnoordhuisjoined
13:09:38  * bnoordhuisquit (Ping timeout: 258 seconds)
13:11:53  * plutoniixjoined
13:12:01  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/507 "V8 Linux - nosnap - debug - 1" from f6fb5eb19796736cb414840652c9868693a5775a: [email protected],[email protected],[email protected])
13:21:06  * bobmcwjoined
13:23:07  <trungl-bot>Tree opened by [email protected]: Tree is open (ulan is looking in nosnap failure)
13:23:38  * jugglinmikejoined
13:23:51  * rmcilroyquit (Ping timeout: 265 seconds)
13:25:08  <trungl-bot>Tree closed by [email protected]: Tree is closed (ulan is looking in nosnap failure)
13:35:55  * rmcilroyjoined
13:39:05  * muellijoined
13:53:22  <trungl-bot>Tree opened by [email protected]: Tree is open
13:54:12  * jugglinmikequit (Quit: Leaving.)
13:54:14  * jugglinmike1joined
13:57:52  * caitp-joined
14:23:09  * jugglinmike1quit (Read error: Connection reset by peer)
14:23:11  * jugglinmikejoined
14:28:16  * caitp-quit (Ping timeout: 244 seconds)
14:33:58  * dpinojoined
14:35:18  * bnoordhuisjoined
14:36:13  * mostynbquit (Quit: Leaving)
14:39:51  <trungl-bot>Tree closed by [email protected]: Tree is closed (maintenance)
14:51:55  <trungl-bot>Tree opened by [email protected]: Tree is open
15:12:33  * jugglinmikequit (Read error: Connection reset by peer)
15:12:36  * jugglinmike1joined
15:17:19  * Bob_Gneujoined
15:24:17  * C-Manjoined
15:24:34  * caitp-joined
15:29:14  * caitp-quit (Ping timeout: 244 seconds)
15:43:37  * plutoniixquit (Quit: จรลี จรลา)
15:46:21  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/4261 "V8 Win32 - debug builder" from fe9a16b69a456fe629e9d118e16bee1525f54f74: [email protected])
15:49:23  <trungl-bot>Tree opened by [email protected]: Tree is open
16:04:47  * dpinoquit (Remote host closed the connection)
16:05:58  * dpinojoined
16:11:17  * caitp-joined
16:16:22  * enaqxquit (Remote host closed the connection)
16:20:06  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014])
16:22:15  * enaqxjoined
17:01:02  * ofrobotsjoined
17:02:19  * muelliquit (Ping timeout: 265 seconds)
17:19:21  * dpinoquit (Ping timeout: 240 seconds)
17:31:11  * enaqxquit (Remote host closed the connection)
17:41:13  * enaqxjoined
17:46:00  * enaqxquit (Remote host closed the connection)
17:46:14  * enaqxjoined
17:46:45  * enaqxquit (Remote host closed the connection)
17:50:55  <jugglinmike1>arv / caitp- If I start CQ on https://codereview.chromium.org/1153633003/ (and it passes) will the patch be merged? Or is there another step that I'm missing?
17:51:36  <caitp->should be
17:52:00  <caitp->you have checked stuff in already so I don't think you'll get hit by the authors/cla check
17:55:10  <jugglinmike1>kk. Am I missing something in the codereview UI that tells me, "CQ will be able to merge this if all the tests pass" ?
17:56:20  <caitp->does it say that?
17:56:32  <caitp->you might want to make sure the patch can merge cleanly on master though
17:56:36  <caitp->that could stop it form landing =)
17:56:47  <caitp->i'm like 99.99999% sure it will though
17:56:54  <jugglinmike1>couldn't hurt
17:57:00  <jugglinmike1>but the UI doesn't say anything like that, no
17:57:04  <jugglinmike1>I'm just curious
17:57:12  <jugglinmike1>because I know I can't land stuff to V8 on my own
17:57:44  <jugglinmike1>and I'm wondering if there is some visual indication that a given patch has been approved
17:57:50  <caitp->yeah the cq doesn't care if you have commit bit or not
17:57:54  <jugglinmike1>beyond Erik's informal "lgtm"
17:58:14  <caitp->i think gerrit or mondrian or one of them doesn't even care if you have an lgtm or not, but I'm pretty sure rietveld does
17:59:02  <jugglinmike1>Is that the technical criteria? I comment with the body text, "lgtm" ?
17:59:04  <arv>My lgtm should be enough for the commit queue
17:59:21  <bnoordhuis>it needs to be a lgtm from a project owner
17:59:23  <jugglinmike1>"*A* comment with [...]"
17:59:31  <arv>Yup... me
17:59:51  <jugglinmike1>ah, okay--so it's much more implicit than I expected
18:00:03  <caitp->yes, mine doesn't mean anything, but the green font looks good
18:00:21  <jugglinmike1>I was looking for some checkbox somewhere
18:00:22  <jugglinmike1>ohh
18:00:36  <bnoordhuis>i learned recently that "NOT LGTM" paints it a nice red
18:00:37  <jugglinmike1>so it highlights comments that contain "LGTM"
18:00:50  <jugglinmike1>should be "LBTM"
18:00:59  <jugglinmike1>:P
18:37:22  <arv>caitp-: What other options do we have besides undeclaring the bindings?
18:38:08  * akleinjoined
18:38:14  <caitp->they wanted to just modify the already declared variable
18:38:25  <arv>modify how?
18:38:49  <caitp->the set_mode() method of Variable is still in the CL even though it's not used right now --- but setting the mode to lexical is one thing
18:39:07  <caitp->the problem is, it's not as simple as just setting the mode, it makes allocation a lot more complicated
18:39:18  <caitp->so I think just redeclaring it is the simplest fix
18:39:46  <aklein>caitp-: I was thinking of a different approach as I read through this code. is there any reason we actually need to create the Variable at all in ParseFormalParameter?
18:39:47  <arv>I don't think we want that as a long term solution though
18:40:13  <arv>aklein: yeah, that sounds cleaner
18:40:18  <aklein>I guess I'm thinking of something close to "re-declaring" but without having to remove stuff from variables_
18:40:44  <aklein>the reason we declare in ParseFormalParameter seems to be entirely about catching duplicates
18:41:21  <caitp->yes
18:41:30  <aklein>caitp-: ([email protected] here, btw, in case that was unclear from my old-school nick)
18:42:27  <caitp->so, I think this is going to have to be refactored soon-ish anyways, just for binding patterns in formals
18:47:16  * enaqxjoined
18:49:55  <arv>caitp-: Most of the desugaring should just work for patterns too
18:50:10  <arv>the only diff is that params no longer are names but full ast nodes
18:50:37  <caitp->that's mainly what I'm getting at
18:50:50  <caitp->since once you do that, you need a new duplicate finding approach anyways
18:51:05  <caitp->and can't treat formals as a list of identifiers
18:52:01  * enaqxquit (Ping timeout: 256 seconds)
19:03:51  <aklein>caitp-: so it sounds like the debate is just about whether to refactor before or after adding support for parameter expressions?
19:04:28  <caitp->aklein, arv: yes, I think right now it's about as simple as it can be, for the subset of the feature that andreas wanted
19:04:48  <caitp->so I'd rather punt the refactoring until one of the followups, since it proved to be a bit trickier
19:08:33  <arv>I'm fine with this. This is behind a flag and we will not ship with it as is
19:11:16  <caitp->once this lands, there are a few fups: proper scoping, arity, reimplement rest params via desugaring, and the formal parsing fixups
19:11:41  <caitp->so there's lots left to do there
19:12:21  <arv>https://code.google.com/p/v8/issues/detail?id=4146 :-)
19:12:52  <caitp->bz left that same bug on spidermonkey too, you might want to just leave a comment on it
19:13:56  <arv>bug number?
19:14:04  <arv>nothing showed up when I searched
19:14:15  <caitp->sec
19:15:09  <caitp->1168257
19:16:07  <caitp->looks like he already marked it as invalid
19:17:27  <caitp->oh, I guess not
19:18:01  <caitp->so the v8 bug is unrelated, but he's convinced we're doing something wrong, might want to leave a comment
19:30:50  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
19:39:32  <caitp->arv: do you think --min-preparse-length=0 would trigger lazy parsing? I know it will lead to preparsing, but I'm not sure it prevents eager parsing
19:39:49  <caitp->but it is used in some of the lazy parsing tests
19:40:48  <arv>I remember Marja telling me to use a flag at one point... let me see which CL that was
19:41:53  <arv>https://codereview.chromium.org/923683002/diff/40001/test/mjsunit/harmony/classes-lazy-parsing.js
19:45:22  <caitp->it definitely will preparse that way, but I don't think it guarantees lazy parsing of the actual function
19:45:30  <caitp->hm
19:45:35  <caitp->well I'll try it
19:48:13  * esasjoined
19:51:03  * ofrobotsjoined
20:23:00  * bobmcwquit (Remote host closed the connection)
20:23:31  * bobmcwjoined
20:27:44  * bobmcwquit (Ping timeout: 245 seconds)
20:40:45  * C-Manquit (Quit: Connection reset by beer)
20:42:25  * C-Manjoined
20:49:49  * C-Manquit (Quit: Connection reset by beer)
21:37:33  * enaqxjoined
21:40:32  * daurnimatorquit (Ping timeout: 252 seconds)
21:41:45  * enaqxquit (Ping timeout: 250 seconds)
21:44:45  * daurnimatorjoined
21:48:56  * dpinojoined
21:54:31  * plutoniixjoined
22:00:40  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:24:19  * RT|Chatzillajoined
22:29:03  * plutoniixquit (Quit: จรลี จรลา)
22:42:51  * ofrobotsjoined
22:51:38  * enaqxjoined
23:27:44  * enaqxquit (Remote host closed the connection)
23:36:33  * bnoordhuisquit (Ping timeout: 240 seconds)
23:42:47  * dpinoquit (Ping timeout: 272 seconds)