00:25:56  * seventhquit (Ping timeout: 244 seconds)
00:29:06  * enaqxquit (Remote host closed the connection)
00:31:00  * enaqxjoined
00:35:05  * enaqxquit (Remote host closed the connection)
00:35:48  * enaqxjoined
00:36:12  * Bob_Gneuquit (Ping timeout: 264 seconds)
00:37:33  * Bob_Gneujoined
00:44:40  * scottmgquit (Ping timeout: 250 seconds)
00:52:47  * scottmg_quit (Ping timeout: 244 seconds)
01:32:14  * bradleymeckjoined
01:57:15  * jgiquit (Quit: jgi)
02:10:02  * xiinotulpchanged nick to plutoniix
02:34:02  * scottmg_joined
02:35:08  * scottmgjoined
02:51:03  * scottmgquit (Remote host closed the connection)
03:08:01  * scottmg_quit (Ping timeout: 246 seconds)
03:13:36  * bradleymeckquit (Quit: bradleymeck)
03:29:24  * jgijoined
04:10:30  * jgiquit (Quit: jgi)
05:14:36  * jgijoined
05:19:43  * jgiquit (Quit: jgi)
06:28:04  * terinjokesquit (Excess Flood)
06:28:35  * terinjokesjoined
06:42:54  * ager_joined
06:49:07  * ager_quit (Quit: Leaving)
07:20:31  * aperezdcjoined
07:24:33  * mostynbjoined
07:33:56  * aperezdcquit (Remote host closed the connection)
07:34:11  * aperezdcjoined
07:40:29  * aperezdcquit (Quit: aperezdc)
07:40:45  * aperezdcjoined
07:41:45  * rendarjoined
07:48:01  * JoWiejoined
07:56:28  * aperezdcquit (Ping timeout: 244 seconds)
07:59:36  * Net147quit (Ping timeout: 264 seconds)
08:00:42  * aperezdcjoined
08:04:53  * Net147joined
08:07:37  * enaqxquit
08:08:51  * enaqxjoined
08:09:06  * aperezdc_joined
08:09:49  * aperezdcquit (Read error: Connection reset by peer)
08:49:19  * aperezdc_quit (Quit: aperezdc_)
08:49:38  * aperezdcjoined
08:49:41  * aperezdcchanged nick to aperezdc_
09:04:34  * Net147quit (Ping timeout: 256 seconds)
09:09:09  * Net147joined
09:23:16  * aperezdc_changed nick to aperezdc
10:22:16  * enaqxquit (Remote host closed the connection)
10:22:23  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "gclient runhooks" on http://build.chromium.org/p/client.v8.fyi/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/563 "Linux ASan LSan Tests (1)" from cfbe3f64437c963bc36ba7f2644da871bafc8877: [email protected],[email protected])
10:30:00  * scottmg_joined
10:30:16  * scottmg_quit (Read error: Connection reset by peer)
10:35:28  <trungl-bot>Tree opened by [email protected]: Tree is open
10:43:17  * enaqxjoined
10:50:44  * bnoordhuisjoined
10:57:36  * bradleymeckjoined
11:01:31  * enaqxquit (Remote host closed the connection)
11:17:50  * enaqxjoined
11:26:04  * Net147quit (Ping timeout: 246 seconds)
11:28:22  * Net147joined
11:37:37  * Net147quit (Ping timeout: 246 seconds)
11:41:51  * Net147joined
11:49:57  * bradleymeckquit (Quit: bradleymeck)
11:53:44  * enaqxquit (Remote host closed the connection)
11:55:01  * bnoordhuisquit (Ping timeout: 264 seconds)
12:03:20  * enaqxjoined
12:05:27  * bradleymeckjoined
12:09:42  * danielijoined
12:24:22  * enaqxquit (Remote host closed the connection)
12:29:30  * enaqxjoined
12:46:43  <aperezdc>littledan: we have a LGTM by cbruni for this ToLength-related patch: https://codereview.chromium.org/1309243003/ but it needs an owner LGTM to keep the CQ happy
12:47:11  <aperezdc>littledan: I though you could you check it, provided that you were involved commenting in the associated bug
12:51:46  * bobmcwjoined
12:53:35  * bobmcwquit (Remote host closed the connection)
12:53:42  * bobmcwjoined
13:32:51  * davi_joined
13:33:15  * davi_changed nick to Guest62159
13:42:55  * Guest62159quit (Ping timeout: 246 seconds)
13:50:56  * C-Manjoined
14:11:43  * dchermanjoined
14:19:45  * davi__joined
14:27:18  * mostynbquit (Quit: Leaving)
14:42:37  * bradleymeckquit (Quit: bradleymeck)
14:45:01  * edwin_liujoined
14:46:18  * edwin_liu_joined
14:49:14  * edwin_liuquit (Ping timeout: 246 seconds)
14:58:06  * danieliquit (Quit: *does an epic backflip into nowhere*)
15:00:28  * enaqxquit (Remote host closed the connection)
15:17:48  * jgijoined
15:20:39  * jgiquit (Client Quit)
15:24:06  * jgijoined
15:31:34  * jgiquit (Quit: jgi)
15:47:42  * mostynbjoined
15:50:19  * bnoordhuisjoined
15:54:58  * bnoordhuisquit (Ping timeout: 268 seconds)
15:56:02  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014])
15:58:22  * davi__quit (Ping timeout: 246 seconds)
16:06:45  * jgijoined
16:10:33  * jgiquit (Client Quit)
16:12:14  * edwin_liu_quit (Remote host closed the connection)
16:12:41  * edwin_liujoined
16:17:58  * mostynbquit (Quit: Leaving)
16:18:08  * bnoordhuisjoined
16:24:59  * bradleymeckjoined
16:34:25  * edwin_liuquit (Remote host closed the connection)
16:39:06  * davi_joined
16:39:30  * davi_changed nick to Guest45512
17:42:51  <littledan>aprezdc, so how did you do performance testing now?
17:42:56  <littledan>so that you actually hit the path
17:43:07  <littledan>or is the idea that you don't need that?
17:43:12  <littledan>aperezdc
17:56:43  * ncthom91joined
17:58:00  * ncthom91quit (Client Quit)
17:58:48  * dcherman2joined
18:00:08  <caitp>do you know if TF/crankshaft have fast-paths for this stuff? eg "if it's an smi, inline it, if it's anything else deopt/runtime/whatever"
18:00:26  <caitp>for cold code it shouldn't matter a whole lot how slow ToLength is
18:00:51  * bradleymeckquit (Quit: bradleymeck)
18:01:55  * dchermanquit (Ping timeout: 246 seconds)
18:02:37  * dchermanjoined
18:03:28  * dcherman2quit (Ping timeout: 256 seconds)
18:03:53  * bradleymeckjoined
18:04:33  <littledan>there's not currently a ToLength-specific fastpath, but benedikt plans to do one
18:06:45  <caitp>I meant more for ToUint32(), since thats been around longer
18:08:48  <littledan>well, ToUint32 is different since the TO_UINT32 macro expands to >>> 0
18:09:00  <littledan>which should have a different SMI path
18:09:27  <littledan>there's no easy macro expansion for ToLength, but it'll get special treatment as an intrinsic
18:15:08  <caitp>I implemented the slow one in the tree now for one of the newer stdlib methods, I agree it doesn't really lend itself to a macro :( but I think the common case is that anything being ToLength()'d is going to be a number, and probably an integer
18:15:28  <caitp>probably a positive integer, at that
18:16:21  <caitp>the 2^53-1 values can't be encoded as Smi iirc, but those seem pretty rare in practice
18:17:28  <littledan>yeah, I think the solution is straightforward, it's just a bunch of work to teach the compilers about it
18:41:49  * bnoordhuisquit (Ping timeout: 250 seconds)
18:42:08  * Bob_Workjoined
18:44:16  * Guest45512quit (Ping timeout: 246 seconds)
18:51:35  <aperezdc>littledan: from cbruni's comment in the review I understand that it won't be a problem
18:52:09  <aperezdc>he mentioned that there was some similar issue with Regexp at some point, but there there was no fast path
18:52:28  <aperezdc>and in the case of arrays there's fast paths in C++
18:53:55  <aperezdc>as for doing an inline %_ToLength, I stumbled upon a CL earlier today
18:54:48  <aperezdc>https://codereview.chromium.org/1314493005/
18:55:18  <aperezdc>littledan: ↑↑ dat one, by bmeurer ~2 weeks ago, but had issues
18:55:34  * enaqxjoined
18:55:41  <aperezdc>maybe I could take it and see if I can figure out how to solve the issues he was having there
18:56:00  <littledan>aperezdc, I believe Benedikt is taking a deeper approach
18:56:11  <littledan>adamk's patch may solve some of the problems but not all
18:56:29  <littledan>I'd get in touch with Benedikt
18:56:51  <aperezdc>yeah, seems so, now that I'm reading the comments from that review in full
18:57:25  <aperezdc>maybe the best thing will be to talk to him and coordinate a bit, yeah
19:00:01  * dcherman2joined
19:00:38  * bnoordhuisjoined
19:02:49  * dchermanquit (Ping timeout: 264 seconds)
19:14:10  <aperezdc>littledan: anyway, I think I'll do tomorrow anyway a benchmark that hits the flagged ToLength... now it's getting a bit late in this side of the pond
19:14:14  <aperezdc>O:-)
19:14:27  <littledan>sounds good, sleep well
19:18:41  <aperezdc>littledan: thanks!
19:19:31  * aperezdcquit (Quit: aperezdc)
19:44:46  * rendarquit (Ping timeout: 250 seconds)
19:46:30  * bradleymeckquit (Quit: bradleymeck)
19:49:38  * dchermanjoined
19:50:52  * rendarjoined
19:51:42  * dcherman2quit (Ping timeout: 256 seconds)
20:02:25  * JoWiequit (Quit: Connection closed for inactivity)
20:03:07  * bobmcwquit (Remote host closed the connection)
20:05:33  * dcherman2joined
20:07:06  * edwin_liujoined
20:08:34  * dchermanquit (Ping timeout: 244 seconds)
20:08:34  * davi_joined
20:08:58  * davi_changed nick to Guest76938
20:09:52  * C-Manquit (Quit: Connection reset by beer)
20:11:25  * dcherman2quit (Ping timeout: 246 seconds)
20:13:02  <trungl-bot>Tree closed by [email protected]: Tree is closed (maintenance)
20:14:56  * dchermanjoined
20:22:00  * dchermanquit (Ping timeout: 252 seconds)
20:22:07  <trungl-bot>Tree opened by [email protected]: Tree is open
20:23:11  * bradleymeckjoined
20:23:47  * dcherman2joined
20:36:02  * edwin_liuquit (Read error: Connection reset by peer)
21:01:49  * Guest76938quit (Ping timeout: 246 seconds)
21:09:01  * bnoordhuisquit (Read error: Connection reset by peer)
21:09:18  * bnoordhuisjoined
21:30:14  * jgijoined
22:22:30  * jgiquit (Quit: jgi)
22:33:10  * RT|Chatzillajoined
22:44:27  * dcherman2quit (Ping timeout: 260 seconds)
22:49:49  * jgijoined
22:51:29  * jgiquit (Client Quit)
22:53:50  * jgijoined
22:58:07  * jgiquit (Client Quit)
23:08:50  * rendarquit
23:15:10  * dchermanjoined
23:20:12  * bnoordhuisquit (Ping timeout: 268 seconds)
23:21:51  * Bob_Workquit
23:33:08  * xiinotulpjoined
23:36:51  * plutoniixquit (Ping timeout: 268 seconds)
23:43:38  * dchermanquit (Ping timeout: 268 seconds)