00:00:43  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
00:02:24  * ofrobotsjoined
00:03:52  * ncthom91quit (Quit: Textual IRC Client: www.textualapp.com)
00:03:52  * chrisdickinsonquit (Excess Flood)
00:04:02  * chrisdickinsonjoined
00:05:48  * phpnodequit (Ping timeout: 272 seconds)
00:15:38  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
00:22:10  * ofrobotsjoined
00:27:31  * JoWiequit (Quit: Connection closed for inactivity)
00:42:09  * bobmcwjoined
00:47:08  * bobmcwquit (Ping timeout: 276 seconds)
01:18:04  * rendarquit (Quit: std::lower_bound + std::less_equal *works* with a vector without duplicates!)
01:24:44  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
01:29:04  * ofrobotsjoined
01:37:49  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
01:38:44  * phpnodejoined
01:43:32  * ofrobotsjoined
01:48:02  * ofrobotsquit (Ping timeout: 250 seconds)
02:03:14  * dpinoquit (Ping timeout: 260 seconds)
02:03:21  * xiinotulpchanged nick to plutoniix
02:03:36  * dpino_quit (Ping timeout: 272 seconds)
02:35:52  * evanlucasquit (Read error: Connection reset by peer)
02:36:46  * evanlucasjoined
03:08:41  * jgiquit (Quit: jgi)
03:13:19  * evanlucasquit (Quit: Textual IRC Client: www.textualapp.com)
03:13:39  * evanlucasjoined
03:14:42  * mellocquit (Quit: Leaving.)
04:06:35  * esasquit (Ping timeout: 240 seconds)
04:37:12  * ofrobotsjoined
04:39:03  * mellocjoined
04:43:03  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
04:45:23  * bobmcwjoined
04:50:02  * bobmcwquit (Ping timeout: 250 seconds)
04:58:08  * ofrobotsjoined
05:14:22  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
05:16:08  * esasjoined
05:31:11  * ofrobotsjoined
05:34:23  * jgijoined
05:38:21  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
05:43:03  * ofrobotsjoined
06:27:13  <trungl-bot`>Tree closed by [email protected]: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/2862 "V8-Blink Linux 32" from ceade6cf239e0773213d53d55c36b19231c820b5: [email protected])
06:30:14  <trungl-bot`>Tree opened by [email protected]: Tree is open (Blink broken)
06:32:01  * davijoined
06:35:51  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
06:36:13  * ofrobotsjoined
07:14:13  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
07:30:13  * bnoordhuisjoined
07:30:25  * C-Manjoined
07:38:41  * bnoordhuisquit (Ping timeout: 244 seconds)
07:56:17  * AndreasMadsenjoined
08:04:32  * mostynbjoined
08:08:47  * daviquit (Ping timeout: 246 seconds)
08:13:32  * davijoined
08:17:18  * jgiquit (Quit: jgi)
08:26:30  * JoWiejoined
08:28:01  <trungl-bot`>Tree closed by [email protected]: Tree is closed (maintenance)
08:45:03  * C-Manquit (Quit: Connection reset by beer)
08:46:28  * rendarjoined
08:48:08  <trungl-bot`>Tree closed by [email protected]: Tree is closed (waiting for nosnap fix)
08:57:11  <trungl-bot`>Tree closed by [email protected]: Tree is closed (maintenance)
09:03:19  * daviquit (Ping timeout: 272 seconds)
09:13:42  * AndreasMadsenquit (Remote host closed the connection)
09:22:02  * plutoniixquit (Quit: จรลี จรลา)
09:23:23  <trungl-bot`>Tree opened by [email protected]: open
09:36:02  * plutoniixjoined
09:39:41  * AndreasMadsenjoined
09:40:49  * AndreasMadsenquit (Remote host closed the connection)
09:56:37  * AndreasMadsenjoined
09:57:05  * AndreasMadsenquit (Remote host closed the connection)
10:01:07  * dpinojoined
10:01:42  * dpino_joined
10:05:44  * AndreasMadsenjoined
10:43:03  * evanluca_joined
10:44:01  * evanlucasquit (Read error: Connection reset by peer)
10:48:25  * bobmcwjoined
10:48:34  * bobmcwquit (Changing host)
10:48:34  * bobmcwjoined
10:51:59  <trungl-bot`>Tree closed by [email protected]: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/8161 "V8 Arm - builder" from 0ec6db4750190014d1442a6929808d32ed281f9e: [email protected])
10:53:59  * bobmcwquit (Ping timeout: 244 seconds)
11:02:03  <trungl-bot`>Tree opened by [email protected]: open (infra patch reverted)
11:24:09  * AndreasMadsenquit
11:32:25  * davijoined
12:09:10  * bnoordhuisjoined
12:27:31  * JoWiequit (Quit: Connection closed for inactivity)
12:38:04  * JoWiejoined
13:02:35  * bnoordhuisquit (Ping timeout: 264 seconds)
13:25:34  * bnoordhuisjoined
13:30:10  * bnoordhuisquit (Ping timeout: 260 seconds)
13:47:17  * kenansulaymanjoined
13:47:41  * kenansulaymanchanged nick to Guest24537
13:51:57  * bobmcwjoined
13:56:45  * bobmcwquit (Remote host closed the connection)
13:56:51  * bobmcwjoined
13:56:51  * bobmcwquit (Changing host)
13:56:51  * bobmcwjoined
14:01:59  * littledan_quit (Read error: Connection reset by peer)
14:02:26  * littledan_joined
14:30:08  * ofrobotsjoined
14:45:24  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
14:54:50  * ofrobotsjoined
15:03:11  * daviquit (Ping timeout: 246 seconds)
15:34:43  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
15:37:43  * bradleymeckjoined
15:58:29  * ofrobotsjoined
16:05:43  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:08:15  * circ-user-mk9TAquit (Ping timeout: 240 seconds)
16:12:31  * ofrobotsjoined
16:15:42  * mostynbquit (Quit: Leaving)
16:19:37  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:20:17  * circ-user-mk9TAjoined
16:23:08  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014])
16:39:04  * AndreasMadsenjoined
16:52:42  * ncthom91joined
17:06:34  * jgijoined
17:06:59  * jgiquit (Client Quit)
17:08:30  <trungl-bot`>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/6479 "V8 Linux64 TSAN" from cf7614d5fe34c529c4e49ed98f62fac311204674: [email protected])
17:14:28  * bradleymeckquit (Quit: bradleymeck)
17:14:42  * mellocquit (Quit: Leaving.)
17:21:00  * ofrobotsjoined
17:27:33  * bradleymeckjoined
17:33:52  * jgijoined
17:36:09  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
17:38:44  <trungl-bot`>Tree opened by [email protected]: Tree is open (TSAN failure apparently from failed script, not from a test fail)
17:41:59  * ofrobotsjoined
17:49:02  * bradleymeckquit (Quit: bradleymeck)
17:53:34  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
18:00:35  * ofrobotsjoined
18:02:05  * mellocjoined
18:07:26  * bradleymeckjoined
18:12:46  * bradleymeckquit (Quit: bradleymeck)
18:13:48  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
18:15:41  * bradleymeckjoined
18:21:16  * ofrobotsjoined
18:24:43  * bradleymeckquit (Quit: bradleymeck)
18:32:37  * AndreasMadsenquit (Remote host closed the connection)
18:44:30  * bradleymeckjoined
18:45:10  * bradleymeckquit (Client Quit)
19:07:10  * bradleymeckjoined
19:07:31  * bradleymeckquit (Client Quit)
19:09:18  * davijoined
19:13:55  * bradleymeckjoined
19:18:35  * jgiquit (Quit: jgi)
19:19:33  * daviquit (Ping timeout: 272 seconds)
19:23:30  * jgijoined
19:43:35  * AndreasMadsenjoined
19:44:31  * AndreasMadsenquit (Client Quit)
19:55:55  * esasquit (Ping timeout: 240 seconds)
20:01:07  * bradleymeckquit (Quit: bradleymeck)
20:08:42  <caitp>aklein: I'll try to explain with an example: ordinarily, the original Assignment with the AssignmentPattern LHS should be completely replaced with the rewritten expression --- but unfortunately that can't really happen, since there's no way to know how to replace the Assignment with the rewritten node in the AST. So the AssignmentPattern LHS is a stand-in which holds the rewritten node instead
20:08:51  <caitp>I guess that's not really an example
20:11:40  * bnoordhuisjoined
20:13:58  <caitp>but yeah, the Assignment might be a child of an ExpressionStatement, or a BinaryOperation, or a IterationStatement part, or something else
20:14:04  <aklein>caitp: are you just trying to keep Assignment from getting bigger?
20:14:55  <caitp>I'm trying to express that "this node in the AST is no longer what it used to be, it's been rewritten into something else, and there was no way to structurally replace the original node in the tree"
20:15:39  <aklein>I undertand that. I'm asking why "is_rewritten()" is a method on AssignmentPattern instead of Assignment
20:15:48  <caitp>oh, I see
20:16:12  <caitp>well it could be a part of Assignment or AstNode in general, I guess
20:17:13  <caitp>is_rewritten is in AssignmentPattern to make sure things that were dealt with by BindingPatterns don't get processed again later
20:18:17  * bradleymeckjoined
20:20:29  <caitp>really hoping ignition allows doing all of this stuff in a simpler way, similar to how jsc's bytecode generator does, but it seems like it would be a lot of work for the compilers to deal with the ignition bytecode instead of the AST, much better place to do desugaring
20:21:13  <aklein>hmm, let me read your change to PatternRewriter::VisitAssignment
20:21:55  <aklein>sadly I don't think we can block this on Ignition
20:22:48  <caitp>no, but it might allow simplifying it a lot later
20:23:16  <aklein>yep, there's definitely hope that Ignition being full-featured could change a lot about the internals
20:23:32  <aklein>e.g., what if we didn't always have to re-parse?
20:24:39  * bradleymeckquit (Quit: bradleymeck)
20:25:52  <aklein>given that PatternRewriter::VisitAssignmentPattern() is always called from PatternRewriter::VisitAssignment(), it seems like it would be perfectly easy to detect the already-rewritten case there.
20:34:23  <caitp>yes, the "don't rewrite this" could live there rather than in the rewrite-all-these-assignments thing
20:45:01  <aklein>it just seems more intuitive to me that it's the Assignment that gets rewritten and holds the rewritten expression
20:45:25  <aklein>I realize that from your point of view this might seem like six-of-one, half a dozen of the other
20:45:59  <aklein>but from reading the code the current structure is surprising (and as I noted, makes full-codegen look broken, in the we only visit the target and drop the value on the floor)
20:46:02  * dpinoquit (Ping timeout: 265 seconds)
20:46:23  <aklein>I also realize this is way uglier than having the AST _actually_ rewritten :/
20:46:23  * dpino_quit (Ping timeout: 264 seconds)
20:47:30  <caitp>I'm just not sure what the difference is, really --- in either case, you still have to mark some part of the Assignment as rewritten and avoid doing any of the normal Assignment work
20:47:39  <caitp>it's just changing where the "this is rewritten" marker lives
20:47:55  * rendarquit (Ping timeout: 240 seconds)
20:48:47  <caitp>like, the rewritten expression doesn't become a valid assignment target or anything, so you couldn't just plug it into the normal assignment flow
20:50:57  * bradleymeckjoined
20:51:09  * davi_joined
20:51:33  * davi_changed nick to Guest70988
20:53:00  <caitp>obviously, I want this to make sense, it's just the way the parser and compilers/codegenerators relationships to the AST works right now, it doesn't seem exactly possible to avoid some kind of hack in VisitAssignment() :(
20:54:46  * rendarjoined
21:00:30  * dpino_joined
21:00:49  * bradleymeckquit (Quit: bradleymeck)
21:02:00  * dpinojoined
21:02:26  * ncthom91quit (Ping timeout: 240 seconds)
21:11:01  * ncthom91joined
21:11:55  * bnoordhuisquit (Ping timeout: 244 seconds)
21:38:48  * bnoordhuisjoined
21:41:08  * Guest70988quit (Ping timeout: 246 seconds)
21:47:15  * bnoordhuisquit (Ping timeout: 240 seconds)
21:53:39  * ghostbobquit (Read error: Connection reset by peer)
21:58:19  * jgiquit (Quit: jgi)
21:58:51  <sfuentes>I'm trying to understand how v8 scavenges work. My understanding is that a scavenge occurs when the new-space is full (allocation failure), but i'm having trouble seeing this in practice
21:59:59  <sfuentes>I posted this question with details and output on http://stackoverflow.com/q/33780781/10708 ... I see four scavenges but I was expecting only one. Am I missing something?
22:02:55  * bradleymeckjoined
22:06:40  * bradleymeckquit (Client Quit)
22:21:37  * ofrobotsquit (Quit: Textual IRC Client: www.textualapp.com)
22:24:19  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
22:27:18  * ofrobotsjoined
22:39:46  * evanluca_changed nick to evanlucas
22:43:09  * dpinoquit (Ping timeout: 255 seconds)
22:43:23  * dpino_quit (Ping timeout: 276 seconds)
22:43:34  * dpinojoined
22:43:49  * dpino_joined
22:48:18  * RT|Chatzillajoined
22:49:06  * scottmgquit (Ping timeout: 240 seconds)
22:50:06  * jochen__quit (Ping timeout: 240 seconds)
22:53:08  * bradleymeckjoined
22:55:25  * jgijoined
22:55:30  * bradleymeckquit (Client Quit)
23:25:27  * bobmcwquit (Remote host closed the connection)
23:35:50  * dpino_quit (Ping timeout: 240 seconds)
23:36:15  * dpinoquit (Ping timeout: 255 seconds)
23:50:42  * ofrobotsquit (Read error: Connection reset by peer)
23:54:35  * xiinotulpjoined
23:56:03  * plutoniixquit (Ping timeout: 255 seconds)