00:10:56  * bnoordhuisquit (Ping timeout: 255 seconds)
00:20:52  * watildequit (Remote host closed the connection)
00:30:44  * evanluca_quit (Quit: Textual IRC Client: www.textualapp.com)
00:34:11  * jgijoined
00:41:24  * BobGneuquit (Ping timeout: 250 seconds)
00:41:54  * bobmcwjoined
00:41:54  * bobmcwquit (Changing host)
00:41:54  * bobmcwjoined
00:48:06  * bobmcwquit (Ping timeout: 240 seconds)
00:50:20  * mounibecquit (Quit: My Mac has gone to sleep. ZZZzzz…)
00:58:03  * rendarquit (Quit: std::lower_bound + std::less_equal *works* with a vector without duplicates!)
01:06:11  * jgiquit (Quit: jgi)
01:18:35  * C-Manquit (Quit: Connection reset by beer)
01:21:25  * watildejoined
01:26:28  * watildequit (Ping timeout: 256 seconds)
01:28:35  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
02:00:18  * jugglinmike2quit (Ping timeout: 255 seconds)
02:22:47  * ofrobotsjoined
02:31:11  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
02:42:41  * bradleymeckjoined
02:47:28  * bradleymeckquit (Client Quit)
03:05:16  * aperezdc_joined
03:12:05  * aperezdcquit (*.net *.split)
03:12:05  * srl295quit (*.net *.split)
03:12:05  * kenansulaymanquit (*.net *.split)
03:12:05  * sxa__quit (*.net *.split)
03:22:08  * srl295joined
03:22:08  * kenansulaymanjoined
03:22:08  * sxa__joined
03:23:33  * watildejoined
03:24:51  * eseidelquit (Ping timeout: 260 seconds)
03:26:12  * eseideljoined
03:28:55  * watildequit (Ping timeout: 240 seconds)
03:30:12  * xiinotulpchanged nick to plutoniix
04:31:27  * bradleymeckjoined
04:37:25  * ofrobotsjoined
04:37:58  * bobmcwjoined
04:43:29  * bobmcwquit (Ping timeout: 245 seconds)
04:51:19  <trungl-bot`>Tree closed by [email protected]: Tree is closed (Automatic: "Test262 - no variants" on http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/7528 "V8 Win64" from 5766f90ee7af566d6d147a5ab0f5ce2057ea26b7: [email protected])
05:04:43  * bradleymeckquit (Quit: bradleymeck)
05:16:14  * evanlucasjoined
05:26:28  * watildejoined
05:31:31  * watildequit (Ping timeout: 260 seconds)
05:43:40  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
05:48:27  * ofrobotsjoined
05:55:33  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
06:23:34  * ofrobotsjoined
06:26:36  * ofrobotsquit (Client Quit)
06:29:35  * thefourtheye__quit (Quit: Connection closed for inactivity)
07:28:06  * watildejoined
07:33:06  * watildequit (Ping timeout: 240 seconds)
07:47:12  * davijoined
08:41:34  * bobmcwjoined
08:46:59  * bobmcwquit (Ping timeout: 264 seconds)
08:52:42  * evanlucasquit (Quit: Textual IRC Client: www.textualapp.com)
09:30:15  * watildejoined
09:35:26  * watildequit (Ping timeout: 276 seconds)
10:07:09  * watildejoined
10:27:57  <trungl-bot`>Tree opened by [email protected]: open
10:33:15  * esasquit
10:37:11  * rendarjoined
10:49:59  * mounibecjoined
11:16:30  * mounibecquit (Quit: My Mac has gone to sleep. ZZZzzz…)
11:18:17  * mounibecjoined
11:18:20  * mounibecquit (Client Quit)
11:38:02  * watildequit (Ping timeout: 246 seconds)
11:38:43  * watildejoined
12:03:43  * bnoordhuisjoined
12:29:12  * ofrobotsjoined
12:44:32  * bobmcwjoined
12:49:15  * bobmcwquit (Ping timeout: 240 seconds)
13:29:14  * C-Manjoined
13:40:10  * watildequit (Remote host closed the connection)
13:43:06  * watildejoined
13:48:59  * watildequit (Remote host closed the connection)
14:00:06  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
14:23:25  * daviquit (Ping timeout: 260 seconds)
14:52:20  * aperezdc_changed nick to aperezdc
15:17:15  * bnoordhuisquit (Ping timeout: 255 seconds)
15:41:38  * ncthom91joined
15:42:08  * watildejoined
15:43:15  * rosseauxquit (Excess Flood)
15:43:33  * bnoordhuisjoined
15:43:46  * rosseauxjoined
15:44:15  * C-Manquit (Ping timeout: 255 seconds)
15:47:08  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
15:49:42  * C-Manjoined
15:51:50  * bnoordhuisquit (Ping timeout: 245 seconds)
15:54:34  * ncthom91joined
16:00:14  * ofrobotsjoined
16:02:35  * C-Manquit (Ping timeout: 264 seconds)
16:05:57  * C-Manjoined
16:09:37  * bradleymeckjoined
16:12:47  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014])
16:16:42  * C-Manquit (Remote host closed the connection)
16:16:53  * C-Manjoined
16:25:25  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:29:56  * ofrobotsjoined
16:34:41  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
16:36:43  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
16:38:19  * ofrobotsjoined
16:39:17  * bnoordhuisjoined
16:54:53  <bnoordhuis>caitp: you added spread params support, didn't you? could it be it's not very optimized right now?
16:56:00  <caitp>it's not optimized at all, afaik
16:56:34  <bnoordhuis>if i follow the logic right, it always does a flatten pass over the remaining arguments?
16:56:44  <bnoordhuis>or is there a shortcut for when there's only a single ...args?
16:58:07  <bnoordhuis>looking at Parser::PrepareSpreadArguments, i think the answer is 'yes'
16:58:13  <caitp>are we talking about rest or spread?
16:58:56  <bnoordhuis>rest. maybe i've been following the wrong code path
16:59:14  <bnoordhuis>is the code in src/js/spread.js called for rest params?
16:59:18  <caitp>there is work being done on optimizing rest parameters
16:59:23  <caitp>no
17:00:15  <caitp>spread is basically build an Array and pass to Reflect.apply()
17:00:28  <caitp>not very optimal
17:00:54  <bnoordhuis>ah okay. i think i've found the relevant code in full-codegen-x64.cc now
17:00:59  <caitp>it's hard to fix that, but probably it will be sped up for at least certain cases
17:04:59  <bnoordhuis>i guess i was confused because i couldn't figure out where the rest array is allocated
17:05:20  <bnoordhuis>found it though: RestParamAccessStub -> Runtime_NewRestParam -> NewRestArguments
17:06:59  <caitp>basically is back to the original implementation i did last year
17:07:08  <caitp>for a while it was changed to a desugaring approach which could have worked a lot faster, but compiler team thought that made it harder for them to optimize
17:07:42  <bnoordhuis>that's how i remembered it working
17:08:03  <bnoordhuis>shame. i was pushing for use of rest params in node core
17:08:29  <bnoordhuis>but people pointed out it's too slow compared to the arguments object
17:08:46  <caitp>that's a short term problem though
17:08:57  <caitp>they do have good ideas on how to improve it
17:09:33  <bnoordhuis>it'll probably be a while before we can profit from that in node though
17:09:56  <caitp>for hot functions, probably
17:10:09  <caitp>I'd say use it in less hot code though
17:10:29  <caitp>that would help provide some performance metrics
17:10:40  <caitp>for real code instead of bad benchmarks
17:10:45  <bnoordhuis>the code in question i would describe as 'tepid'
17:12:14  <bnoordhuis>possibly 'lukewarm'. used just enough to not allow for much slack
17:13:15  <caitp>so is the reason to avoid using it because of perf impact on real allocation?
17:13:45  <caitp>application*
17:15:19  <bnoordhuis>yes. fan-out effect: if something in node core is slow, then so are all programs using it
17:15:59  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
17:16:07  <bnoordhuis>not that core isn't heinously inefficient in some places but that's a separate discussion
17:16:37  <caitp>so, how measurable is the impact, and how was this determined?
17:17:13  * ofrobotsjoined
17:17:40  <bnoordhuis>i don't know, but trevnorris might
17:18:45  * ofrobotsquit (Client Quit)
17:19:12  <caitp>mm, they are relatively slow, compared to how it could be implemented via desugaring
17:19:25  <caitp>but for the vast majority of uses, out isn't noticeable
17:20:15  <caitp>anyway, things to do, good luck with the node stuff
17:20:25  * ofrobotsjoined
17:22:25  * bradleymeckquit (Quit: bradleymeck)
17:24:09  * dobson`quit (Ping timeout: 250 seconds)
17:25:16  * ofrobotsquit (Ping timeout: 256 seconds)
17:30:27  * dobsonjoined
17:30:36  * bradleymeckjoined
17:30:52  * JoWiejoined
17:33:09  * C-Manquit (Quit: Connection reset by beer)
17:35:05  * C-Manjoined
17:35:39  * bradleymeckquit (Quit: bradleymeck)
17:36:01  * ofrobotsjoined
17:40:36  * bradleymeckjoined
17:42:07  * ofrobotsquit (Ping timeout: 265 seconds)
17:44:10  * bradleymeckquit (Client Quit)
17:59:35  * bradleymeckjoined
18:04:21  * bobmcwjoined
18:04:45  * bradleymeckquit (Quit: bradleymeck)
18:09:09  * bobmcwquit (Ping timeout: 255 seconds)
18:28:16  * ofrobotsjoined
18:31:10  * ofrobotsquit (Client Quit)
18:43:33  * ofrobotsjoined
18:54:32  * watildequit (Remote host closed the connection)
19:05:37  * bradleymeckjoined
19:05:40  * watildejoined
19:06:07  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
19:51:17  * evanlucasjoined
20:02:30  * evanlucasquit (Quit: Textual IRC Client: www.textualapp.com)
20:02:56  * evanlucasjoined
20:19:16  * ofrobotsjoined
20:27:58  * bradleymeckquit (Quit: bradleymeck)
20:55:40  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
20:57:22  * ofrobotsjoined
21:07:06  * davijoined
21:07:06  * daviquit (Changing host)
21:07:06  * davijoined
21:27:16  * jugglinmikejoined
21:40:15  * daviquit (Ping timeout: 250 seconds)
21:45:02  * evanluca_joined
21:45:10  * evanlucasquit (Read error: Connection reset by peer)
21:49:17  * jugglinmikequit (Ping timeout: 276 seconds)
21:51:02  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
21:54:29  * ofrobotsjoined
21:55:11  * xiinotulpjoined
21:58:46  * plutoniixquit (Ping timeout: 265 seconds)
22:00:07  * esasjoined
22:24:26  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:36:56  * ncthom91joined
22:39:47  * ofrobotsjoined
22:40:38  * rendarquit (Ping timeout: 276 seconds)
22:46:36  * rendarjoined
22:48:45  * ofrobotsquit (Quit: My Mac has gone to sleep. ZZZzzz…)
22:52:10  * ofrobotsjoined
22:52:42  * ncthom91quit (Quit: My MacBook has gone to sleep. ZZZzzz…)
22:56:43  * watildequit (Remote host closed the connection)
23:02:29  * watildejoined
23:15:45  * ofrobotsquit (Quit: Textual IRC Client: www.textualapp.com)
23:16:13  * RT|Chatzillajoined
23:46:24  * watildequit (Remote host closed the connection)
23:58:42  * bradleymeckjoined