00:00:43
| * mostynb | quit (Quit: Leaving) |
00:00:58
| * ofrobots | joined |
00:24:57
| <xaxxon> | hrmmm... SetFlagsFromCommandLine is working, but I can't seem to figure out hw to use the SetFlagsFromString version... should: v8::V8::SetFlagsFromString("--expose-gc", strlen("--expose-gc")); work? I tried that and without the --'s. Or is it not allowed to call both the CmmandLine and String versions ? |
00:27:09
| <xaxxon> | huh. Seems like they're mutually exclusive.. weird and sad |
00:27:42
| <xaxxon> | never mind. |
00:27:46
| <xaxxon> | sometheing weird is going on |
00:29:57
| * bradleymeck | joined |
01:01:21
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
01:07:35
| * plutoniix | joined |
01:08:07
| * ofrobots | joined |
01:23:05
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
01:32:49
| * ofrobots | joined |
01:43:57
| * C-Man | quit (Quit: Connection reset by beer) |
02:02:51
| * jgi | quit (Quit: jgi) |
02:25:49
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
02:49:22
| * jugglinmike1 | quit (Ping timeout: 272 seconds) |
03:48:15
| * plutoniix | quit (Quit: จรลี จรลา) |
03:49:23
| * ofrobots | joined |
03:53:43
| * plutoniix | joined |
04:08:19
| * bradleymeck | quit (Quit: bradleymeck) |
04:39:34
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
04:55:24
| * watilde | joined |
05:01:11
| * watilde | quit (Ping timeout: 255 seconds) |
05:10:36
| * bradleymeck | joined |
05:21:47
| * luite | quit (Ping timeout: 276 seconds) |
05:21:54
| * luite | joined |
05:55:26
| * ofrobots | joined |
05:56:32
| * watilde | joined |
05:57:47
| * plutoniix | quit (Read error: Connection reset by peer) |
06:03:25
| * plutoniix | joined |
06:10:07
| * jgi | joined |
06:12:44
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
06:15:17
| * jgi | quit (Quit: jgi) |
06:15:53
| * jgi | joined |
06:17:34
| * xaxxon | quit (Read error: Connection reset by peer) |
06:17:36
| * xaxxon_ | joined |
06:23:10
| * xaxxon_ | part ("Leaving") |
07:09:20
| * bradleymeck_ | joined |
07:11:11
| * watilde | quit (Remote host closed the connection) |
07:11:14
| * bradleymeck | quit (Ping timeout: 255 seconds) |
07:11:51
| * bradleymeck_ | quit (Read error: Connection reset by peer) |
07:13:26
| * bradleymeck | joined |
07:16:23
| * bradleymeck | quit (Client Quit) |
07:16:45
| * jgi | quit (Quit: jgi) |
07:21:40
| * ofrobots | joined |
07:22:16
| * ofrobots | quit (Client Quit) |
07:27:09
| * bradleymeck | joined |
07:27:10
| * bradleymeck | quit (Client Quit) |
08:31:38
| * mostynb | joined |
08:37:11
| * mostynb | quit (Ping timeout: 255 seconds) |
08:49:42
| * mostynb | joined |
08:58:19
| * rendar | joined |
09:01:06
| * esas | quit (Ping timeout: 240 seconds) |
09:18:08
| * bnoordhuis | joined |
10:33:38
| * petka____ | joined |
10:52:39
| * plutoniix | quit (Quit: จรลี จรลา) |
11:45:46
| * bnoordhuis | quit (Ping timeout: 240 seconds) |
12:41:02
| * plutoniix | joined |
12:52:26
| * bnoordhuis | joined |
12:57:16
| * bnoordhuis | quit (Ping timeout: 256 seconds) |
13:14:36
| <trungl-bot`> | Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/306 "V8 Arm - debug" from 24a8476904c8ff8bcc414cc9e6f87435ce3e99d5: [email protected]) |
13:25:41
| <trungl-bot`> | Tree opened by [email protected]: open |
13:48:28
| * Bob_Gneu | joined |
13:49:15
| * utkarsh | joined |
13:51:03
| * _Getty | joined |
13:54:16
| * cjihrig_ | joined |
13:54:23
| * cjihrig_ | part |
13:55:04
| * rosseaux_ | joined |
13:56:07
| * plutoniix | quit (*.net *.split) |
13:56:08
| * BobGneu | quit (*.net *.split) |
13:56:08
| * rosseaux | quit (*.net *.split) |
13:56:08
| * Getty | quit (*.net *.split) |
13:56:10
| * cjihrig | quit (*.net *.split) |
13:56:10
| * utkarsh_ | quit (*.net *.split) |
13:57:55
| * rosseaux_ | changed nick to rosseaux |
14:02:48
| * plutoniix | joined |
14:24:07
| <trungl-bot`> | Tree closed by [email protected]: Tree is closed (Automatic: "Test262 - no variants" on http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/7717 "V8 Win64" from 232e28d65e95ec928cdc339ab51bfb93654bc1e2: [email protected]) |
14:32:09
| <trungl-bot`> | Tree opened by [email protected]: open |
14:36:21
| * cjihrig | joined |
15:21:13
| * jugglinmike | joined |
15:25:39
| * bnoordhuis | joined |
15:42:53
| * mostynb | quit (Quit: Leaving) |
16:00:48
| * bnoordhuis | quit (Ping timeout: 264 seconds) |
16:09:22
| * RT|Chatzilla | quit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2009081014]) |
16:33:49
| * ofrobots | joined |
16:45:08
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
16:52:51
| * jgi | joined |
16:54:20
| * ofrobots | joined |
16:59:00
| * ofrobots | quit (Ping timeout: 250 seconds) |
17:01:24
| * jgi | quit (Quit: jgi) |
17:02:38
| * jgi | joined |
17:03:33
| * jgi | quit (Client Quit) |
17:05:31
| * bnoordhuis | joined |
17:10:17
| * watilde | joined |
17:11:04
| * C-Man | joined |
17:20:28
| * petka____ | quit (Quit: Connection closed for inactivity) |
17:40:01
| * ofrobots | joined |
17:48:14
| * jgi | joined |
18:12:22
| * watilde_ | joined |
18:17:16
| * Getty | joined |
18:19:00
| * watilde_ | quit (Remote host closed the connection) |
18:19:58
| * rosseaux_ | joined |
18:21:24
| * WakiMiko_ | joined |
18:22:05
| * watilde | quit (*.net *.split) |
18:22:05
| * plutoniix | quit (*.net *.split) |
18:22:05
| * rosseaux | quit (*.net *.split) |
18:22:05
| * _Getty | quit (*.net *.split) |
18:22:05
| * rendar | quit (*.net *.split) |
18:22:13
| * Clinteger | quit (*.net *.split) |
18:22:13
| * WakiMiko | quit (*.net *.split) |
18:22:13
| * trevnorris | quit (*.net *.split) |
18:22:48
| * rosseaux_ | quit (Excess Flood) |
18:22:48
| * Clinteger | joined |
18:22:48
| * rosseaux | joined |
18:23:09
| * trevnorris | joined |
18:23:15
| * rendar | joined |
18:28:44
| * plutoniix | joined |
18:48:55
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
18:57:52
| * jugglinmike | quit (Changing host) |
18:57:53
| * jugglinmike | joined |
19:56:07
| <caitp> | alright I haven't done anything in the past few days, and haven't seen any bugs indicating that I broke stuff, whats up |
19:56:43
| <aklein> | hehe |
19:57:02
| <aklein> | well there have only been a few canaries, maybe the breakage reports are just lagging :) |
20:05:18
| <caitp> | hey adam, do we have target toolchain versions anywhere? I was thinking about moving some of the template members in parser-base.h into a file that doesn't get included all over the place |
20:05:25
| <jugglinmike> | caitp: I've been trying to pick up the slack on "breaking things," but aklein won't let me |
20:06:04
| <caitp> | haha :) |
20:06:40
| * ofrobots | joined |
20:07:05
| <aklein> | hey now, I didn't design test-parsing.cc, I just work here |
20:14:22
| <caitp> | so, about the Expression vs AssignmentExpression thing |
20:14:39
| <caitp> | the only other issue I can think of is that it is incompatible with JSC's current behaviour |
20:14:44
| <caitp> | and possibly chakra, haven't checked |
20:15:28
| <caitp> | spidermonkey seems to be happy to throw the SyntaxError, so maybe it's fine in the gaia/b2g market |
20:16:09
| <aklein> | I'll check chakra |
20:16:18
| <jugglinmike> | aklein caitp: https://github.com/Microsoft/ChakraCore/issues/147 |
20:17:06
| <aklein> | aha |
20:17:36
| <caitp> | it's probably a young enough feature that it doesn't matter |
20:17:40
| <caitp> | but you never know |
20:17:57
| <jugglinmike> | I want to break the JavaScript that relies on it |
20:18:17
| <caitp> | yeah but vendors usually don't :( |
20:18:29
| <caitp> | could try it and see if anything breaks in canary |
20:19:50
| <bnoordhuis> | just thought i'd mention chakra has async/await. no pressure |
20:20:10
| <bnoordhuis> | (subtle, eh?) |
20:20:24
| <caitp> | i think that's on Dan's radar |
20:21:05
| <bnoordhuis> | i looked briefly into it this week; parsing it is actually harder than i expected |
20:21:10
| <caitp> | I could probably implement parsing for it today just out of boredom, but i'll leave the desugaring to him |
20:21:21
| <caitp> | oh? |
20:21:40
| <bnoordhuis> | there's a couple of places in the parser where it has heuristics for Token::FUNCTION |
20:22:00
| <bnoordhuis> | those would need to be updated to understand Token::ASYNC as well (including the no-newline thing) |
20:22:16
| <caitp> | you mean the IIFE heuristics? |
20:23:00
| <bnoordhuis> | uh, possibly. it was two days ago and my short-term memory's half-life is pretty bad |
20:23:28
| <caitp> | it's basically just stuff to try to eagerly compile IIFEs, I think |
20:56:41
| <trungl-bot`> | Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/1077 "V8 Linux - arm64 - sim - nosnap - debug" from 6fc3149939deb59d06f2d70e85306ece5272ff0c: [email protected]) |
21:01:52
| * rendar | quit (Ping timeout: 272 seconds) |
21:06:16
| <aklein> | jugglinmike: so only Spidermonkey gets this right? |
21:06:45
| <jugglinmike> | aklein: that and es6-draft, of course |
21:06:54
| <aklein> | heh, naturally |
21:07:46
| * rendar | joined |
21:15:15
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
21:17:57
| * ofrobots | joined |
21:20:56
| * davi | joined |
21:20:56
| * davi | quit (Changing host) |
21:20:56
| * davi | joined |
21:27:52
| <trungl-bot`> | Tree opened by [email protected]: Tree is open (Automatic: \(^o^)/) |
21:30:25
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
21:30:38
| * watilde | joined |
21:37:48
| <jugglinmike> | aklein: Is there ball in my court now? |
21:40:06
| <aklein> | jugglinmike: yup, once you've got an lgtm you're free to land. easiest way is to hit the "commit queue" button |
21:40:14
| <aklein> | (checkbox? depends on which UI you're using) |
21:40:59
| * ofrobots | joined |
21:41:13
| <jugglinmike> | checkbox clicked! |
21:42:22
| <aklein> | thanks! and sorry for the rather long roundabout. at least it'll be easier next time? |
21:42:43
| * watilde | quit (Remote host closed the connection) |
21:43:19
| <aklein> | I'm a little confused as to why the spec restricts for-of in this way |
21:43:35
| <aklein> | there are already plenty of nonsensical expressions you can put in that position |
21:44:05
| <caitp> | i'm sure they would restrict for-in the same way if it were web compatible |
21:44:06
| <aklein> | is there some ambiguity it helps with (if so, I would've thought it'd bite us in some way already) |
21:45:36
| <aklein> | sure, but they can't, so it seems weird to add this slight incompatibility. ah well, that's ES2015 for you |
21:47:53
| * watilde | joined |
21:49:24
| * davi | quit (Ping timeout: 250 seconds) |
21:53:03
| <jugglinmike> | aklein: but they've also refrained from some tempting cases to break parity |
21:53:30
| <jugglinmike> | the one I always think about is how generator functions and arrow functions are not forced into strict mode |
21:53:56
| <aklein> | "refactoring hazard" is the phrase I keep hearing |
21:54:17
| <jugglinmike> | yah |
21:55:49
| <caitp> | if rick gets to attend tc39, you could probably get a seat there too and cast another vote against that in the future |
21:56:30
| * watilde | quit (Remote host closed the connection) |
22:00:24
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
22:00:45
| <jugglinmike> | I think that ship has sailed, caitp |
22:01:05
| <jugglinmike> | or are you saying, against that practice in general? |
22:01:22
| * watilde | joined |
22:01:54
| <caitp> | against that practice in general |
22:02:50
| * watilde | quit (Ping timeout: 240 seconds) |
22:12:41
| <jugglinmike> | aklein: on to another bug. Is there anything I should know about triggering desugaring logic in parser.cc ? |
22:13:05
| <jugglinmike> | or should I expect to see those changes from `d8 -e` immediately after a build in all cases? |
22:13:51
| <jugglinmike> | "see those changes" -> "see new behavior due to changes to that logic" |
22:14:59
| <aklein> | jugglinmike: should be immediate |
22:15:12
| <jugglinmike> | ok, thanks! |
22:15:19
| <aklein> | as long as the code is executing, it had to run through parser.cc first |
22:22:30
| * ofrobots | joined |
22:22:58
| * ofrobots | quit (Client Quit) |
22:24:02
| * jgi | quit (Quit: jgi) |
22:32:22
| * RT|Chatzilla | joined |
22:33:15
| * bnoordhuis | quit (Ping timeout: 260 seconds) |
22:39:25
| * jgi | joined |
22:47:43
| * ofrobots | joined |
22:56:22
| * ofrobots | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
22:58:01
| * esas | joined |
23:01:15
| * ofrobots | joined |
23:03:35
| * jugglinmike | quit (Ping timeout: 260 seconds) |
23:04:35
| * jugglinmike | joined |
23:47:11
| * bobmcw | quit (Remote host closed the connection) |