00:03:45  * plutoniixjoined
00:05:42  * jonathan2quit (Ping timeout: 276 seconds)
00:26:40  * Cube8quit (Quit: Leaving)
00:28:57  * Venemoquit (Ping timeout: 260 seconds)
01:25:50  * rhalffquit (Remote host closed the connection)
02:00:09  * jonathan2joined
02:50:32  * thefourtheye___quit (Quit: Connection closed for inactivity)
02:52:15  * joransiupart ("Leaving")
02:52:16  * joransiu_quit (Quit: Leaving)
03:27:27  * jonathan2quit (Ping timeout: 260 seconds)
03:51:12  * plutoniixquit (Quit: จรลี จรลา)
03:59:46  * plutoniixjoined
04:01:07  * plutoniixchanged nick to xiinotulp
04:03:19  * ncthom91joined
04:11:04  * ncthom91quit (Quit: Textual IRC Client: www.textualapp.com)
05:17:48  * trevnorrisquit (Quit: quit all you want)
05:19:21  * trevnorrisjoined
06:30:10  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Presubmit" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/builds/8309 "V8 Linux - presubmit" from 7c3748a9c46843ac26bd72dfdd3298e6907d0f6d: [email protected])
06:35:13  <trungl-bot>Tree opened by [email protected]: Tree is open
06:51:52  * bobmcwquit (Remote host closed the connection)
06:52:08  * bobmcwjoined
07:56:56  * bobmcwquit (Remote host closed the connection)
07:57:42  * bobmcwjoined
09:15:15  * Venemojoined
09:46:43  * davijoined
10:28:05  * thefourtheye___joined
10:55:33  * Venemoquit (Ping timeout: 240 seconds)
11:11:50  * xiinotulpquit (Quit: จรลี จรลา)
11:17:34  * daviquit (Ping timeout: 240 seconds)
11:44:52  * davijoined
12:02:39  * daviquit (Ping timeout: 276 seconds)
12:15:00  * jonathan2joined
12:22:41  * jonathan2quit (Ping timeout: 240 seconds)
12:47:00  * jonathan2joined
13:04:59  * bradleymeckjoined
13:12:18  * bradleymeckquit (Read error: Connection reset by peer)
13:12:36  * bradleymeckjoined
13:28:12  * plutoniixjoined
13:40:13  * jugglinmikejoined
14:01:12  * ncthom91joined
14:19:19  * bradleymeckquit (Read error: Connection reset by peer)
14:20:23  * bradleymeckjoined
14:45:06  * bradleymeck_joined
14:45:37  * bradleymeckquit (Read error: Connection reset by peer)
14:45:37  * bradleymeck_changed nick to bradleymeck
14:50:43  * bradleymeck_joined
14:51:00  * bradleymeckquit (Ping timeout: 276 seconds)
14:51:00  * bradleymeck_changed nick to bradleymeck
14:51:01  * hferreirojoined
14:59:28  * bradleymeckquit (Quit: bradleymeck)
15:09:16  * davijoined
15:34:35  <caitp>jonathan2: file a bug :)
15:34:59  <caitp>although it's probably already been filed in some form or other, rings a bell somehow
15:43:58  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
15:52:12  <jonathan2>Yeah, I might. I'm trying to come up with a minimal test case.
15:58:37  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "isolate tests" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20builder/builds/13219 "V8 Linux - nosnap builder" from 1f2eaa1c14dc70284109a0b1aafaf2328248eb14: [email protected])
16:16:33  * hferreiroquit (Remote host closed the connection)
16:53:29  * plutoniixquit (Quit: จรลี จรลา)
17:00:48  * Garbeejoined
17:27:33  <trungl-bot>Tree opened by [email protected]: Tree is open (infra issue?)
17:34:08  * plutoniixjoined
17:46:38  <jwolfe>i would like advice on how much comments is too much comments. I've got a draft of a patch for a very spec-picky issue, and i've thoroughly researched every change I made to to v8 with spec references and test cases. (I still feel like I'm mostly just experimenting rather than truly understanding what's going on, but that probably can't be helped.) After writing a bunch of review comments justifying my changes in the CL, it occurred to me that
17:46:38  <jwolfe>this information should really be comments in the code, and possibly new test cases for the test suite. Here's the question: is the information too much information to put into comments in the code? I'm not sure the relevance of the comments will survive as long as the comments will, resulting in the comments being clutter. Please advise.
17:46:38  <jwolfe>https://codereview.chromium.org/2048703002/diff/1/src/runtime/runtime-scopes.cc
18:02:41  * caitpdefers to adam or dan on that one
18:04:45  <caitp>there are a lot of spec references in V8 code, so I don't know if it's a real problem, but people are picky about comments, so reviewers will probably tell you to add more comments, or not to
18:20:40  <jwolfe>aklein, littledan__: ping
19:21:24  * daviquit (Ping timeout: 276 seconds)
19:22:55  <aklein>jwolfe: hullo
19:26:19  <jwolfe>aklein, can you give your opinion on the issue above?
19:27:34  <aklein>jwolfe: I'm personally fine with comments pointing at the spec, though the section numbers can get out of date pretty fast
19:28:21  <jwolfe>aklein, is there any stable way to refer to the spec? i suppose there can't be, right?
19:28:58  <aklein>what we have been doing is "ES#some-anchor", but that only gets you to the right section and still lets the steps get out of order
19:29:24  <aklein>I would still say the spec text itself is useful, since the internal naming often doesn't match the spec naming
19:30:17  <aklein>a side note, regarding some of these "is_const" bits: perhaps those are left over from our legacy const support?
19:30:24  <aklein>(lunchtime, bbiab)
19:47:26  <caitp>jwolfe: I believe https://tc39.github.io/ecma262/2016/ is supposed to stay put and be stable, and it's more recent than http://www.ecma-international.org/ecma-262/6.0/
19:48:01  <caitp>some people would prefer that you just link to the living standard, and urls can be updated as needed, though
19:50:32  * thefourtheye___quit (Quit: Connection closed for inactivity)
20:18:48  * hferreirojoined
20:19:20  * hferreiroquit (Client Quit)
20:41:31  * ncthom91quit (Quit: Textual IRC Client: www.textualapp.com)
21:06:44  * davijoined
21:08:41  * xiinotulpjoined
21:11:37  * plutoniixquit (Ping timeout: 252 seconds)
21:33:47  <jwolfe>caitp, would it be silly to just give a fragment link and not specify which version of the document i'm talking about? like "// see #sec-evaldeclarationinstantiation". those anchor ids are supposed to remain stable across multiple versions of the document.
21:35:32  <caitp>I would just add the extra 31 characters, but I don't really care all that much
21:35:42  * daviquit (Remote host closed the connection)
21:35:50  <caitp>go with preferences of your reviewers
21:39:55  * davijoined
21:39:55  * daviquit (Changing host)
21:39:55  * davijoined
21:52:34  * daviquit (Ping timeout: 240 seconds)
21:54:02  <jwolfe>i guess the question is: would linking against a specific "old" version of the document be better or worse than linking against no version or the unqualified version? i'm not really concerned with the number of characters; i just want to communicate the right idea, and that depends on how it would be interpreted.
21:56:23  <caitp>a lot of people would say "no, link to the living standard, that's the thing that matters"
21:56:36  <caitp>"a lot of people" including a lot of people on the chromium projects
21:57:00  <caitp>a lot of people would also say "stop adding comments all over the place, just put it in commit messages and stuff"
21:57:34  <caitp>different people would say "stop adding broken links to the codebase it makes it harder to maintain and stuff"
21:58:02  <caitp>there are different perspectives on it, and no real single "correct" answer, I guess
22:29:11  * RT|Chatzillajoined
22:32:00  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Check" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/8040 "V8 Linux - noi18n - debug" from 65dac7f8ead2eb09d417ecaaae0164699edfd510: [email protected])
23:00:26  <jwolfe>aklein, this is what i'm thinking about putting in comments. is the d8 command too much? https://codereview.chromium.org/2048703002/diff2/20001:40001/src/runtime/runtime-scopes.cc
23:02:55  <caitp>I hate when I accidentally `cmd + s` with objects.h or other big header files open :(
23:03:13  <caitp>big header files included by everything ever*
23:06:08  * jonathan2quit (Ping timeout: 272 seconds)
23:21:03  <jwolfe>caitp, it's a 12 minute mistake for me. i know how you feel.
23:45:56  * jonathan2joined