| 00:50:36
| * thefourtheye | quit (Quit: Connection closed for inactivity) |
| 00:56:30
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 01:24:21
| * Garbee | quit (Quit: Connection closed for inactivity) |
| 01:48:44
| * plutoniix | quit (Quit: จรลี จรลา) |
| 02:58:06
| * thefourtheye | joined |
| 03:51:42
| * unixpickle | joined |
| 04:02:20
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 05:21:17
| * plutoniix | joined |
| 06:01:01
| * BobGneu | quit (Remote host closed the connection) |
| 06:01:20
| * BobGneu | joined |
| 06:33:16
| <trungl-bot> | Tree closed by [email protected]: closed (maintenance) |
| 07:01:35
| <trungl-bot> | Tree opened by [email protected]: open |
| 10:46:23
| * Garbee | joined |
| 11:12:36
| * plutoniix | quit (Quit: จรลี จรลา) |
| 12:41:37
| * bradleymeck | joined |
| 12:43:52
| * rmcilroy | quit (Remote host closed the connection) |
| 13:38:40
| * ncthom91 | joined |
| 13:46:54
| * Venemo | joined |
| 13:49:46
| * rmichnik | joined |
| 13:52:39
| * bobmcw | joined |
| 14:05:53
| * bobmcw_ | joined |
| 14:06:01
| * bobmcw | quit (Read error: Connection reset by peer) |
| 14:10:56
| * bobmcw_ | changed nick to bobmcw |
| 14:10:57
| * bobmcw | quit (Changing host) |
| 14:10:57
| * bobmcw | joined |
| 14:29:55
| * unixpickle | joined |
| 14:44:16
| * bobmcw | quit (Ping timeout: 252 seconds) |
| 14:46:16
| * plutoniix | joined |
| 14:47:25
| * bobmcw | joined |
| 15:10:36
| * thefourtheye | quit (Quit: Connection closed for inactivity) |
| 15:20:15
| * ncthom91 | quit (Quit: Textual IRC Client: www.textualapp.com) |
| 15:24:06
| * bobmcw | quit (Read error: Connection reset by peer) |
| 15:28:52
| * bobmcw | joined |
| 15:35:18
| * RT|Chatzilla | quit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309]) |
| 15:54:36
| * rmichnik | quit (Quit: Connection closed for inactivity) |
| 16:08:17
| * bobmcw | quit (Read error: Connection reset by peer) |
| 16:09:14
| * bobmcw | joined |
| 16:12:10
| * bobmcw | quit (Read error: Connection reset by peer) |
| 16:13:31
| * bobmcw | joined |
| 16:13:31
| * bobmcw | quit (Changing host) |
| 16:13:31
| * bobmcw | joined |
| 16:39:56
| * bobmcw | quit (Ping timeout: 250 seconds) |
| 16:42:33
| * bobmcw | joined |
| 17:02:41
| * bradleymeck | quit (Quit: bradleymeck) |
| 17:16:35
| * jonaslund | joined |
| 17:25:52
| * bradleymeck | joined |
| 17:42:26
| * lerela | joined |
| 17:47:23
| * bradleymeck | quit (Quit: bradleymeck) |
| 17:54:31
| * bradleymeck | joined |
| 18:25:57
| * rhalff | joined |
| 18:46:55
| <jwolfe> | i got a notice my v8 CL breaks a webkit layout test and that i should do something about it. it looks like an automated message: https://codereview.chromium.org/2048703002/#msg25 |
| 18:47:11
| <jwolfe> | should i try to follow the linked instructions and resolve this issue, or is there a smarter way to approach this? |
| 19:01:40
| * Guest18887 | quit (Changing host) |
| 19:01:40
| * Guest18887 | joined |
| 19:01:44
| * Guest18887 | changed nick to kenansulayman |
| 19:02:07
| * bobmcw | quit (Read error: Connection reset by peer) |
| 19:02:11
| * bobmcw_ | joined |
| 19:10:22
| * bobmcw_ | quit (Read error: Connection reset by peer) |
| 19:16:05
| * bobmcw | joined |
| 19:18:02
| * ncthom91 | joined |
| 19:58:49
| * ncthom91 | quit (Quit: My MacBook has gone to sleep. ZZZzzz…) |
| 20:29:28
| * bobmcw | quit (Read error: Connection reset by peer) |
| 20:29:40
| * bobmcw | joined |
| 20:40:13
| * bobmcw | quit (Remote host closed the connection) |
| 20:40:47
| * bobmcw | joined |
| 21:01:25
| * bobmcw | quit (Ping timeout: 260 seconds) |
| 21:08:22
| * bradleymeck | quit (Quit: bradleymeck) |
| 21:38:44
| * Venemo | quit (Quit: Communi 3.5.0 - http://communi.github.com) |
| 21:46:54
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 22:02:38
| * bradleymeck | joined |
| 22:08:26
| <caitp> | jwolfe: I gave you instructions on jabber about that |
| 22:08:54
| <caitp> | do you have a Chromium checkout on your machine? |
| 22:19:26
| * rhalff | quit (Quit: Leaving) |
| 22:32:44
| * RT|Chatzilla | joined |
| 22:46:30
| <jwolfe> | caitp, i have a chromium checkout. i built it in release mode, and ran the test suite, but it failed right away with this error: http://pastebin.com/nSTKdXCu |
| 22:47:03
| <jwolfe> | i have done `gclient sync` and `./build/install-build-deps.sh` |
| 22:48:26
| <caitp> | huh, I haven't built chromium on linux personallyl |
| 22:48:36
| <caitp> | so, you should probably ask about that in #chromium |
| 22:48:48
| <caitp> | or bug dan or adam about it I guess |
| 22:49:14
| <caitp> | you don't really need to run the full test suite though, the trybots will do it faster |
| 22:50:22
| <caitp> | just add the LayoutTests/TestExpectations entry for now (bug # + file + expected status) and then after a v8 roll including your change, remove the test expectation line and fix the test |
| 22:50:43
| <caitp> | you can prepare the CL for the second part of that in advance by applying your patch ontop of src/v8 |
| 22:52:37
| * unixpickle | joined |
| 22:57:03
| <jwolfe> | caitp, do you mean chrome/test/data/printing/layout_tests/TestExpectations ? |
| 22:57:19
| <jwolfe> | does that mean i have to create a chromium bug for this issue? |
| 22:57:24
| <caitp> | eh, I thought it was a blink layout test |
| 22:58:20
| <caitp> | yeah, so that's under third_party/WebKit/LayoutTests/TestExpectations |
| 22:58:44
| <caitp> | or is it... |
| 22:58:56
| <caitp> | it is |
| 22:59:00
| <caitp> | yeah, that was the right file |
| 23:01:35
| <jwolfe> | ok, so i edit third_party/WebKit/LayoutTests/TestExpectations . does that mean i need to open a chromium bug to track this change? |
| 23:01:59
| <caitp> | yes |
| 23:06:05
| <gsathya> | jwolfe: i assume you ran https://chromium.googlesource.com/chromium/src/+/master/build/install-build-deps.sh ? |
| 23:06:45
| <jwolfe> | i'm looking at crbug.com/593514 for inspiration. but i'm stuck on the New Issue wizard where it wants me to break up the first comment into "Steps to reproduce", "Expected behavior", and "What went wrong?" sections. Is there a form that bypasses that and just lets me make a bug the way I want? |
| 23:07:01
| <caitp> | don't worry about following the wizard, it doesn't really matter |
| 23:07:06
| <caitp> | just makes it easier for triagers |
| 23:08:49
| <jwolfe> | how do i avoid the wizard? |
| 23:08:58
| <caitp> | I don't think you can without editbugs permissions |
| 23:09:08
| <caitp> | but the field values don't really matter that much |
| 23:09:17
| <caitp> | since it's not a real "bug" |
| 23:09:34
| <jwolfe> | so i've only got editbugs permissions for v8? |
| 23:09:39
| <caitp> | yeah |
| 23:10:30
| <jwolfe> | gsathya, yes. |
| 23:12:28
| * aperezdc | quit (Ping timeout: 264 seconds) |
| 23:15:12
| * aperezdc | joined |
| 23:40:18
| * Net147 | quit (Ping timeout: 276 seconds) |
| 23:42:23
| * Net147 | joined |