| 00:11:31
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 00:14:58
| * jugglinmike | quit (Ping timeout: 252 seconds) |
| 00:22:35
| * plutoniix | joined |
| 00:24:07
| * plutoniix | quit (Client Quit) |
| 00:30:29
| * plutoniix | joined |
| 02:02:45
| * plutoniix | quit (Quit: จรลี จรลา) |
| 02:26:11
| * unixpickle | joined |
| 02:26:33
| * unixpickle | quit (Client Quit) |
| 02:59:19
| * unixpickle | joined |
| 03:06:11
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 04:46:51
| * plutoniix | joined |
| 04:50:06
| * plutoniix | quit (Client Quit) |
| 05:07:59
| * plutoniix | joined |
| 05:26:23
| <trungl-bot> | Tree closed by [email protected]: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20-%20ignition/builds/777 "V8-Blink Linux 64 - ignition" from d5f2ac5e3326f281cbe7ba57464a4b17a9938e37: [email protected]) |
| 06:28:07
| <trungl-bot> | Tree opened by [email protected]: open |
| 07:45:58
| <trungl-bot> | Tree closed by [email protected]: closed - maintenance |
| 07:46:58
| <trungl-bot> | Tree closed by [email protected]: closed - fixing |
| 07:56:06
| * BobGneu | joined |
| 08:00:08
| * bradleymeck | joined |
| 08:29:19
| * kenansulayman | quit (Read error: Connection reset by peer) |
| 08:36:34
| * saper | quit (Ping timeout: 252 seconds) |
| 08:37:07
| * luite_ | quit (Ping timeout: 252 seconds) |
| 08:37:07
| * aperezdc | quit (Ping timeout: 252 seconds) |
| 08:44:16
| <trungl-bot> | Tree opened by [email protected]: open |
| 08:44:17
| * saper_ | joined |
| 08:44:17
| * clinth | quit (Ping timeout: 244 seconds) |
| 08:44:20
| * aperezdc_ | joined |
| 08:44:21
| * AKPWD | quit (Ping timeout: 244 seconds) |
| 08:44:22
| * luite | joined |
| 08:44:22
| * clinth | joined |
| 08:44:27
| * aperezdc_ | changed nick to aperezdc__ |
| 08:44:27
| * gsathya | quit (Ping timeout: 272 seconds) |
| 08:44:28
| * BobGneu | quit (Ping timeout: 276 seconds) |
| 08:44:30
| * Bob_Gneu | joined |
| 08:44:31
| * Net147 | quit (Ping timeout: 244 seconds) |
| 08:44:31
| * AKPWD | joined |
| 08:44:33
| * aperezdc__ | changed nick to aperez |
| 08:45:52
| * aperez | changed nick to aperezdc |
| 08:46:03
| * Net147 | joined |
| 08:46:47
| * jochen__ | quit (Ping timeout: 258 seconds) |
| 08:49:34
| * jochen__ | joined |
| 09:08:44
| * gsathya | joined |
| 09:30:05
| <trungl-bot> | Tree closed by [email protected]: Tree is closed (Automatic: "gclient runhooks" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/5298 "V8 Linux64 - internal snapshot" from c534bd41a028d7dd8d79e932b619433ce9e82d10: [email protected]) |
| 09:51:21
| * davi | joined |
| 10:16:38
| <trungl-bot> | Tree opened by [email protected]: open |
| 10:27:31
| * davi | quit (Ping timeout: 250 seconds) |
| 11:32:38
| * kenansulayman | joined |
| 11:33:01
| * kenansulayman | changed nick to Guest34545 |
| 11:40:00
| * Guest34545 | quit (Quit: ZNC - http://znc.in) |
| 11:42:26
| * bradleymeck | quit (Quit: bradleymeck) |
| 11:52:18
| * plutoniix | quit (Quit: จรลี จรลา) |
| 12:17:07
| * kenansulayman | joined |
| 12:17:30
| * kenansulayman | changed nick to Guest14030 |
| 12:19:06
| * Guest14030 | quit (Changing host) |
| 12:19:06
| * Guest14030 | joined |
| 13:00:11
| * bobmcw | joined |
| 13:22:01
| * bradleymeck | joined |
| 13:33:19
| * bradleymeck | quit (Quit: bradleymeck) |
| 13:37:58
| * bradleymeck | joined |
| 13:44:12
| * jugglinmike | joined |
| 13:54:15
| * seventh | joined |
| 13:55:42
| * ncthom91 | joined |
| 14:04:23
| * unixpickle | joined |
| 14:06:03
| * seventh | quit (Ping timeout: 240 seconds) |
| 14:12:43
| * bradleymeck | quit (Quit: bradleymeck) |
| 14:16:30
| * seventh | joined |
| 14:44:30
| * davi | joined |
| 15:56:39
| * seventh | quit (Ping timeout: 250 seconds) |
| 15:59:46
| * bradleymeck | joined |
| 16:02:52
| * ncthom91 | quit (Quit: Textual IRC Client: www.textualapp.com) |
| 16:16:37
| * bradleymeck | quit (Quit: bradleymeck) |
| 16:19:41
| * RT|Chatzilla | quit (Read error: Connection reset by peer) |
| 16:25:37
| <jwolfe> | is anyone else frustrated by how bots can revert your CL after it gets landed and closed? i mean i get that we need more bots than just the pre-land checks, but can't we at least leave the CL open until all the bots with the power to revert the CL have given it their stamp of approval? that would save the pain of making re-land CL's. |
| 16:26:51
| <jwolfe> | the background is that 2/2 of my CL's have been reverted by post-land bots, and neither issue was my fault, and both times, the CL was approved by a reviewer. |
| 16:27:40
| <jwolfe> | it just seems that re-land CL's are a worse idea than leaving the original CL open or even re-opening the original CL and appending a new patches or whatever. |
| 16:39:54
| * davi | quit (Ping timeout: 246 seconds) |
| 17:25:18
| <caitp> | jwolfe: you've probably seen in bugmail that the land <revert> reland <revert> re-reland pattern is fairly common in the chromium projects |
| 17:26:00
| <caitp> | really it's just stress testing for the bignum library used to parse CL ids |
| 17:52:51
| <jwolfe> | caitp, lol. but is that a "no" then? is there some reason why CL's can't be reopened? or is there some reason a CL doesn't wait 24h after being landed to close? has this idea even been considered before? |
| 17:53:56
| <caitp> | they can be reopneed |
| 17:54:37
| <caitp> | you can just uncheck "closed" in the "edit issue" dialogue, and it will be opened again |
| 17:55:12
| <jwolfe> | then why does anyone make re-land CLs? |
| 17:56:29
| <caitp> | well for one thing, it makes the intent clear |
| 17:56:48
| <caitp> | if they didn't, they might end up with 40 patchsets in the CL which gets hard to deal with |
| 17:57:11
| <caitp> | so a reland CL might have the original landed CL, and then a second patchset with changes that were needed (if any) |
| 17:57:33
| <caitp> | but just having "re-land" in the changeset is nice because it communicates what really happened |
| 17:58:55
| <jwolfe> | so people use re-land CL's because they prefer to? not because there's a technical reason, like it makes reports and graphs nicer or something? |
| 17:59:56
| <caitp> | I don't think there is a technical reason, just an aesthetic / functional reason |
| 18:00:03
| <caitp> | easier on the eyes and brain |
| 18:02:05
| <jwolfe> | well that sounds subjective :) . so does that mean i can reopen this CL? https://codereview.chromium.org/2048703002 i'm literally not going to change anything about the code before trying to re-land it. |
| 18:03:16
| <caitp> | in a case like that, I'd personally be fine with not opening a new CL |
| 18:03:56
| <caitp> | you could re-open it and ping people about relanding it, edit the description to reflect relanding if you want to |
| 18:04:01
| <caitp> | if they suggest opening a new CL for it, then you should though |
| 18:05:45
| <jwolfe> | it sounds like i should re-open it even if just to fish for people with an objective reason for creating re-land CL's. :) |
| 18:19:25
| * seventh | joined |
| 19:25:59
| * rhalff | joined |
| 19:29:08
| * seventh | quit (Quit: ...) |
| 19:44:49
| * saper_ | changed nick to saper |
| 20:02:28
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 20:04:34
| * unixpickle | joined |
| 20:17:07
| * jwolfe | quit (Quit: Leaving) |
| 20:18:03
| * jwolfe | joined |
| 20:19:53
| * jwolfe | quit (Client Quit) |
| 20:20:13
| * jwolfe | joined |
| 20:29:55
| * bradleymeck | joined |
| 20:54:39
| * Bob_Gneu | quit (Remote host closed the connection) |
| 20:55:25
| * BobGneu | joined |
| 20:59:53
| * bobmcw | quit (Remote host closed the connection) |
| 21:33:22
| <trungl-bot> | Tree closed by [email protected]: Tree is closed (Automatic: "compile" on http://build.chromium.org/p/client.v8.fyi/builders/Chromium%20ASAN%20%28symbolized%29/builds/863 "Chromium ASAN (symbolized)" from c781e83194031b337f8eafb42588a2e3d7440782: [email protected] (:aklein),[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],machenb |
| 22:34:07
| * bradleymeck | quit (Quit: bradleymeck) |
| 22:44:15
| * RT|Chatzilla | joined |
| 23:03:16
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 23:16:46
| * unixpickle | joined |