00:01:29  <jwolfe>specifically, ParseFormalParameter() has a comment mentioning GeneratorParameter. i think it makes sense for me to delete that reference in this patch that i'm doing right now. i think that would beat the alternative, which i think is to make an issue and a CL for updating comments, and then get a reviewer and land that patch and everything on its own; at that point, i think i would argue that it's not worth it anymore.
00:01:49  <jwolfe>of course, this isn't my codebase, and i'm willing to follow someone else's lead on this, but i like sharing my opinion too :)
00:04:42  <jwolfe>issues like these are the kind of thing i want to hear people's opinions on. i'm new to this team, and i'm interested in learning how people feel about this kind of thing so i can keep it in mind when this sort of thing comes up again.
00:14:27  * Garbeequit (Quit: Connection closed for inactivity)
00:26:27  <caitp>there are pros and cons to both approaches
00:26:49  <caitp>in this case, since it's a comment, it just doesn't really matter much --- but, it's your call I guess, unless a reviewer says otherwise
00:30:57  <aklein>it's hard to get any kind of consensus about stuff like this, but my general feeling is always to scope changes as tightly as possible. so if you're not actually touching some function, changing a comment in there would be weird.
00:31:22  <aklein>unless you're otherwise changing something about what that comment refers to, of course
00:51:40  * plutoniixjoined
00:57:14  * ewanasquit (Ping timeout: 244 seconds)
01:01:07  * bradleymeckquit (Quit: bradleymeck)
01:30:57  * kikerojoined
01:35:44  * kikeroquit (Quit: Page closed)
01:41:55  * plutoniixquit (Read error: Connection reset by peer)
01:49:55  * unixpicklequit (Quit: My Mac has gone to sleep. ZZZzzz…)
02:17:55  * xaxxonjoined
02:18:57  <xaxxon>is there somewhere I can learn about v8::context? I understand isolates, and I understand the concept of *A* context in an isolate, but I don't understand what is shared across contexts in an isolate and what isn't. What if I "create an object in one context and then 'try to use it' (whatever that means) in another context in the same isolate?
02:28:55  * plutoniixjoined
02:37:43  * xiinotulpjoined
03:15:25  * ofrobots_awaychanged nick to ofrobots
03:29:26  * xiinotulpquit (Ping timeout: 272 seconds)
03:29:42  * plutoniixquit (Ping timeout: 276 seconds)
03:44:39  * plutoniixjoined
04:30:32  <xaxxon>if anyone has a few minutes, I posted my question to stack overflow: http://stackoverflow.com/questions/37981291/what-is-shared-discrete-across-multiple-v8-context-objects-belonging-to-a-single
04:54:06  * thefourtheyejoined
06:32:06  * davijoined
06:51:54  * daviquit (Ping timeout: 260 seconds)
06:56:50  * davijoined
07:23:04  * xaxxonquit (Quit: Leaving)
07:23:10  * Venemojoined
07:35:04  * daviquit (Ping timeout: 260 seconds)
07:56:10  * ewanasjoined
07:58:58  * ewanasquit (Changing host)
07:58:58  * ewanasjoined
08:15:30  * plutoniixquit (Read error: Connection reset by peer)
08:24:47  * plutoniixjoined
10:21:47  * davijoined
10:53:14  * ewanas_joined
10:56:54  * ewanasquit (Ping timeout: 276 seconds)
11:23:33  * daviquit (Ping timeout: 276 seconds)
12:39:24  * bradleymeckjoined
12:47:00  * bradleymeckquit (Quit: bradleymeck)
12:55:59  * bradleymeckjoined
13:03:43  * unixpicklejoined
13:09:10  * bobmcwjoined
13:09:10  * bobmcwquit (Changing host)
13:09:10  * bobmcwjoined
13:10:54  * plutoniixquit (Quit: Leaving)
13:31:35  * jugglinmikejoined
13:46:33  * jugglinmikequit (Ping timeout: 276 seconds)
13:59:57  * davijoined
14:04:51  * Venemoquit (Quit: Communi 3.5.0 - http://communi.github.com)
14:12:02  * daviquit (Ping timeout: 244 seconds)
14:12:12  <caitp>aklein: can TestExpectations lines apply to a single arch?
14:15:55  * davijoined
14:18:24  * jugglinmikejoined
14:35:00  * hferreirojoined
14:52:04  * daviquit (Ping timeout: 264 seconds)
14:59:26  * davijoined
15:10:31  * daviquit (Ping timeout: 240 seconds)
15:14:14  * davijoined
15:17:00  * plutoniixjoined
15:29:09  * daviquit (Ping timeout: 250 seconds)
15:46:41  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
16:20:03  * ewanas_quit (Ping timeout: 246 seconds)
16:28:08  * seventhjoined
16:57:07  * davijoined
16:57:07  * daviquit (Changing host)
16:57:07  * davijoined
17:37:16  * seventhquit (Ping timeout: 258 seconds)
17:43:46  * ewanasjoined
17:52:55  * ewanas_joined
17:54:02  * daviquit (Ping timeout: 244 seconds)
17:54:19  * ewanasquit (Ping timeout: 250 seconds)
18:01:46  <aklein>caitp: yup
18:02:08  <aklein>er
18:02:10  <aklein>at least they used to
18:02:15  <aklein>but I don't see any now
18:02:22  <caitp>hm
18:02:50  <aklein>oh wait
18:02:53  <aklein>I was looking in WebKit :)
18:03:03  <aklein>there are lots still in Blink
18:03:13  <aklein>architectures go between the bug and the test
18:03:19  <aklein>e.g., " [ Win ]"
18:03:43  <caitp>cool
18:05:33  * hferreiroquit (Quit: hferreiro)
18:05:48  <aklein>apparently WebKit has a TestExpectations file per arch, in platform/whatever/ these days
18:22:00  <jwolfe>wait, what's the different between WebKit and Blink? I thought those were synonyms in the chromium world. I thought they both referred to chromium/src/third_party/WebKit.
18:23:02  <aklein>jwolfe: I mean the "real" WebKit :)
18:23:29  <jwolfe>aklein, the one outside chromium?
18:23:33  <aklein>yup
18:23:48  <aklein>"WebKit" isn't a synonym for "Blink", it's just the directory under third_party where Blink is located
18:24:58  <caitp>should get acquainted with webkit, igalia has some high profile webkit people
18:27:21  <aklein>I keep a checkout to build jsc
18:27:33  <aklein>sadly it seems like it really doesn't build anymore on my ancient version of Ubuntu
18:27:41  <aklein>need to set up a chroot, but...ugh
18:37:40  * jwolfequit (Ping timeout: 252 seconds)
18:38:05  * jwolfejoined
18:40:42  * thefourtheyequit (Quit: Connection closed for inactivity)
18:41:54  <aklein>yay test262 roll (need to follow up with someone about getting a commit bot in here...)
18:48:40  * ewanas_quit (Ping timeout: 252 seconds)
18:55:17  * ewanasjoined
18:58:03  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Test262 - no variants" on http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/9214 "V8 Linux - arm64 - sim - MSAN" from d3a95b8a78eefabf884a60bc3d6aac5830b44eb3: [email protected])
19:32:19  <trungl-bot>Tree opened by [email protected]: Tree is open (reverted)
20:06:38  * ewanas_joined
20:07:52  * ewanasquit (Ping timeout: 252 seconds)
20:27:32  * jwolfequit (*.net *.split)
20:27:33  * _Gettyquit (*.net *.split)
20:27:34  * JoWiequit (*.net *.split)
20:27:34  * Guest14030quit (*.net *.split)
20:27:35  * sofquit (*.net *.split)
20:27:35  * dobsonquit (*.net *.split)
20:27:35  * oleavrquit (*.net *.split)
20:27:35  * s1wquit (*.net *.split)
20:27:36  * Vbitz_quit (*.net *.split)
20:27:44  * Gettyjoined
20:27:53  * Vbitzjoined
20:27:56  * jwolfejoined
20:28:16  * s1wjoined
20:28:39  * s1wchanged nick to Guest44841
20:28:52  * dobsonjoined
20:30:21  * sofjoined
20:31:01  * kenansulaymanjoined
20:31:25  * kenansulaymanchanged nick to Guest87932
20:32:04  * iamstef_quit (Ping timeout: 258 seconds)
20:32:53  * JoWiejoined
20:40:29  * iamstef_joined
20:48:37  * bobmcwquit (Remote host closed the connection)
20:52:53  * ewanas_quit (Read error: Connection reset by peer)
21:01:38  * ewanasjoined
21:17:52  * ewanas_joined
21:20:29  * ewanasquit (Ping timeout: 260 seconds)
21:35:03  * bradleymeckquit (Quit: bradleymeck)
22:21:08  * RT|Chatzillajoined
22:22:54  * ewanas_quit (Ping timeout: 260 seconds)
22:38:12  * ewanasjoined
23:37:24  * bradleymeckjoined
23:40:31  * jugglinmikequit (Ping timeout: 240 seconds)