00:18:25  * plutoniixquit (Quit: Leaving)
00:31:19  * zvjoined
03:48:12  * Net147quit (Ping timeout: 260 seconds)
03:51:32  * Net147joined
05:51:37  * plutoniixjoined
05:51:41  * plutoniixquit (Max SendQ exceeded)
06:59:46  * plutoniixjoined
06:59:49  * plutoniixquit (Max SendQ exceeded)
11:23:16  * rmcilroyquit (Ping timeout: 264 seconds)
11:34:57  * rmcilroyjoined
11:44:51  * Garbeejoined
13:11:33  * bobmcwjoined
13:48:27  * bobmcwquit (Read error: Connection reset by peer)
13:50:31  * bobmcwjoined
13:50:31  * bobmcwquit (Changing host)
13:50:31  * bobmcwjoined
14:03:47  * Garbeequit (Ping timeout: 250 seconds)
14:03:53  * ofrobotsquit (Read error: Connection reset by peer)
14:03:54  * arvquit (Read error: Connection reset by peer)
14:04:00  * dagobert________quit (Ping timeout: 258 seconds)
14:04:01  * scottmgquit (Ping timeout: 258 seconds)
14:04:04  * sewiltonquit (Ping timeout: 264 seconds)
14:04:04  * littledan__quit (Ping timeout: 264 seconds)
14:04:19  * akleinquit (Read error: Connection reset by peer)
14:04:19  * mathiasbynensquit (Write error: Connection reset by peer)
14:04:19  * ErikCorry_quit (Write error: Connection reset by peer)
14:04:19  * thefourtheyequit (Read error: Connection reset by peer)
14:04:20  * NewNewbiequit (Write error: Connection reset by peer)
14:04:20  * seththompsonquit (Write error: Connection reset by peer)
14:04:31  * iamstefquit (Read error: Connection reset by peer)
14:04:32  * JoWiequit (Read error: Connection reset by peer)
14:09:42  * Garbeejoined
14:12:35  * mathiasbynensjoined
14:14:40  * arvjoined
14:15:15  * ofrobotsjoined
14:15:41  * littledan__joined
14:16:02  * ErikCorry_joined
14:16:17  * bradleymeckjoined
14:16:41  * thefourtheyejoined
14:16:41  * NewNewbiejoined
14:16:45  * akleinjoined
14:17:03  * scottmgjoined
14:17:06  * seththompsonjoined
14:17:55  * dagobert________joined
14:18:17  * iamstefjoined
14:18:27  * JoWiejoined
14:18:57  * sewiltonjoined
14:37:24  * bobmcwquit (Read error: Connection reset by peer)
14:37:45  * bradleymeckquit (Quit: bradleymeck)
14:48:08  * bobmcwjoined
14:53:14  * bradleymeckjoined
15:29:24  * plutoniixjoined
15:35:21  * seventhjoined
15:39:11  * bobmcwquit (Read error: Connection reset by peer)
15:47:46  * bobmcwjoined
16:21:13  * bobmcwquit (Read error: Connection reset by peer)
16:23:58  * Tweth-U-PDSjoined
16:25:07  * bobmcwjoined
16:28:09  <Tweth-U-PDS>Hello! How do you build v8 on Windows-MSVC? The instructions at https://github.com/v8/v8/wiki/Building%20with%20Gyp do not work - there's no such file build/gyp_v8 =(
16:33:37  <caitp>Tweth-U-PDS: it's moved to gypfiles/gyp_v8
16:34:14  <Tweth-U-PDS>I tried executing gypfiles/gyp_v8 but it also errored out... (Although the web page says that's for cygwin... it probably needs to be updated if it's for both)
16:36:22  <caitp>how did you run it?
16:37:34  <Tweth-U-PDS>python gypfiles\gyp_v8
16:39:04  <caitp>do you have a log of the failure? also, I suggest you set GYP_GENERATORS=msvs in the environment when you run it
16:41:05  <Tweth-U-PDS>The log says - subprocess.CalledProcessError: Command '['C:\\Code\\ThirdPartyLibs\\depot_tools\\python276_bin\\python.exe', 'C:\\Code\\ThirdPartyLibs\\depot_tools\\win_toolchain\\get_toolchain_if_necessary.py', '--output-json', 'E:\\Code\\v8\\gypfiles\\win_toolchain.json', '03a4e939cd325d6bc5216af41b92d02dda1366a6']' returned non-zero exit status 1
16:42:11  <Tweth-U-PDS>I've tried setting the generators to just ninja, msvc, or both.. (In the hopes the error message might change, it didn't.)
16:46:34  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
16:47:43  * bobmcwquit (Read error: Connection reset by peer)
16:48:02  * bobmcwjoined
16:54:20  <caitp>try running get_toolchain_if_necessary.py manually, I guess
16:54:43  * bobmcwquit (Read error: Connection reset by peer)
16:59:47  * bobmcwjoined
16:59:47  * bobmcwquit (Changing host)
16:59:47  * bobmcwjoined
17:01:49  * bobmcwquit (Read error: Connection reset by peer)
17:01:58  * bobmcwjoined
17:33:35  * bradleymeckquit (Quit: bradleymeck)
17:39:33  <caitp>aklein: want to cast your vote on whether to keep the turbofan impl of A.p.includes, or only use the C++ impl?
17:39:44  <caitp>or otherwise add suggestions for test cases that might improve coverage
17:40:24  * zvquit (Ping timeout: 260 seconds)
17:40:53  <caitp>it sounds like the TF and C++ impls are both looking pretty good, but it would be good to get feedback from another reviewer since the impl is big
17:51:22  * bradleymeckjoined
18:02:28  * bradleymeckquit (Quit: bradleymeck)
18:34:16  <Tweth-U-PDS>I tried executing get_toolchain_if_necessary.py manually, no error displayed other than "Please follow the instructions at https://www.chromium.org/developers/how-tos/build-instructions-windows"
18:35:26  <Tweth-U-PDS>Also thought my clone/checkout might be corrupt, so tried to download the whole thing again... :( Having bad luck with this!
18:43:03  * bobmcwquit (Read error: Connection reset by peer)
18:50:15  * bobmcwjoined
18:53:11  * bobmcwquit (Read error: Connection reset by peer)
18:53:43  * bobmcwjoined
18:53:59  * bobmcwquit (Changing host)
18:53:59  * bobmcwjoined
19:53:42  * bobmcwquit (Read error: Connection reset by peer)
19:56:37  * bobmcwjoined
20:06:46  * zvjoined
20:07:05  * bobmcwquit (Ping timeout: 244 seconds)
20:07:51  * bobmcwjoined
20:07:51  * bobmcwquit (Changing host)
20:07:51  * bobmcwjoined
20:25:29  * zvquit (Ping timeout: 260 seconds)
20:29:51  * seventhquit (Ping timeout: 244 seconds)
21:07:17  <aklein>caitp: sorry, still digging out from TC39 last week...will try to look this afternoon
21:07:53  <caitp>thanks, no rush
21:11:14  <aklein>caitp: so is bmeurer saying to keep the TF impl but cbruni is skeptical?
21:12:00  <caitp>I think camillo would prefer, if there were only one implementation, to be the C++ version, because debugging/maintaining it is easier
21:12:10  <caitp>if anyone was skeptical I think it was Jakob
21:13:12  * bobmcwquit (Remote host closed the connection)
21:14:01  <aklein>ah
21:14:31  <aklein>yeah, makes sense...seems weird to delete it if you have it working anyway :)
21:14:56  <caitp>so what about test coverage? am I missing anything obvious there?
21:22:00  <aklein>oh these tests are horrifying (that you need them, not that they exist)
21:22:25  <aklein>this looks like way better test coverage than we have for any other TF builtins :)
21:23:51  <aklein>500 lines of code for the TF stub is a little sad
21:30:52  <caitp>it might be possible to make them easier to maintain with some kind of metaprogramming to generate the TF builtin, but I'm not sure
21:33:12  <caitp>the crankshaft metaprogramming tools actually make the hydrogen.cc stuff fairly readable, it seems like it would help to have that in TF too
21:33:31  <caitp>LoopBuilder / IfBuilder and friends
21:34:22  <caitp>for some reason they depend on AstGraphBuilder currently though :(
22:34:28  * RT|Chatzillajoined
22:49:17  * plutoniixquit (Quit: Leaving)
23:16:08  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "Test262" on http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/10851 "V8 Linux64 - debug" from 282cdf28ae13fbe6bca5cc4bd35d1f4e37372073: [email protected])
23:37:19  <trungl-bot>Tree opened by [email protected]: Tree is open (Automatic: Kila la kheri!)