00:24:48  * plutoniixjoined
01:12:40  * joyeejoined
01:16:49  * joyeequit (Ping timeout: 240 seconds)
02:23:00  <trungl-bot>Tree closed by [email protected]: closed (http://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20v8rel/builds/61681 from None)
02:28:01  <trungl-bot>Tree opened by [email protected]: Tree is open (Automatic: Suwertehin ka sana)
02:49:21  * joyeejoined
03:31:31  * bradleymeckquit (Quit: bradleymeck)
03:34:02  * Guest59joined
03:37:00  * Guest59_quit (Ping timeout: 276 seconds)
03:40:51  * Garbeequit (Quit: Connection closed for inactivity)
05:18:45  * BobGneujoined
05:41:24  * deamquit (Quit: Connection closed for inactivity)
08:23:24  * BobGneuquit (Read error: Connection reset by peer)
09:06:59  * ilyaigpetrovjoined
09:24:39  * xaxxonjoined
10:06:40  * xaxxonquit (Read error: Connection reset by peer)
10:18:23  * plutoniixquit (Quit: Leaving)
10:30:09  <trungl-bot>Tree closed by [email protected]: closed (http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/builds/14754 from 4123a3dd790495c40cf839990318a85c146e057d)
10:36:19  * dchengjoined
10:36:28  * dchengpart
10:42:13  <trungl-bot>Tree opened by [email protected]: open
10:58:59  * xaxxonjoined
11:22:35  * xaxxonquit (Ping timeout: 264 seconds)
11:44:07  * Garbeejoined
13:49:47  * bradleymeckjoined
13:52:05  * bradleymeckquit (Client Quit)
13:53:15  * bobmcwquit (Read error: Connection reset by peer)
13:54:02  * bobmcwjoined
13:57:48  * bradleymeckjoined
14:06:35  * bradleymeckquit (Remote host closed the connection)
14:54:55  * bradleymeckjoined
15:54:22  * hferreiroquit (Quit: Connection closed for inactivity)
16:02:35  * joyeequit (Remote host closed the connection)
16:11:35  <bradleymeck>mmmm Module::Evaluate has a Local<Value> return but always seems to be empty
16:17:47  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
16:20:47  <bradleymeck>s/empty/undefined/
16:39:24  * trungl-botquit (Remote host closed the connection)
16:39:44  * trungl-botjoined
16:45:58  * trungl-botquit (Ping timeout: 240 seconds)
16:47:06  * trungl-botjoined
16:51:33  * trungl-botquit (Ping timeout: 256 seconds)
17:05:29  * seventhjoined
17:09:23  <bradleymeck>recompiling against v8 master I guess
17:17:32  * bradleymeckquit (Quit: bradleymeck)
17:25:51  * trungl-botjoined
17:41:32  * mylesborinsjoined
17:41:43  <mylesborins>I should probably idle here too :D
17:45:03  * bradleymeckjoined
17:57:36  <trungl-bot>Tree closed by [email protected]: closed (http://build.chromium.org/p/client.v8.fyi/builders/V8%20Linux%20GN/builds/7597 from 94bf354af55261a9a3c6f994b338627bb56231d2)
18:03:59  * Net147quit (Ping timeout: 264 seconds)
18:05:24  * Net147joined
18:48:18  <aklein>bradleymeck: if your module throws an exception during Evaluate then the MaybeLocal will be empty
18:48:22  <aklein>that's really all the return value is for
18:48:42  <bradleymeck>so it isn't like Script? that returns the last value?
18:49:12  <aklein>I would actually expect it to return the last value, but since that's not part of the specced behavior I don't think I've written a test for it
18:49:44  <aklein>actually given how it's parsed it's not super surprising to me if it always returns undefined
18:51:00  <trungl-bot>Tree opened by [email protected] (:aklein): Tree is open
18:54:58  * seventhquit (Remote host closed the connection)
19:13:42  * ilyaigpetrovquit (Quit: Connection closed for inactivity)
19:16:04  <bradleymeck>aklein: unsure how to get values into/out of ESM w/o that unless you are using some form of global?
19:17:37  <aklein>bradleymeck: what do you mean? the way to get values out of a module is to export them
19:17:50  <bradleymeck>how to I get an export in C++ land?
19:18:37  <aklein>bradleymeck: I think the easiest thing would be to expose GetNamespaceObject() on v8::Module
19:18:52  <bradleymeck>that makes things harder
19:18:54  <aklein>which would return you a the Namespace object as a v8::Object
19:18:55  <bradleymeck>mmm
19:19:02  <aklein>what things?
19:19:20  <bradleymeck>CJS->ESM ~= 'export default module.exports // how to pass in module.exports'
19:19:35  <bradleymeck>it gets really gross once we start needing to set those after init
19:20:31  <bradleymeck>so I was using something like https://gist.github.com/bmeck/c01f47fa95ca21a5f4901746df61885d
19:20:59  <bradleymeck>that avoids needing to have a sanitary module that doesn't leak the setter
19:34:18  <aklein>I was thinking that for the production version of the CJS->ESM thing we might need to add totally new API
19:34:39  <bradleymeck>i don't think so?
19:34:52  <bradleymeck>if you want to, go for it
19:42:27  <bradleymeck>aklein: lmk if you have time for a short call, just trying to figure out why CompileModule is being odd / can clarify a few things it sounds like
19:44:16  <jwolfe>i don't understand this error, and i don't understand Yang's suggestion: https://codereview.chromium.org/2156303002/#msg61
19:47:52  <jwolfe>i rebased onto master just now and there were no conflicts
19:48:11  <aklein>jwolfe: pretty sure he meant "rebase"
19:48:27  <aklein>CLs don't really have "names"
19:48:57  <jwolfe>aklein: that makes more sense. but also i just rebased locally, and there were no conflicts. why would the bot get a conflict if i don't?
19:50:10  <aklein>not sure; I'd try uploading and ticking the CQ checkbox again
19:50:33  <aklein>jwolfe: sometimes your local git history helps git do a rebase where the CQ just uses a patch of the diff
19:50:47  <aklein>or at least, so it's seemed to me at times (git is occasionally a black box)
19:50:49  <jwolfe>well, i squashed first
19:53:39  <jwolfe>did i hear that there was a new codereview system that we can use? and if so, does it track the upstream commit that a patch is based on as well as a diff from it?
19:59:07  * trungl-botquit (Ping timeout: 256 seconds)
20:27:22  * trungl-botjoined
20:41:34  <aklein>jwolfe: I hope it does, since it is git-aware (but I haven't actually tried to use it yet)
20:41:54  <aklein>https://groups.google.com/d/msg/v8-dev/gzfeEUSInVU/jB-4hmseAgAJ
20:56:14  * bradleymeck_joined
20:56:37  * bradleymeckquit (Ping timeout: 240 seconds)
20:56:38  * bradleymeck_changed nick to bradleymeck
22:00:06  * xaxxonjoined
22:11:03  * xaxxonquit (Read error: Connection reset by peer)
22:11:48  * bradleymeckquit (Quit: bradleymeck)
22:11:57  * xaxxonjoined
22:49:44  * RT|Chatzillajoined
22:56:02  * xaxxon_joined
22:59:47  * xaxxonquit (Ping timeout: 264 seconds)
23:08:07  * xaxxon_quit (Read error: Connection reset by peer)
23:08:13  * xaxxon__joined
23:08:50  * joyeejoined
23:09:29  * bradleymeckjoined
23:10:53  * joyeequit (Remote host closed the connection)
23:38:25  * xaxxon__quit (Read error: Connection reset by peer)
23:39:11  * xaxxonjoined