| 00:10:07
| * bradleymeck | quit (Quit: bradleymeck) |
| 00:56:52
| * plutoniix | joined |
| 01:03:02
| * kenansulayman | joined |
| 02:22:05
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 03:23:23
| * mastr_bennett[x] | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 04:42:22
| * Tweth-V-PDS | quit (Read error: Connection reset by peer) |
| 05:33:40
| * joyee | joined |
| 05:46:25
| * sxa | quit (Read error: Connection reset by peer) |
| 05:56:03
| * xaxxon | joined |
| 06:19:17
| * xaxxon | quit (Read error: Connection reset by peer) |
| 06:20:06
| * xaxxon | joined |
| 06:42:02
| * joyee | quit (Ping timeout: 240 seconds) |
| 06:59:28
| * joyee | joined |
| 08:09:27
| * xaxxon_ | joined |
| 08:10:57
| * xaxxon | quit (Ping timeout: 240 seconds) |
| 08:23:40
| * joyee | quit (Remote host closed the connection) |
| 08:30:04
| * joyee | joined |
| 08:59:01
| * joyee | quit (Remote host closed the connection) |
| 09:28:26
| <trungl-bot> | Tree closed by [email protected]: closed (/builders/V8%20Win64%20-%20debug/builds/16521 from 81253a52964a9727959b5b55fc0f138ee6ab82c9) |
| 10:02:39
| <trungl-bot> | Tree opened by [email protected]: open |
| 10:25:09
| * mylesborins | quit (Quit: farewell for now) |
| 10:25:40
| * mylesborins | joined |
| 10:57:32
| * plutoniix | quit (Quit: Leaving) |
| 11:47:01
| * joyee | joined |
| 11:49:29
| * joyee | quit (Remote host closed the connection) |
| 11:49:46
| * joyee | joined |
| 11:55:11
| * joyee | quit (Remote host closed the connection) |
| 12:13:21
| * xaxxon_ | quit (Read error: Connection reset by peer) |
| 12:14:35
| * xaxxon_ | joined |
| 12:21:25
| * joyee | joined |
| 13:16:40
| * mounibec | joined |
| 13:20:12
| * bradleymeck | joined |
| 13:28:34
| * littledan | quit (Read error: Connection reset by peer) |
| 13:28:52
| * littledan | joined |
| 13:28:57
| * stalled | quit (Ping timeout: 240 seconds) |
| 13:40:53
| * Tweth-U-PDS | joined |
| 13:46:22
| * stalled | joined |
| 13:56:27
| * saper | quit (Ping timeout: 240 seconds) |
| 14:00:03
| * unixpickle | joined |
| 15:09:36
| * mounibec | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 15:27:55
| * mounibec | joined |
| 15:59:16
| * seventh | joined |
| 16:10:16
| * bradleymeck | quit (Quit: bradleymeck) |
| 16:15:25
| * zv | quit (Ping timeout: 268 seconds) |
| 16:15:38
| <jwolfe> | looks like the pattern in v8 for using ICU is that if you get an UErrorCode, you just check U_FAILURE or U_SUCCESS, effectively reducing it to a boolean; you never expose the specifics of the status to the caller. |
| 16:21:28
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 16:31:07
| * bradleymeck | joined |
| 16:47:33
| * joyee | quit (Remote host closed the connection) |
| 16:50:20
| * RT|Chatzilla | quit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309]) |
| 16:53:04
| * bradleymeck | quit (Quit: bradleymeck) |
| 16:54:44
| * unixpickle | joined |
| 17:03:07
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 17:04:23
| * unixpickle | joined |
| 17:08:52
| * unixpickle | quit (Client Quit) |
| 17:17:40
| * zv | joined |
| 17:24:35
| * mounibec | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 17:44:18
| * unixpickle | joined |
| 17:48:00
| * joyee | joined |
| 17:48:48
| * unixpickle | quit (Ping timeout: 240 seconds) |
| 17:50:26
| <jwolfe> | on master, i'm getting an error from run-tests.py that the mkgrokdump executable doesn't exist. |
| 17:50:30
| <jwolfe> | anyone else getting this? |
| 17:52:44
| * joyee | quit (Ping timeout: 260 seconds) |
| 18:08:30
| <caitp> | jwolfe: it's a target |
| 18:08:40
| <caitp> | you have to build it |
| 18:08:52
| <jwolfe> | is it new? |
| 18:09:27
| <caitp> | 9d71683e115d3ec9a99552580b47531b7147d626 is pretty recent |
| 18:10:12
| <caitp> | yeah, it seems to have started landing a week or 2 ago |
| 18:10:51
| <jwolfe> | ok, that's the problem. i gotta update my bash alias that invokes ninja properly with the new target. |
| 18:28:11
| * joyee | joined |
| 18:32:40
| * joyee | quit (Ping timeout: 240 seconds) |
| 18:41:54
| * plutoniix | joined |
| 18:59:50
| * unixpickle | joined |
| 19:10:20
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 19:14:40
| * zv | quit (Ping timeout: 240 seconds) |
| 19:15:55
| * zv | joined |
| 19:18:11
| <aklein> | caitp: https://chromium-review.googlesource.com/c/490648/ is pretty scary |
| 19:18:48
| <caitp> | I'm sure it's just something adding a ContextScope where it doesn't need it |
| 19:19:11
| <caitp> | the dcheck failures in the non for-await-of tests don't break Chrome |
| 19:19:52
| <caitp> | probably |
| 19:28:24
| * watilde | joined |
| 19:44:06
| * unixpickle | joined |
| 20:00:44
| * zv | quit (Ping timeout: 255 seconds) |
| 20:09:18
| * unixpickle | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 20:14:04
| * unixpickle | joined |
| 20:16:54
| * zv | joined |
| 20:18:43
| * unixpickle | quit (Read error: Connection reset by peer) |
| 20:19:01
| * joyee | joined |
| 20:20:51
| * seventh | quit (Ping timeout: 268 seconds) |
| 20:23:28
| * joyee | quit (Ping timeout: 260 seconds) |
| 20:23:28
| * zv | quit (Ping timeout: 260 seconds) |
| 20:23:31
| <caitp> | aklein: I noted on the bug how it can be fixed, but I'm not entirely sure how I want to go about doing that, I don't want to add another ScopeRewriter AST walker |
| 20:24:03
| <aklein> | caitp: let's implement backtracking in the parser like we should have done 2 years ago :) |
| 20:30:32
| <caitp> | I'm not sure how much backtracking would help in this case |
| 20:30:45
| <caitp> | but it would be good if there was a faster way to move scopes around |
| 20:33:07
| * bradleymeck | joined |
| 20:36:15
| <aklein> | caitp: for some of this stuff we do have the Scope::Snapshot::Reparent stuff that Toon came up with |
| 20:36:30
| <aklein> | I believe the only place we currently use the scope rewriter is for evals in arrow function params |
| 20:36:37
| <aklein> | (the one that walks the AST) |
| 20:37:20
| <caitp> | Scope::Snapshot looked reasonable, but in this case needs to be re-arranged to reparent to non-DeclarationScopes |
| 20:49:20
| * watilde | quit (Quit: Leaving...) |
| 20:49:36
| * watilde | joined |
| 20:52:15
| * watilde | quit (Client Quit) |
| 20:52:33
| * watilde | joined |
| 20:53:20
| * watilde | quit (Client Quit) |
| 20:55:28
| * watilde | joined |
| 20:56:26
| * watilde | quit (Client Quit) |
| 21:06:28
| * mounibec | joined |
| 21:09:10
| * joyee | joined |
| 21:12:04
| * bradleymeck | quit (Quit: bradleymeck) |
| 21:13:58
| * joyee | quit (Ping timeout: 260 seconds) |
| 21:33:31
| * xaxxon_ | quit (Ping timeout: 255 seconds) |
| 21:34:01
| * mounibec | quit (Quit: My Mac has gone to sleep. ZZZzzz…) |
| 21:56:50
| * plutoniix | quit (Ping timeout: 240 seconds) |
| 22:00:16
| * plutoniix | joined |
| 22:04:56
| * plutoniix | quit (Ping timeout: 252 seconds) |
| 22:07:15
| * plutoniix | joined |
| 22:19:06
| * joyee | joined |
| 22:23:24
| * joyee | quit (Ping timeout: 260 seconds) |
| 22:31:08
| * xaxxon | joined |
| 22:34:49
| * joyee | joined |
| 22:39:00
| * joyee | quit (Ping timeout: 245 seconds) |
| 22:57:08
| * RT|Chatzilla | joined |
| 23:14:20
| * saper | joined |
| 23:14:20
| * saper | quit (Changing host) |
| 23:14:20
| * saper | joined |
| 23:26:10
| * zv | joined |
| 23:37:57
| * zv | quit (Ping timeout: 240 seconds) |
| 23:44:27
| * joyee | joined |
| 23:48:48
| * joyee | quit (Ping timeout: 240 seconds) |