00:25:34  * xaxxonjoined
01:08:07  * AtumTquit (Remote host closed the connection)
02:56:06  * bradleymeckjoined
03:01:26  * plutoniixquit (Quit: Leaving)
03:21:41  * not-an-aardvarkjoined
03:24:09  * xaxxonquit (Ping timeout: 252 seconds)
03:25:42  * xaxxonjoined
03:43:48  <not-an-aardvark>I'm working on submitting a bugfix to v8, and as suggested at https://github.com/v8/v8/wiki/Contributing#submit-your-code I'm running all the tests locally. Is it normal that the tests are on pace to finish in about 12.5 hours?
03:44:31  <not-an-aardvark>This seems inconvenient, which makes me wonder if there is another workflow I should be following instead (e.g. a way to only run the tests relevant to my change).
03:45:35  <not-an-aardvark>I'm currently running the tests with `tools/run-tests.py --gn --quickcheck`.
03:50:12  <caitp>not-an-aardvark 12.5 hours seems like a really long time
03:50:15  <caitp>is it a debug build?
03:51:38  <not-an-aardvark>Yes. Should I run the tests on a production build instead?
03:53:03  <caitp>that's generally faster
03:53:23  <caitp>you could also just run a relevant subset of tests
03:54:05  <caitp>what's the bug?
03:54:51  <not-an-aardvark>https://bugs.chromium.org/p/v8/issues/detail?id=7502
03:55:41  <caitp>right, so for that you can probably be fine with just `run-tests.py --gn mjsunit/es6/*` and `cctest`
03:55:46  <not-an-aardvark>I was trying to run just the test that I added by using `tools/run-tests.py --arch=x64 test/message/fail/octal-template-literal.js`, but I got a "Failed to load build config" error.
03:55:51  <caitp>maybe the message tests too
03:56:44  <not-an-aardvark>Ok I'll try that, thanks for the help
03:57:29  <caitp>you need both --arch and --mode for that to work
03:57:38  <caitp>like --arch=x64 --mode=release
04:02:51  <not-an-aardvark>Makes sense, I'm currently waiting for the release build to finish so that I can try that out.
04:10:42  * akleinquit (Read error: Network is unreachable)
04:10:42  * scottmgquit (Read error: Connection reset by peer)
04:10:47  * littledanquit (Read error: Connection reset by peer)
04:10:47  * thefourtheyequit (Read error: Connection reset by peer)
04:10:47  * gsathyaquit (Read error: Connection reset by peer)
04:10:49  * musgravejw_quit (Ping timeout: 256 seconds)
04:10:50  * ofrobotsquit (Read error: Connection reset by peer)
04:10:53  * wycatsquit (Read error: Connection reset by peer)
04:11:00  * dagobert__quit (Read error: Connection reset by peer)
04:11:05  * mikolalysenkoquit (Read error: Connection reset by peer)
04:11:07  * cloudshuquit (Read error: Connection reset by peer)
04:11:07  * jochen__quit (Read error: Connection reset by peer)
04:11:12  * joyeequit (Read error: Connection reset by peer)
04:11:13  * paulfryzelquit (Ping timeout: 240 seconds)
04:11:17  * not-an-aardvarkquit (Read error: Network is unreachable)
04:11:20  * bterlsonquit (Read error: Connection reset by peer)
04:11:27  * hatf0quit (Ping timeout: 252 seconds)
04:11:28  * pcarrierquit (Read error: Connection reset by peer)
04:11:33  * dherman_quit (Ping timeout: 240 seconds)
04:12:11  * chimera3___quit (Ping timeout: 252 seconds)
04:12:13  * devsnekquit (Ping timeout: 240 seconds)
04:12:27  * paulfryzeljoined
04:12:31  * benglquit (Ping timeout: 256 seconds)
04:12:32  * ofrobotsjoined
04:12:32  * gsathyajoined
04:12:33  * ErikCorryquit (Ping timeout: 240 seconds)
04:12:34  * musgravejw_joined
04:12:38  * devsnekjoined
04:12:43  * wycatsjoined
04:12:46  * joyeejoined
04:12:49  * arvquit (Ping timeout: 256 seconds)
04:13:56  * dagobert__joined
04:14:16  * dherman_joined
04:14:35  * bengljoined
04:15:00  * akleinjoined
04:15:06  * chimera3___joined
04:15:24  * hatf0joined
04:15:27  * cloudshujoined
04:15:27  * mikolalysenkojoined
04:15:39  * arvjoined
04:15:50  * pcarrierjoined
04:16:39  * scottmgjoined
04:16:40  * thefourtheyejoined
04:17:38  * bradleymeckquit (Quit: bradleymeck)
04:18:29  * jochen__joined
04:18:35  * ErikCorryjoined
04:18:46  * littledanjoined
04:29:08  * not-an-aardvarkjoined
04:39:59  * bterlsonjoined
09:18:16  <trungl-bot>Tree closed by [email protected]: Tree is closed (Automatic: "build addons and test node.js" on "V8 Linux64 - node.js integration" [email protected],[email protected])
09:21:06  * not-an-aardvarkquit (Quit: Connection closed for inactivity)
09:31:23  <trungl-bot>Tree opened by [email protected]: open - offending range reverted
10:14:42  <trungl-bot>Tree opened by [email protected]: open
10:38:39  * AtumTjoined
11:25:07  * mylesborinsquit (Quit: farewell for now)
11:25:38  * mylesborinsjoined
12:46:20  * xaxxonquit (Quit: xaxxon)
13:54:08  * bradleymeckjoined
14:11:20  <trungl-bot>Tree closed by [email protected]: closed (https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/1666 from fdbb5bebb4bc11ffeb4a0f102d15d8317e496d70)
14:19:24  <trungl-bot>Tree opened by [email protected]: open
14:49:31  * bradleymeckquit (Quit: bradleymeck)
15:30:54  * ofrobotsquit (Read error: Connection reset by peer)
15:32:38  * ofrobotsjoined
15:54:36  * bradleymeckjoined
16:49:45  * bradleymeckquit (Quit: bradleymeck)
17:09:36  * bradleymeckjoined
17:10:18  * RT|Chatzillaquit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2010030309])
17:29:17  * AtumT_joined
17:30:57  * bradleymeckquit (Quit: bradleymeck)
17:32:09  * AtumTquit (Ping timeout: 260 seconds)
17:43:01  * AtumTjoined
17:43:13  * AtumT_quit (Ping timeout: 240 seconds)
18:42:07  * guest_0141joined
18:43:19  <guest_0141>Can anyone explain the message "Insufficient type feedback for generic named access" to me?
18:43:56  <guest_0141>Not many hits on the web for an answer and I didn't find anything looking throught the v8 source
18:47:02  <aklein>guest_0141: this v8-users thread gives one example: https://groups.google.com/d/msg/v8-users/hVu7uhH0VR0/71WAUmVEEAAJ
18:51:38  * seventhjoined
18:52:50  <guest_0141>aklein: that helps a little, how do I make sure "a property is exercised"?
18:56:47  <aklein>guest_0141: what that means is that, in the example, we never hit the "o.y" expression before optimization. how to "make sure" a property is exercised is pretty application-specific, though
18:57:13  <aklein>one thing to keep in mind is that "deoptimization" is not necessarily something that can, or should, be avoided
18:57:27  <aklein>it just means that the system was over-optimistic in its abilities, and will hopefully recover
19:01:18  <guest_0141>in this case it shouldn't deopt, it happens on a call to "DataView.setUint32"
19:02:01  <guest_0141>I can pack the array with bit ops, but I'm hoping not to resort to that.
19:07:55  <guest_0141>that's annoying, I left it running and v8 optimized it again later and didn't deop
19:18:08  <aklein>guest_0141: that's exactly what's supposed to happen: optimize, deopt, re-optimize
19:18:29  <aklein>deopts should only really start worrying ypu if they go in a never-ending loop
19:54:51  * seventhquit (Quit: ...)
20:10:39  * guest_0141quit (Ping timeout: 260 seconds)
21:07:17  * not-an-aardvarkjoined
21:28:29  * AtumTquit (Ping timeout: 240 seconds)
21:31:12  * AtumTjoined
23:14:04  * RT|Chatzillajoined
23:20:00  <caitp>where the heck is DataView.setUint32 implemented anyway? I see it installed in the bootstrapper, but grepping for the builtin isn't turning up any implementation >_-
23:21:38  <caitp>oh I see, a c++ builtin
23:23:43  <caitp>the only way I could see that line causing a deopt, given that afaict TF doesn't do any inlining for the DataViewPrototypeSet* builtins (at least not in JSCallReducer?), is the property load for the method itself
23:25:29  <caitp>so, I guess that most likely happens if you're adding or deleting properties from the DataView instance itself?
23:25:35  <caitp>dunno though
23:32:48  * bradleymeckjoined
23:56:58  * not-an-aardvarkquit (Quit: Connection closed for inactivity)