| 00:14:27
| * plutoniix | quit (Ping timeout: 240 seconds) |
| 00:38:27
| * AtumT | quit (Ping timeout: 240 seconds) |
| 01:11:52
| * AtumT | joined |
| 01:17:29
| * plutoniix | joined |
| 01:32:18
| * cloudshu | quit (Quit: Connection closed for inactivity) |
| 02:12:56
| * plutoniix | quit (Ping timeout: 276 seconds) |
| 07:16:59
| * plutoniix | joined |
| 08:57:17
| <trungl-bot> | Tree closed by [email protected]: closed (https://ci.chromium.org/buildbot/client.v8/V8%20Win32/14258 from d69df91c27018affdba41f89abea59ff4887c30b) |
| 09:06:20
| <trungl-bot> | Tree opened by [email protected]: open - https://crbug.com/v8/7775 |
| 10:25:09
| * mylesborins | quit (Quit: farewell for now) |
| 10:25:39
| * mylesborins | joined |
| 10:50:22
| * plutoniix | quit (Quit: Leaving) |
| 11:42:37
| <trungl-bot> | Tree closed by [email protected]: closed (https://ci.chromium.org/buildbot/client.v8/V8%20Win32/14264 from bae176e4274f269958dacbe16af775c3b0e90625) |
| 12:00:44
| <trungl-bot> | Tree opened by [email protected]: open - https://crbug.com/v8/7775 |
| 13:14:15
| <trungl-bot> | Tree closed by [email protected]: closed (https://ci.chromium.org/buildbot/client.v8/V8%20Win32/14268 from b9401e42d13bb2ba42c464f895fa346c10b19f86) |
| 15:10:10
| <trungl-bot> | Tree opened by [email protected]: open (CL disabling failing test is about to land: https://crrev.com/c/1102512) |
| 16:05:37
| <trungl-bot> | Tree opened by [email protected]: open |
| 16:26:10
| * cloudshu | joined |
| 16:38:04
| * RT|Chatzilla | quit (Quit: ChatZilla 0.9.86.1 [Firefox 2.0.0.22pre/2016020317]) |
| 17:43:26
| * seventh | joined |
| 19:57:44
| * seventh | quit (Remote host closed the connection) |
| 20:28:06
| <dherman> | how do V8 hackers poke at `v8:internal` types in LLDB? |
| 20:28:19
| <dherman> | I want to call `isolate->has_pending_exception() |
| 20:28:24
| <dherman> | ` |
| 20:28:59
| <dherman> | https://www.irccloud.com/pastebin/SWxBLU2O/ |
| 22:14:51
| <devsnek> | dherman: you can directly cast v8::Isolate to v8::internal::Isolate |
| 22:15:42
| <dherman> | Right but I don’t know how to get v8::internal::Isolate in scope |
| 22:15:55
| <dherman> | In a node plugin, specifically |
| 22:16:32
| <dherman> | Or just in LLDB |
| 22:16:45
| <dherman> | I just want to do it for debugging |
| 22:17:26
| <devsnek> | include src/isolate.h |
| 22:17:33
| <devsnek> | but its a rabbit hole |
| 22:18:30
| <dherman> | Like should I just use an absolute path to the header in a clone of V8? |
| 22:18:41
| <dherman> | Seems likely to not compile :) |
| 22:18:41
| <devsnek> | you could but |
| 22:18:50
| <devsnek> | yea |
| 22:18:56
| <devsnek> | that includes a bunch of stuff |
| 22:19:00
| <devsnek> | and that stuff includes a bunch of stuff |
| 22:19:05
| <dherman> | Hee hee |
| 22:19:15
| <devsnek> | i'm surprised there's no Isolate::HasPendingException |
| 22:19:40
| <devsnek> | would be easy to add |
| 22:19:44
| <dherman> | I guess if node vendors V8 I could do a custom build of node |
| 22:19:47
| <dherman> | And then add that |
| 22:19:57
| <devsnek> | oh you're messing with node? |
| 22:20:08
| <dherman> | I’m just writing node plugins |
| 22:20:08
| <devsnek> | node has its own checkout of v8 |
| 22:20:10
| <devsnek> | in deps/v8 |
| 22:20:17
| <dherman> | But I could make a custom build |
| 22:20:22
| <devsnek> | yea you could |
| 22:20:24
| <dherman> | Seems like a good path to try |
| 22:20:28
| <devsnek> | you could also submit a change to v8 |
| 22:20:34
| <dherman> | Thanks for the idea |
| 22:20:39
| <devsnek> | and then open up a cherry pick pr to node |
| 22:20:58
| <dherman> | I’ll see how hard it is to learn how to contribute to v8 ;) |
| 22:21:08
| <devsnek> | its harder than most things |
| 22:21:12
| <dherman> | Lol |
| 22:21:27
| <devsnek> | https://www.chromium.org/developers/contributing-code |
| 22:21:30
| <devsnek> | if you follow this |
| 22:21:40
| <devsnek> | except apply it all to the v8 repo |
| 22:21:55
| <dherman> | Ok cool. Thanks so much for the tips! |
| 22:22:05
| <devsnek> | 👍 |
| 23:21:46
| * RT|Chatzilla | joined |